From nobody@FreeBSD.org  Sun Dec 19 19:05:00 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AFBA61065674
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Dec 2010 19:05:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F1588FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Dec 2010 19:05:00 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oBJJ50aP060185
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Dec 2010 19:05:00 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id oBJJ50F0060184;
	Sun, 19 Dec 2010 19:05:00 GMT
	(envelope-from nobody)
Message-Id: <201012191905.oBJJ50F0060184@red.freebsd.org>
Date: Sun, 19 Dec 2010 19:05:00 GMT
From: Steve Wills <steve@mouf.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] include pidfile in rc script of databases/mysql51-server
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         153296
>Category:       ports
>Synopsis:       [PATCH] include pidfile in rc script of databases/mysql51-server
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ale
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 19 19:10:04 UTC 2010
>Closed-Date:    Mon Dec 20 08:58:55 UTC 2010
>Last-Modified:  Mon Dec 20 09:00:21 UTC 2010
>Originator:     Steve Wills
>Release:        8.2-PRERELEASE
>Organization:
>Environment:
>Description:
Recent changes to the rc script for mysql removed the pidfile, causing rc.subr to search for mysqld via name. This causes it to find mysql processes it shouldn't find, such as those running outside or inside a chroot or those created by akonadi. Putting the pidfile back fixes it.
>How-To-Repeat:
deinstall mysql while running kde4 and/or inside a ports tinderbox
>Fix:
See attached patch

Patch attached with submission follows:

Index: files/mysql-server.sh.in
===================================================================
RCS file: /home/ncvs/ports/databases/mysql51-server/files/mysql-server.sh.in,v
retrieving revision 1.9
diff -u -r1.9 mysql-server.sh.in
--- files/mysql-server.sh.in	16 Dec 2010 08:27:58 -0000	1.9
+++ files/mysql-server.sh.in	19 Dec 2010 16:53:52 -0000
@@ -37,6 +37,7 @@
 
 mysql_user="mysql"
 mysql_limits_args="-e -U ${mysql_user}"
+pidfile=${mysql_pidfile}
 command="/usr/sbin/daemon"
 command_args="-c -f %%PREFIX%%/bin/mysqld_safe --defaults-extra-file=${mysql_dbdir}/my.cnf --user=${mysql_user} --datadir=${mysql_dbdir} --pid-file=${mysql_pidfile} ${mysql_args}"
 procname="%%PREFIX%%/libexec/mysqld"


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ale 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Dec 19 19:10:11 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153296 
State-Changed-From-To: open->closed 
State-Changed-By: ale 
State-Changed-When: Mon Dec 20 08:58:38 UTC 2010 
State-Changed-Why:  
Fixed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153296 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153296: commit references a PR
Date: Mon, 20 Dec 2010 08:58:03 +0000 (UTC)

 ale         2010-12-20 08:57:57 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/mysql51-server Makefile 
     databases/mysql51-server/files mysql-server.sh.in 
   Log:
   Fix startup script and bump PORTREVISION.
   
   PR:             ports/153296 [1]
   Submitted by:   Steve Wills <steve@mouf.net> [1], dougb
   Lesson learned: Two identical PRs don't make a good patch.
   
   Revision  Changes    Path
   1.273     +1 -1      ports/databases/mysql51-server/Makefile
   1.10      +3 -4      ports/databases/mysql51-server/files/mysql-server.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
