From kwm@FreeBSD.org  Thu Dec 16 17:45:28 2010
Return-Path: <kwm@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B2B661065672
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Dec 2010 17:45:28 +0000 (UTC)
	(envelope-from kwm@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 882F38FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Dec 2010 17:45:28 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBGHjSQo053555
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Dec 2010 17:45:28 GMT
	(envelope-from kwm@freefall.freebsd.org)
Received: (from kwm@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBGHjS8M053554;
	Thu, 16 Dec 2010 17:45:28 GMT
	(envelope-from kwm)
Message-Id: <201012161745.oBGHjS8M053554@freefall.freebsd.org>
Date: Thu, 16 Dec 2010 17:45:28 GMT
From: Koop Mast <kwm@FreeBSD.org>
Reply-To: Koop Mast <kwm@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] devel/ptlib26 fix build with alsa-libs
X-Send-Pr-Version: 3.113
X-GNATS-Notify: melifaro@ipfw.ru

>Number:         153223
>Category:       ports
>Synopsis:       [patch] devel/ptlib26 fix build with alsa-libs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kwm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 16 17:50:12 UTC 2010
>Closed-Date:    Mon Dec 27 11:41:47 UTC 2010
>Last-Modified:  Mon Dec 27 11:41:47 UTC 2010
>Originator:     Koop Mast
>Release:        FreeBSD 8.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 8.1-STABLE FreeBSD 8.1-STABLE #2 r215627: Sun Nov 21 13:36:51 UTC 2010 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386


	
>Description:
	Explicit disable alsa. It doesn't build and support is so-so.
	
>How-To-Repeat:
	
>Fix:

	

--- ptlib26-alsa.diff begins here ---
? devel/ptlib26/work
Index: devel/ptlib26/Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/ptlib26/Makefile,v
retrieving revision 1.12
diff -a -u -r1.12 Makefile
--- devel/ptlib26/Makefile	10 May 2010 21:09:09 -0000	1.12
+++ devel/ptlib26/Makefile	16 Dec 2010 17:32:32 -0000
@@ -29,7 +29,8 @@
 USE_LDCONFIG=	yes
 
 CFLAGS+=	-I${LOCALBASE}/include
-CONFIGURE_ARGS+=	--enable-oss --enable-plugins --with-expat-dir="${LOCALBASE}"
+CONFIGURE_ARGS+=	--enable-oss --enable-plugins --with-expat-dir="${LOCALBASE}" \
+		--enable-alsa=no
 
 OPTIONS=	ODBC		"Use ODBC" On \
 		V4L		"Use Video4Linux" Off \
--- ptlib26-alsa.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kwm 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Dec 16 17:50:30 UTC 2010 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153223 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Dec 16 17:50:34 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153223 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: melifaro@ipfw.ru
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/153223: [patch] devel/ptlib26 fix build with alsa-libs
Date: Thu, 16 Dec 2010 17:50:32 UT

 Maintainer of devel/ptlib26,
 
 Please note that PR ports/153223 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153223
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Alexander V. Chernikov" <melifaro@ipfw.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153223: [patch] devel/ptlib26 fix build with alsa-libs
Date: Mon, 27 Dec 2010 08:30:54 +0300

 This is a multi-part message in MIME format.
 --------------080002000701080804070903
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 Edwin Groothuis wrote:
 > Maintainer of devel/ptlib26,
 > 
 > Please note that PR ports/153223 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153223
 > 
 
 Thanks for submitting error report!
 
 Please apply the following patch:
 
 * Update to version 2.6.7
 * Add license info
 * Add ALSA option
 
 --------------080002000701080804070903
 Content-Type: text/plain;
  name="ptlib267_1.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="ptlib267_1.diff"
 
 diff -urN /usr/ports/devel/ptlib26/Makefile ptlib26/Makefile
 --- /usr/ports/devel/ptlib26/Makefile	2010-05-15 14:30:58.000000000 +0400
 +++ ptlib26/Makefile	2010-10-05 22:38:28.000000000 +0400
 @@ -6,20 +6,21 @@
  #
  
  PORTNAME=	ptlib
 -PORTVERSION=	2.6.5
 -PORTREVISION=	2
 +PORTVERSION=	2.6.7
  CATEGORIES=	devel
 -MASTER_SITES=	${MASTER_SITE_GNOME}
 -MASTER_SITE_SUBDIR=	sources/ptlib/2.6
 +MASTER_SITES=	SF/opalvoip/v3.6%20Lalande/Final/
  DISTNAME=	ptlib-${PORTVERSION}
  
  MAINTAINER=	melifaro@ipfw.ru
  COMMENT=	A cross platform C++ library, used by OPAL
  
 +LICENSE=MPL
 +
  LIB_DEPENDS=	expat.6:${PORTSDIR}/textproc/expat2
  
 -CONFLICTS=	pwlib-1.* ptlib-2.4.*
 +CONFLICTS=	pwlib-1.* ptlib-2.4.* ptlib-2.8.*
  
 +USE_BZIP2=	yes
  USE_BISON=	build
  USE_GMAKE=	yes
  GNU_CONFIGURE=	yes
 @@ -30,8 +31,10 @@
  
  CFLAGS+=	-I${LOCALBASE}/include
  CONFIGURE_ARGS+=	--enable-oss --enable-plugins --with-expat-dir="${LOCALBASE}"
 +CONFIGURE_ENV+=		OPENSSL_CFLAGS="-I${OPENSSLINC}" OPENSSL_LIBS="-L${OPENSSLLIB} -lssl"
  
  OPTIONS=	ODBC		"Use ODBC" On \
 +		ALSA		"Use ALSA (experimental)" Off \
  		V4L		"Use Video4Linux" Off \
  		BSDVIDEO	"Enable BSD video support" On \
  		SDL		"Use SDL" On \
 @@ -57,6 +60,15 @@
  CONFIGURE_ARGS+=	--disable-odbc
  .endif
  
 +.if defined(WITH_ALSA)
 +CONFIGURE_ARGS+=	--enable-alsa
 +PLIST_SUB+=	ALSA=""
 +LIB_DEPENDS+=		asound.2:${PORTSDIR}/audio/alsa-lib
 +.else
 +CONFIGURE_ARGS+=	--disable-alsa
 +PLIST_SUB+=	ALSA="@comment "
 +.endif
 +
  .if defined(WITH_BSDVIDEO)
  CONFIGURE_ARGS+=--enable-bsdvideo
  PLIST_SUB+=	BSDVIDEO=""
 @@ -130,6 +142,7 @@
  
  post-patch:
  	@${REINPLACE_CMD} -e 's|-lpt|-lpt-${PORTVERSION:C/.[0-9]+$//g}|' ${WRKSRC}/ptlib.pc.in
 +	@${REINPLACE_CMD} -e 's|-lasound|-lasound -L${LOCALBASE}/lib|' ${WRKSRC}/plugins/sound_alsa/Makefile
  .if ${ARCH} == sparc64 && ${OSVERSION} <= 700003
  	@${REINPLACE_CMD} -e 's|P_PTHREADS_XPG6|0|' ${WRKSRC}/src/ptlib/unix/tlibthrd.cxx
  .endif
 diff -urN /usr/ports/devel/ptlib26/distinfo ptlib26/distinfo
 --- /usr/ports/devel/ptlib26/distinfo	2010-05-15 14:30:58.000000000 +0400
 +++ ptlib26/distinfo	2010-05-30 11:02:11.000000000 +0400
 @@ -1,3 +1,3 @@
 -MD5 (ptlib-2.6.5.tar.gz) = a7381ea6bbd35ee15e21eb1be107d6d5
 -SHA256 (ptlib-2.6.5.tar.gz) = ae8ecf50a39d204910408934f2ab6965310e350c8c3ef4309dca985c761d05fb
 -SIZE (ptlib-2.6.5.tar.gz) = 4861936
 +MD5 (ptlib-2.6.7.tar.bz2) = 37279b5cf4aa64890eb9f38b4500ec6f
 +SHA256 (ptlib-2.6.7.tar.bz2) = 7dd28225fedd21154d34899b21ee4b6d27c88eb1a9f9931c8e6ced28e8f3b97f
 +SIZE (ptlib-2.6.7.tar.bz2) = 3275152
 diff -urN /usr/ports/devel/ptlib26/pkg-plist ptlib26/pkg-plist
 --- /usr/ports/devel/ptlib26/pkg-plist	2010-05-15 14:30:58.000000000 +0400
 +++ ptlib26/pkg-plist	2010-05-30 11:52:16.000000000 +0400
 @@ -157,9 +157,10 @@
  include/ptlib/videoio.h
  include/ptlib/videoio1394dc.h
  lib/libpt-%%PVERSION_MAJOR%%.so
 +lib/libpt-%%PVERSION_MAJOR%%.so.%%PVERSION_MINOR%%
  lib/libpt.so
  lib/libpt_s.a
 -lib/libpt-%%PVERSION_MAJOR%%.so.%%PVERSION_MINOR%%
 +%%ALSA%%lib/ptlib-%%PORTVERSION%%/devices/sound/alsa_pwplugin.so
  lib/ptlib-%%PORTVERSION%%/devices/sound/oss_pwplugin.so
  %%BSDVIDEO%%lib/ptlib-%%PORTVERSION%%/devices/videoinput/bsdvideo_pwplugin.so
  %%V4L%%lib/ptlib-%%PORTVERSION%%/devices/videoinput/v4l_pwplugin.so
 
 --------------080002000701080804070903--
State-Changed-From-To: feedback->closed 
State-Changed-By: kwm 
State-Changed-When: Mon Dec 27 11:40:52 UTC 2010 
State-Changed-Why:  
This patch was committed as part of PR: ports/151067. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153223 
>Unformatted:
