From obrien@NUXI.org  Thu Dec 16 03:06:23 2010
Return-Path: <obrien@NUXI.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 09E89106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Dec 2010 03:06:23 +0000 (UTC)
	(envelope-from obrien@NUXI.org)
Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85])
	by mx1.freebsd.org (Postfix) with ESMTP id CF59E8FC1B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 16 Dec 2010 03:06:22 +0000 (UTC)
Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1])
	by dragon.nuxi.org (8.14.4/8.14.4) with ESMTP id oBG36Mo6040859
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Dec 2010 19:06:22 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.org)
Received: (from obrien@localhost)
	by dragon.nuxi.org (8.14.4/8.14.4/Submit) id oBG36MZR040858;
	Wed, 15 Dec 2010 19:06:22 -0800 (PST)
	(envelope-from obrien)
Message-Id: <201012160306.oBG36MZR040858@dragon.nuxi.org>
Date: Wed, 15 Dec 2010 19:06:22 -0800 (PST)
From: "David O'Brien" <obrien@freebsd.org>
Reply-To: "David O'Brien" <obrien@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: pwsafe does not register all of its dependencies
X-Send-Pr-Version: 3.113
X-GNATS-Notify: donnex@donnex.net

>Number:         153198
>Category:       ports
>Synopsis:       sysutils/pwsafe does not register all of its dependencies
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sunpoet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 16 03:10:08 UTC 2010
>Closed-Date:    Mon Nov 28 19:15:39 UTC 2011
>Last-Modified:  Mon Nov 28 19:15:39 UTC 2011
>Originator:     David O'Brien
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD dragon.NUXI.org 9.0-CURRENT FreeBSD 9.0-CURRENT #654 r215604M: Sat Nov 20 19:51:27 PST 2010 rootk@dragon:/sys/i386/compile/DRAGON i386

>Description:
	sysutils/pwsafe does not state any build or run dependencies.
	Yet it depends on X (at least if X was already installed)
>How-To-Repeat:
	$ pkg_info -r pwsafe-0.2.0
	Information for pwsafe-0.2.0:

	Depends on:


	$ ldd /usr/local/bin/pwsafe | grep local

	/usr/local/bin/pwsafe:
	libSM.so.6 => /usr/local/lib/libSM.so.6 (0x280aa000)
	libICE.so.6 => /usr/local/lib/libICE.so.6 (0x280b2000)
	libXmu.so.6 => /usr/local/lib/libXmu.so.6 (0x280c9000)
	libX11.so.6 => /usr/local/lib/libX11.so.6 (0x280de000)
	libXt.so.6 => /usr/local/lib/libXt.so.6 (0x28606000)
	libXext.so.6 => /usr/local/lib/libXext.so.6 (0x28656000)
	libxcb.so.2 => /usr/local/lib/libxcb.so.2 (0x28665000)
	libXau.so.6 => /usr/local/lib/libXau.so.6 (0x2867c000)
	libXdmcp.so.6 => /usr/local/lib/libXdmcp.so.6 (0x2867f000)
	libpthread-stubs.so.0 => /usr/local/lib/libpthread-stubs.so.0 (0x28684000)
>Fix:
	Add dependancy.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->obrien 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Dec 17 09:40:56 UTC 2010 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Dec 17 09:41:00 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: donnex@donnex.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/153198: sysutils/pwsafe does not register all of its dependencies
Date: Fri, 17 Dec 2010 09:40:58 UT

 Maintainer of sysutils/pwsafe,
 
 Please note that PR ports/153198 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153198
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->open 
State-Changed-By: eadler 
State-Changed-When: Sat Sep 24 18:10:39 UTC 2011 
State-Changed-Why:  
feedback timeout 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 
Responsible-Changed-From-To: obrien->freebsd-ports-bugs 
Responsible-Changed-By: obrien 
Responsible-Changed-When: Thu Oct 6 05:12:54 UTC 2011 
Responsible-Changed-Why:  
I'm not the maintainer, and there is no patch from the maintainer to commit. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 
Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet 
Responsible-Changed-By: sunpoet 
Responsible-Changed-When: Thu Oct 20 18:01:09 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 
State-Changed-From-To: open->closed 
State-Changed-By: sunpoet 
State-Changed-When: Fri Oct 21 02:29:01 UTC 2011 
State-Changed-Why:  
Missing dependencies added. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153198: commit references a PR
Date: Fri, 21 Oct 2011 02:28:36 +0000 (UTC)

 sunpoet     2011-10-21 02:28:23 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/pwsafe      Makefile 
   Log:
   - Add missing dependencies according to the build log (-lSM -lICE -lXmu -lX11)
   - Bump PORTREVISION for dependency change
   
   PR:             ports/153198
   Submitted by:   obrien
   Approved by:    maintainer (timeout, 10 months)
   
   Revision  Changes    Path
   1.5       +2 -0      ports/sysutils/pwsafe/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: closed->feedback 
State-Changed-By: gahr 
State-Changed-When: Mon Nov 28 18:00:07 UTC 2011 
State-Changed-Why:  
I kindly ask you to revert this change: X11 support is an optional 
feature in pwsafe that allows to copy a password to the X clipboards. 
Forcing a user to install libX11 and companions just to use pwsafe does 
not seem wise to me. I would prefer autodetection or, at least, the use 
of the OPTIONS framework. 

Please take into consideration the patch below: 

--- Makefile.orig       2011-11-28 19:34:31.000000000 +0100 +++ Makefile 
2011-11-28 19:33:47.000000000 +0100 @@ -18,13 +18,16 @@ 

GNU_CONFIGURE= yes USE_GMAKE=     yes 
-USE_XORG=      ice sm x11 xmu 

MAN1=          pwsafe.1 PLIST_FILES=   bin/pwsafe 

.include <bsd.port.pre.mk> 

+.if exists(${LOCALBASE}/lib/libX11.so) +USE_XORG=      ice sm x11 xmu 
+.endif + 
do-install: 
${INSTALL_PROGRAM} ${WRKSRC}/pwsafe ${PREFIX}/bin ${INSTALL_MAN} 
${WRKSRC}/pwsafe.1 ${PREFIX}/man/man1 


http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 

From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To: gahr@FreeBSD.org
Cc: donnex@donnex.net, obrien@freebsd.org, bug-followup@FreeBSD.org
Subject: Re: ports/153198: sysutils/pwsafe does not register all of its
 dependencies
Date: Tue, 29 Nov 2011 02:46:37 +0800

 --W/nzBZO5zC0uMSeA
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 
 Hi,
 
 I've already sent a PR [1] for this issue. I'm waiting for maintainer's approval or timeout.
 
 [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162649
 
 Regards,
 sunpoet
 
 --W/nzBZO5zC0uMSeA
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.18 (FreeBSD)
 
 iQIcBAEBAgAGBQJO09cNAAoJENxEJH7MV+NrU1YQAIFyIChlemYKKf9pyqwSXiH0
 QjKfCg3sOEPNV0Upm567QdRstmm+/h+ZeAPAljm1N04bGQhPI2yCE3OFfeGjwg/R
 dOkMq+TRkuWMUD32+ZiPAg9KLlgl2gOkrISLS3WV9XMnjze1TMCrigb00PCRP+Vu
 EvK5Ygj0oP1ypdS3K1R6tagRSF2T0xR0yM5AfbFOgN8o9VcKuDEESVKTSaDJFJIa
 W9nao35hMVl6LuaxyQ6d2Wzm54Vx9IHvXBouzwhJuenppHVLH31ke4cAgpRpFV+3
 oipofbEoqUHl2I2aHUwHCJ199WVSUnHEPXfPV8QFNWlU3JEydPCiBf8zU0n7YUXZ
 kUUpGLj7i2gV28GvquDdRuFxORLqnWsxSOxTq1TBW+InDlxgLXprE2zVaHnsGJsk
 9PscXQDHLxQxtSiqBgXwy74V/oRUrfGWvd9TFVd4tSc7Kxir+jNDplNwQj3HSbei
 Sk4LAGEUmeUtStMyEI+WOx0jqObUdwtC2JZllp2GhIs19PcaqWVZbi0NnDwJV3pg
 b99AGxJ/n8Vp22tFbh+T0jQ/RqGr9RDZfB0u4m4KO49qoP3IMBGxLFw2WS9fSjD5
 D1IXJi3o35vhcDoEeQimBZmI+Eg4k+ZQGuGyC19QrYVaMqVHD6gtOmC2x3cxO2Pa
 I8c1hhn6djdphfxiC/WT
 =Cihv
 -----END PGP SIGNATURE-----
 
 --W/nzBZO5zC0uMSeA--
State-Changed-From-To: feedback->closed 
State-Changed-By: gahr 
State-Changed-When: Mon Nov 28 19:15:38 UTC 2011 
State-Changed-Why:  
Taken care of in 162649. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153198 
>Unformatted:
