From leres@ee.lbl.gov  Wed Dec 15 18:29:35 2010
Return-Path: <leres@ee.lbl.gov>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 222291065693
	for <bug-followup@FreeBSD.org>; Wed, 15 Dec 2010 18:29:35 +0000 (UTC)
	(envelope-from leres@ee.lbl.gov)
Received: from fun.ee.lbl.gov (fun.ee.lbl.gov [IPv6:2001:400:610:102::ca])
	by mx1.freebsd.org (Postfix) with ESMTP id 0A3718FC0C
	for <bug-followup@FreeBSD.org>; Wed, 15 Dec 2010 18:29:35 +0000 (UTC)
Received: from ice.ee.lbl.gov (ice.ee.lbl.gov [131.243.2.213])
	(authenticated bits=0)
	by fun.ee.lbl.gov (8.14.4/8.14.4) with ESMTP id oBFITYGC036035
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <bug-followup@FreeBSD.org>; Wed, 15 Dec 2010 10:29:34 -0800 (PST)
Message-Id: <4D09090E.4030806@ee.lbl.gov>
Date: Wed, 15 Dec 2010 10:29:34 -0800
From: Craig Leres <leres@ee.lbl.gov>
To: bug-followup@FreeBSD.org
Subject: [PATCH] devel/avr-libc: port is not broken when AVRLIBCDOCS is not
 selected

>Number:         153181
>Category:       ports
>Synopsis:       [PATCH] devel/avr-libc: port is not broken when AVRLIBCDOCS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    joerg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 15 18:30:09 UTC 2010
>Closed-Date:    Wed Dec 15 22:58:04 MET 2010
>Last-Modified:  Wed Dec 15 22:00:20 UTC 2010
>Originator:     Craig Leres
>Release:        FreeBSD 7.2-RELEASE amd64
>Organization:
Lawrence Berkeley National Laboratory
>Environment:
	FreeBSD fun.ee.lbl.gov 7.2-RELEASE FreeBSD 7.2-RELEASE #9 r99: Sat Dec
 4 23:25:23 PST 2010
leres@fun.ee.lbl.gov:/home/fun/u2/src/7.2-RELEASE/sys/amd64/compile/LBLSMPIPV6
 amd64

>Description:
	This port is marked as broken but in fact it builds correctly
	when the documentation option (AVRLIBCDOCS) is not selected.

>How-To-Repeat:
	Comment out the BROKEN line, "make config" and enable
	AVRLIBCDOCS and things go wrong.

	"make config" and disable AVRLIBCDOCS and everything builds.

>Fix:
	Change the default for AVRLIBCDOCS to off; move BROKEN to
	the case when AVRLIBCDOCS is on.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0JCQ4ACgkQWxlAhAje3Jt3nwCeJhQl5bx4pW4KKTz9xVK5qjk0
le8AoI0AGdRHT05+0pnGzrJ/GdrkZ5Sn
=8Wil
-----END PGP SIGNATURE-----

--------------010202050708040408070003
Content-Type: text/plain;
 name="patch-Makefile"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch-Makefile"

--- Makefile.orig	2010-12-15 09:59:04.000000000 -0800
+++ Makefile	2010-12-15 10:26:28.000000000 -0800
@@ -7,6 +7,7 @@
 
 PORTNAME=	avr-libc
 PORTVERSION=	1.7.0
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_SAVANNAH}
@@ -22,10 +23,8 @@
 		avr-ld:${PORTSDIR}/devel/avr-binutils \
 		avr-gcc:${PORTSDIR}/devel/avr-gcc
 
-BROKEN=		does not build
-
 .if !defined(NOPORTDOCS)
-OPTIONS=	AVRLIBCDOCS "Build avr-libc documents" on
+OPTIONS=	AVRLIBCDOCS "Build avr-libc documents" off
 .endif
 
 .include <bsd.port.options.mk>
@@ -33,6 +32,8 @@
 .if defined(WITHOUT_AVRLIBCDOCS) || defined(NOPORTDOCS)
 WITHOUT_AVRLIBCDOCS=	true
 .undef WITH_AVRLIBCDOCS
+.else
+#BROKEN=		does not build with AVRLIBCDOCS enabled
 .endif
 
 .if defined(WITH_AVRLIBCDOCS)

--------------010202050708040408070003
Content-Type: application/octet-stream;
 name="patch-Makefile.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="patch-Makefile.sig"

iEYEABECAAYFAk0JCQ4ACgkQWxlAhAje3JsKbgCfX9OvRWIWPWE+lvZsiXnbf28vvcEAnib9
59H3vadydK63IswcHneGVtaz
--------------010202050708040408070003--
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->joerg 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Dec 15 18:30:17 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153181 

From: Craig Leres <leres@ee.lbl.gov>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/153181: [PATCH] devel/avr-libc: port is not broken when
 AVRLIBCDOCS is not selected
Date: Wed, 15 Dec 2010 10:32:29 -0800

 This is a multi-part message in MIME format.
 --------------090504060909030607030800
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 Oops, there's a typo in the patch; please use the appended version instead.
 
 		Craig
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.11 (FreeBSD)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
 iEYEARECAAYFAk0JCb0ACgkQWxlAhAje3Jt3eQCfd3Xj3Gv8TKRNHT0y2gXES+e3
 z2kAn3i+37bKsO8aWNtm+rNoizLcOMQh
 =8yIN
 -----END PGP SIGNATURE-----
 
 --------------090504060909030607030800
 Content-Type: text/plain;
  name="patch-Makefile"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="patch-Makefile"
 
 --- Makefile.orig	2010-12-15 09:59:04.000000000 -0800
 +++ Makefile	2010-12-15 10:29:53.000000000 -0800
 @@ -7,6 +7,7 @@
  
  PORTNAME=	avr-libc
  PORTVERSION=	1.7.0
 +PORTREVISION=	1
  PORTEPOCH=	1
  CATEGORIES=	devel
  MASTER_SITES=	${MASTER_SITE_SAVANNAH}
 @@ -22,10 +23,8 @@
  		avr-ld:${PORTSDIR}/devel/avr-binutils \
  		avr-gcc:${PORTSDIR}/devel/avr-gcc
  
 -BROKEN=		does not build
 -
  .if !defined(NOPORTDOCS)
 -OPTIONS=	AVRLIBCDOCS "Build avr-libc documents" on
 +OPTIONS=	AVRLIBCDOCS "Build avr-libc documents" off
  .endif
  
  .include <bsd.port.options.mk>
 @@ -33,6 +32,8 @@
  .if defined(WITHOUT_AVRLIBCDOCS) || defined(NOPORTDOCS)
  WITHOUT_AVRLIBCDOCS=	true
  .undef WITH_AVRLIBCDOCS
 +.else
 +BROKEN=		does not build with AVRLIBCDOCS enabled
  .endif
  
  .if defined(WITH_AVRLIBCDOCS)
 
 --------------090504060909030607030800
 Content-Type: application/octet-stream;
  name="patch-Makefile.sig"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="patch-Makefile.sig"
 
 iEYEABECAAYFAk0JCb0ACgkQWxlAhAje3JvmEACaAozVv6yJPhMIpl08/4lmXnRSQIAAn3FH
 H2aJV5VXrTMbLzPzlwMvcNq6
 --------------090504060909030607030800--
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Wed Dec 15 22:57:09 MET 2010 
State-Changed-Why:  
Patch applied as a workaround until the proper upstream fix 
arrives. 

thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153181 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153181: commit references a PR
Date: Wed, 15 Dec 2010 21:56:38 +0000 (UTC)

 joerg       2010-12-15 21:56:33 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/avr-libc       Makefile 
   Log:
   As a workaround for the brokeness caused by the recent doxygen
   upgrade, change the AVRLIBCDOCS option default to "off", and mark the
   port as being BROKEN only if docs are requested, so it will be non
   broken by default.
   
   This can go away again with an upcoming new upstream release that
   implements a proper workaround, but it's a useful workaround until
   then.
   
   PR:             ports/153181
   Submitted by:   Craig Leres
   
   Revision  Changes    Path
   1.77      +4 -3      ports/devel/avr-libc/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
 This is a multi-part message in MIME format.
 --------------010202050708040408070003
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 is not selected
