From nobody@FreeBSD.org  Sat Dec 11 23:42:50 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A8C06106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 Dec 2010 23:42:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 97C448FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 Dec 2010 23:42:50 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oBBNgo4X082309
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 11 Dec 2010 23:42:50 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id oBBNgo27082308;
	Sat, 11 Dec 2010 23:42:50 GMT
	(envelope-from nobody)
Message-Id: <201012112342.oBBNgo27082308@red.freebsd.org>
Date: Sat, 11 Dec 2010 23:42:50 GMT
From: Steve Price <steve@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: un-escaped shell metacharacters in bsd.port.subdir.mk
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         153033
>Category:       ports
>Synopsis:       un-escaped shell metacharacters in bsd.port.subdir.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    erwin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 11 23:50:09 UTC 2010
>Closed-Date:    Mon Dec 20 12:24:09 UTC 2010
>Last-Modified:  Mon Dec 20 12:30:11 UTC 2010
>Originator:     Steve Price
>Release:        8.1-RELEASE
>Organization:
>Environment:
FreeBSD host14.warningsystems.com 8.1-RELEASE FreeBSD 8.1-RELEASE #2: Fri Aug 13 11:14:49 CDT 2010     steve@host14.warningsystems.com:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
There's an issue in bsd.port.subdir.mk where un-escaped shell
metacharacters are causing the build of the automake14 port to
fail.
>How-To-Repeat:
Create the following Makefile and 'make all'.

---8<---
#USE_JAVA=yes

all clean:
        cd /usr/ports/devel/automake14 && make $@

foobar:
        @echo "_JAVA_VERSION_LIST_REGEXP=${_JAVA_VERSION_LIST_REGEXP}"
        @echo "_JAVA_VENDOR_LIST_REGEXP=${_JAVA_VENDOR_LIST_REGEXP}"
        @echo "_JAVA_OS_LIST_REGEXP=${_JAVA_OS_LIST_REGEXP}"

.if defined(USE_JAVA)
.include <bsd.port.mk>
.else
.include <bsd.port.subdir.mk>
.endif
----8<---
>Fix:
--- bsd.port.subdir.mk.orig	2010-12-11 15:36:38.000000000 -0600
+++ bsd.port.subdir.mk	2010-12-11 15:34:12.000000000 -0600
@@ -377,9 +377,9 @@
 	PYTHON_DEFAULT_VERSION="${PYTHON_DEFAULT_VERSION}" \
 	PYTHON_DEFAULT_PORTVERSION="${PYTHON_DEFAULT_PORTVERSION}" \
 	PYTHONBASE="${PYTHONBASE}" \
-	_JAVA_VERSION_LIST_REGEXP="${_JAVA_VERSION_LIST_REGEXP}" \
-	_JAVA_VENDOR_LIST_REGEXP="${_JAVA_VENDOR_LIST_REGEXP}" \
-	_JAVA_OS_LIST_REGEXP="${_JAVA_OS_LIST_REGEXP}" \
+	_JAVA_VERSION_LIST_REGEXP="${_JAVA_VERSION_LIST_REGEXP:Q}" \
+	_JAVA_VENDOR_LIST_REGEXP="${_JAVA_VENDOR_LIST_REGEXP:Q}" \
+	_JAVA_OS_LIST_REGEXP="${_JAVA_OS_LIST_REGEXP:Q}" \
 	_JAVA_PORTS_INSTALLED="${_JAVA_PORTS_INSTALLED}"
 .endif


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Dec 11 23:50:15 UTC 2010 
Responsible-Changed-Why:  
bsd.port.subdir.mk is portmgr territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153033 
Responsible-Changed-From-To: portmgr->erwin 
Responsible-Changed-By: erwin 
Responsible-Changed-When: Fri Dec 17 11:40:49 UTC 2010 
Responsible-Changed-Why:  
Take for -exp run. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153033 
State-Changed-From-To: open->closed 
State-Changed-By: erwin 
State-Changed-When: Mon Dec 20 12:24:02 UTC 2010 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153033 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153033: commit references a PR
Date: Mon, 20 Dec 2010 12:23:58 +0000 (UTC)

 erwin       2010-12-20 12:23:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.port.subdir.mk 
   Log:
   Properly escape shell metacharacters in some JAVA_* macros.
   
   PR:             153033
   Submitted by:   steve
   
   Revision  Changes    Path
   1.77      +4 -4      ports/Mk/bsd.port.subdir.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
