From jhs@berklix.com  Fri Dec 10 18:21:08 2010
Return-Path: <jhs@berklix.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AF469106566B;
	Fri, 10 Dec 2010 18:21:08 +0000 (UTC)
	(envelope-from jhs@berklix.com)
Received: from tower.berklix.org (tower.berklix.org [83.236.223.114])
	by mx1.freebsd.org (Postfix) with ESMTP id D32EE8FC25;
	Fri, 10 Dec 2010 18:21:07 +0000 (UTC)
Received: from park.js.berklix.net (p5B22F250.dip.t-dialin.net [91.34.242.80])
	(authenticated bits=0)
	by tower.berklix.org (8.14.2/8.14.2) with ESMTP id oBAHusSb088090;
	Fri, 10 Dec 2010 17:56:56 GMT
	(envelope-from jhs@berklix.com)
Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41])
	by park.js.berklix.net (8.13.8/8.13.8) with ESMTP id oBAHwEHS095607;
	Fri, 10 Dec 2010 18:58:14 +0100 (CET)
	(envelope-from jhs@berklix.com)
Received: from fire.js.berklix.net (localhost [127.0.0.1])
	by fire.js.berklix.net (8.14.3/8.14.3) with ESMTP id oBAHw4FP017889;
	Fri, 10 Dec 2010 18:58:09 +0100 (CET)
	(envelope-from jhs@fire.js.berklix.net)
Received: (from jhs@localhost)
	by fire.js.berklix.net (8.14.3/8.14.3/Submit) id oBAHvs1n017832;
	Fri, 10 Dec 2010 18:57:54 +0100 (CET)
	(envelope-from jhs)
Message-Id: <201012101757.oBAHvs1n017832@fire.js.berklix.net>
Date: Fri, 10 Dec 2010 18:57:54 +0100 (CET)
From: "Julian H. Stacey" <jhs@berklix.com>
Reply-To: "Julian H. Stacey" <jhs@berklix.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: matusita@freebsd.org, "Julian H. Stacey" <jhs@berklix.com>
Subject: 2 ports hang on fetch, IS_INTERACTIVE is wrongly ifdefd
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         153001
>Category:       ports
>Synopsis:       emulators/vmware-guestd5, vmware-guestd6 hang on fetch, IS_INTERACTIVE is wrongly ifdefd
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    matusita
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 10 19:06:13 UTC 2010
>Closed-Date:    Wed Dec 15 12:42:56 UTC 2010
>Last-Modified:  Wed Dec 15 12:50:08 UTC 2010
>Originator:     Julian H. Stacey <jhs@berklix.com>
>Release:        FreeBSD 8.0-RELEASE amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD fire.js.berklix.net 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Mon Jul 12 00:59:43 CEST 2010 jhs@fire.js.berklix.net:/usr1/src/sys/amd64/compile/FIRE64.small amd64


	
>Description:
	
/usr/ports/emulators/
	vmware-guestd5  
	vmware-guestd6 
hang on 
	make fetch BATCH=YES
because 
	IS_INTERACTIVE
is wrongly protected by preceeding ifdef

>How-To-Repeat:
	
	cd /usr/ports/emulators/
		vmware-guestd5
        	vmware-guestd6
	make fetch BATCH=YES


>Fix:

	
Apply patches appended, from what will be in 
	http://berklix.com/~jhs/src/bsd/fixes/freebsd/ports/gen/emulators/vmware-guestd5/Makefile.REL=8.1_RELEASE.diff
	http://berklix.com/~jhs/src/bsd/fixes/freebsd/ports/gen/emulators/vmware-guestd6/Makefile.REL=8.1_RELEASE.diff

PS Yes the ## lines dont need to exist at all.
----------
*** old/ports/emulators/vmware-guestd5/Makefile	Fri Dec 10 17:48:26 2010
--- new-generic-8.1-RELEASE/ports/emulators/vmware-guestd5/Makefile	Fri Dec 10 17:54:18 2010
*** Makefile.orig	Fri Dec 10 17:48:26 2010
--- Makefile	Fri Dec 10 18:41:25 2010
***************
*** 27,35 ****
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! .endif
  .if defined(VMWARE_X_PORTS)
  USE_XORG=	x11
  NO_BUILD=	yes
--- 27,35 ----
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! ## .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! ## .endif
  .if defined(VMWARE_X_PORTS)
  USE_XORG=	x11
  NO_BUILD=	yes
----------
*** old/ports/emulators/vmware-guestd6/Makefile	Fri Dec 10 17:48:32 2010
--- new-generic-8.1-RELEASE/ports/emulators/vmware-guestd6/Makefile	Fri Dec 10 17:54:16 2010
***************
*** 25,33 ****
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! .endif
  
  RESTRICTED=	"Not sure if we can redistribute this."
  NO_PACKAGE=	${RESTRICTED}
--- 25,33 ----
  WRKSRC=		${WRKDIR}/vmware-tools-distrib
  
  ONLY_FOR_ARCHS=	i386 amd64
! ## .if !defined(BATCH)
  IS_INTERACTIVE=	yes
! ## .endif
  
  RESTRICTED=	"Not sure if we can redistribute this."
  NO_PACKAGE=	${RESTRICTED}
----------
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Sat Dec 11 00:06:19 UTC 2010 
Responsible-Changed-Why:  
I will take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153001 
Responsible-Changed-From-To: pgollucci->matusita 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Sun Dec 12 01:13:19 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153001 
State-Changed-From-To: open->closed 
State-Changed-By: matusita 
State-Changed-When: Wed Dec 15 12:42:33 UTC 2010 
State-Changed-Why:  
Committed as submitted. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153001 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/153001: commit references a PR
Date: Wed, 15 Dec 2010 12:42:20 +0000 (UTC)

 matusita    2010-12-15 12:42:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/vmware-guestd5 Makefile 
     emulators/vmware-guestd6 Makefile 
   Log:
   Remove unneeded ifdefs.
   
   PR:             153001
   Submitted by:   Julian H. Stacey <jhs at berklix dotcom>
   
   Revision  Changes    Path
   1.45      +0 -2      ports/emulators/vmware-guestd5/Makefile
   1.58      +0 -2      ports/emulators/vmware-guestd6/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
