From ohauer@FreeBSD.org  Sun Nov 28 00:19:37 2010
Return-Path: <ohauer@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA1001065670;
	Sun, 28 Nov 2010 00:19:37 +0000 (UTC)
	(envelope-from ohauer@FreeBSD.org)
Received: from u18-124.dslaccess.de (unknown [194.231.39.124])
	by mx1.freebsd.org (Postfix) with ESMTP id 8FA5C8FC0C;
	Sun, 28 Nov 2010 00:19:37 +0000 (UTC)
Received: by u18-124.dslaccess.de (Postfix, from userid 1100)
	id BF67320502; Sun, 28 Nov 2010 01:19:34 +0100 (CET)
Message-Id: <20101128001934.BF67320502@u18-124.dslaccess.de>
Date: Sun, 28 Nov 2010 01:19:34 +0100 (CET)
From: Olli Hauer <ohauer@FreeBSD.org>
To: <FreeBSD-gnats-submit@freebsd.org>
Cc: <ohauer@FreeBSD.org>
Subject: Mk/bsd.port.mk since rev 1.656 pkg-message is no longer displayed if installed from package
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         152626
>Category:       ports
>Synopsis:       MK/bsd.port.mk since rev 1.656 pkg-message is no longer displayed if installed from package
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 28 00:20:11 UTC 2010
>Closed-Date:    Tue Nov 30 21:36:50 UTC 2010
>Last-Modified:  Tue Nov 30 21:40:13 UTC 2010
>Originator:     Olli Hauer <ohauer@FreeBSD.org>
>Release:        
>Organization:
>Environment:


>Description:
Since rev 1.656 the pkg-message will no longer displayed
during package install.

>How-To-Repeat:
Build a package that displays a pkg-message, deinstall
and then install the fresh created package.

Revert to bsd.port.mk rev 1.655 do the same procedure
the message will be displaed again during package install.

>Fix:

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Nov 28 00:20:18 UTC 2010 
Responsible-Changed-Why:  
bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152626 

From: Pav Lucistnik <pav@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/152626: MK/bsd.port.mk since rev 1.656 pkg-message is no
 longer displayed if installed from package
Date: Sun, 28 Nov 2010 16:11:44 +0100

 Can you try out this "hack" to see if it works for you and have no ill
 side-effects?
 
 Index: bsd.port.mk
 ===================================================================
 RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
 retrieving revision 1.657
 diff -a -u -r1.657 bsd.port.mk
 --- bsd.port.mk	27 Nov 2010 17:42:46 -0000	1.657
 +++ bsd.port.mk	28 Nov 2010 15:09:51 -0000
 @@ -5931,6 +5931,7 @@
  		fi; \
  		if [ -f ${PKGMESSAGE} ]; then \
  			${CP} ${PKGMESSAGE} ${PKG_DBDIR}/${PKGNAME}/+DISPLAY; \
 +			${ECHO_CMD} "@display +DISPLAY" >> ${PKG_DBDIR}/${PKGNAME}/+CONTENTS; \
  		fi; \
  		for dep in `${PKG_INFO} -qf ${PKGNAME} | ${AWK} '/^@pkgdep / {print $$2}' | ${SORT} -u`; do \
  			if [ -d ${PKG_DBDIR}/$$dep -a -z `${ECHO_CMD} $$dep | ${GREP} -E ${PKG_IGNORE_DEPENDS}` ]; then \
 
 -- 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 As I understand it the M25 marks the border between culture and
 agriculture.
 

From: Dominic Fandrey <kamikaze@bsdforen.de>
To: bug-followup@FreeBSD.org, ohauer@FreeBSD.org
Cc:  
Subject: Re: ports/152626: MK/bsd.port.mk since rev 1.656 pkg-message is no
 longer displayed if installed from package
Date: Sun, 28 Nov 2010 17:55:02 +0100

 I can reproduce this using only pkg_create -b and pkg_add.
 
 The created package contains the message in the file +DISPLAY,
 but pkg_add does not display it. It seems reasonable to me the
 @display entry should be created with the /var/db/pkg entry, so
 I actually consider the /hack/ a clean solution.
 
 After all the fake-pkg: target is to my knowledge the single point
 of creation for /var/db/pkg entries. The original way of handling
 this in the package: target seems less clean to me.
 
 Regards,
 Dominic

From: Dominic Fandrey <kamikaze@bsdforen.de>
To: bug-followup@FreeBSD.org, ohauer@FreeBSD.org
Cc:  
Subject: Re: ports/152626: MK/bsd.port.mk since rev 1.656 pkg-message is no
 longer displayed if installed from package
Date: Sun, 28 Nov 2010 18:05:41 +0100

 Just tested the patch, works for me!
 
 I feel kinda guilty for not recognizing the problem. I'd been
 using the patch in ports/144164 for a /very/ long time without
 recognizing this.
 
 The NO_INSTALL issue only affected 5 ports, cups being the
 only popular one (and I don't use cups), but I consider this
 issue more serious.
 
 Regards,
 Dominic

From: olli hauer <ohauer@gmx.de>
To: bug-followup@FreeBSD.org, ohauer@FreeBSD.org
Cc:  
Subject: Re: ports/152626: MK/bsd.port.mk since rev 1.656 pkg-message is no
 longer displayed if installed from package
Date: Sun, 28 Nov 2010 21:11:32 +0100

 > I feel kinda guilty for not recognizing the problem. I'd been
 > using the patch in ports/144164 for a /very/ long time without
 > recognizing this.
 
 Sometimes also the generated package should be tested ;)
 
 The fix works for me.
 
 Thanks!

From: Olli Hauer <ohauer@FreeBSD.org>
To: Dominic Fandrey <kamikaze@bsdforen.de>
Cc: bug-followup@FreeBSD.org, ohauer@FreeBSD.org
Subject: Re: ports/152626: MK/bsd.port.mk since rev 1.656 pkg-message is no
 longer displayed if installed from package
Date: Sun, 28 Nov 2010 21:39:38 +0100

 > Just tested the patch, works for me!
 > 
 > I feel kinda guilty for not recognizing the problem. I'd been
 > using the patch in ports/144164 for a /very/ long time without
 > recognizing this.
 > 
 
 Sometimes also the generated package should be tested ;)
 
 The patch works for me, thanks!
Responsible-Changed-From-To: portmgr->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Mon Nov 29 08:48:14 UTC 2010 
Responsible-Changed-Why:  
Take for exp-run 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152626 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Tue Nov 30 21:36:00 UTC 2010 
State-Changed-Why:  
Patch committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152626 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/152626: commit references a PR
Date: Tue, 30 Nov 2010 21:36:47 +0000 (UTC)

 pav         2010-11-30 21:36:42 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.port.mk 
   Log:
   - Add a hack to display pkg-message on package install on packages created with
     pkg_create -b
   
   PR:             ports/152626
   Reported by:    ohauer
   
   Revision  Changes    Path
   1.658     +2 -1      ports/Mk/bsd.port.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
