From nobody@yellow.freebsd.org  Thu Nov 25 13:17:27 2010
Return-Path: <nobody@yellow.freebsd.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 30DF01065670
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Nov 2010 13:17:27 +0000 (UTC)
	(envelope-from nobody@yellow.freebsd.org)
Received: from www.freebsd.org (unknown [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FBA28FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Nov 2010 13:17:27 +0000 (UTC)
Received: from yellow.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oAPDHQeU090770
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Nov 2010 13:17:26 GMT
	(envelope-from nobody@yellow.freebsd.org)
Received: (from nobody@localhost)
	by yellow.freebsd.org (8.14.3/8.14.3/Submit) id oAPDHQW9090769;
	Thu, 25 Nov 2010 13:17:26 GMT
	(envelope-from nobody)
Message-Id: <201011251317.oAPDHQW9090769@yellow.freebsd.org>
Date: Thu, 25 Nov 2010 13:17:26 GMT
From: Oliver Heesakkers <dev2@heesakkers.info>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ftp/pure-ftpd requires HAVE_TIMEGM
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         152573
>Category:       ports
>Synopsis:       ftp/pure-ftpd requires HAVE_TIMEGM
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    garga
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 25 13:20:10 UTC 2010
>Closed-Date:    Thu Dec 30 15:54:27 UTC 2010
>Last-Modified:  Thu Dec 30 15:54:27 UTC 2010
>Originator:     Oliver Heesakkers
>Release:        7.3 amd64
>Organization:
>Environment:
FreeBSD 7.3-RELEASE-p2 FreeBSD 7.3-RELEASE-p2 #0: Wed Jul 14 00:16:06 CEST 2010   /usr/obj/usr/src/sys/vps7  amd64
>Description:
After a bug [1] got fixed upstream the patch mentioned in that pr was removed from files. The upstream fix however depends on setting the variable HAVE_TIMEGM which is not done by default or available as a port configuration option. Without passing that variable my times are of by one hour (Western Europe).

[1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131645
>How-To-Repeat:
- Install and run pure-ftpd
- Upload something with a client that uses SITE UTIME (I used Dolphin for testing, but seen it with multiple other clients
- Observe the time in the log
>Fix:
Pass HAVE_TIMEGM=1 while building pure-ftpd

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->garga 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Nov 25 13:20:15 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152573 
State-Changed-From-To: open->feedback 
State-Changed-By: garga 
State-Changed-When: Mon Dec 27 10:48:48 UTC 2010 
State-Changed-Why:  
Waiting submitter feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152573 

From: Renato Botelho <garga@FreeBSD.org>
To: bug-followup@FreeBSD.org, dev2@heesakkers.info
Cc:  
Subject: Re: ports/152573: ftp/pure-ftpd requires HAVE_TIMEGM
Date: Mon, 27 Dec 2010 08:48:14 -0200

 Hello,
 
 Sorry for long delay to answer, but, after some tests here, it seems to
 be a local problem you are having. Pure-ftpd uses a common autotools
 structure and have a configure script and a config.h.in file, when you
 run ./configure it creates config.h and it already have a #define
 HAVE_TIMEGM 1 inside this file (at least on 2 boxes i tested).
 
 Could you please run 'make configure' on pure-ftpd and take a look at
 config.log to try to identify why it's not defining HAVE_TIMEGM on your
 system?
 
 Thanks
 -- 
 Renato Botelho <garga     @ FreeBSD.org>
                <garga.bsd @ gmail.com>
 GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
 
 Lend money to a bad debtor and he will hate you.

From: Oliver Heesakkers <dev2@heesakkers.info>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/152573: ftp/pure-ftpd requires HAVE_TIMEGM
Date: Thu, 30 Dec 2010 16:43:19 +0100

 Hi,
 
 It looks like I jumped the gun on this one. HAVE_TIMEGM does show up in
 the configuration as expected and all new builds (with or without
 HAVE_TIMEGM) function correctly. I could have sworn I tested a fresh
 build before submitting the PR, but apparently I did not...
 
 Studying the logs I'm now fairly certain the problem arose with the
 pure-ftpd build in summertime, operating in wintertime. I no longer
 have the package that was build in summertime as it was automatically
 replaced with my november 25 rebuild, so as far as I'm concerned this
 PR can be closed and I'll keep an eye on this when summertime comes
 back.
 
 Thank you for your time!
 
 	Oliver
State-Changed-From-To: feedback->closed 
State-Changed-By: garga 
State-Changed-When: Thu Dec 30 15:54:26 UTC 2010 
State-Changed-Why:  
Closed by submitter request 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152573 
>Unformatted:
