From nobody@FreeBSD.org  Wed Nov 24 07:34:14 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CE9AD106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Nov 2010 07:34:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id BD9E58FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Nov 2010 07:34:14 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oAO7YE0a048568
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Nov 2010 07:34:14 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id oAO7YEcp048567;
	Wed, 24 Nov 2010 07:34:14 GMT
	(envelope-from nobody)
Message-Id: <201011240734.oAO7YEcp048567@red.freebsd.org>
Date: Wed, 24 Nov 2010 07:34:14 GMT
From: Lukasz Wasikowski <lukasz@wasikowski.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [regression] www/phpbb3: Port upgrade deletes config
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: appleboy.tw@gmail.com

>Number:         152535
>Category:       ports
>Synopsis:       [regression] www/phpbb3: Port upgrade deletes config
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beech
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 24 07:40:09 UTC 2010
>Closed-Date:    Tue Nov 30 21:55:08 UTC 2010
>Last-Modified:  Tue Nov 30 22:00:22 UTC 2010
>Originator:     Lukasz Wasikowski
>Release:        FreeBSD 8.1
>Organization:
>Environment:
FreeBSD bijou.wasikowski.net 8.1-RELEASE-p1 FreeBSD 8.1-RELEASE-p1 #0: Tue Sep 21 14:05:53 CEST 2010     root@bijou.wasikowski.net:/usr/obj/usr/src/sys/bijou  i386
>Description:
config.php is in pkg-plist, so it's deleted after application upgrade. This was introduced with phpBB3 3.0.6, with 3.0.5 it worked as it should.
>How-To-Repeat:
cd /usr/ports/www/phpbb3 && make install clean && echo '<?php // test ?>' > /usr/local/www/phpBB3/config.php && portupgrade -f phpbb && cat /usr/local/www/phpBB3/config.php
>Fix:
Patch attached.

Patch attached with submission follows:

diff -ruN phpbb3.bak/pkg-plist phpbb3/pkg-plist
--- phpbb3.bak/pkg-plist	2010-11-23 10:43:37.000000000 +0100
+++ phpbb3/pkg-plist	2010-11-24 08:24:52.000000000 +0100
@@ -128,7 +128,6 @@
 %%PHPBBDIR%%/cache/.htaccess
 %%PHPBBDIR%%/cache/index.htm
 %%PHPBBDIR%%/common.php
-%%PHPBBDIR%%/config.php
 %%PHPBBDIR%%/cron.php
 %%PHPBBDIR%%/docs/AUTHORS
 %%PHPBBDIR%%/docs/CHANGELOG.html
@@ -962,6 +961,8 @@
 %%PHPBBDIR%%/viewonline.php
 %%PHPBBDIR%%/viewtopic.php
 %%PHPBBDIR%%/web.config
+@exec [ -f %D/%%PHPBBDIR%%/config.php ] || touch %D/%%PHPBBDIR%%/config.php
+@unexec [ -s %D/%%PHPBBDIR%%/config.php ] || rm -f %D/%%PHPBBDIR%%/config.php
 @dirrm %%PHPBBDIR%%/styles/subsilver2/theme/images
 @dirrm %%PHPBBDIR%%/styles/subsilver2/theme
 @dirrm %%PHPBBDIR%%/styles/subsilver2/template


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Nov 24 07:40:14 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152535 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: appleboy.tw@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/152535: [regression] www/phpbb3: Port upgrade deletes config
Date: Wed, 24 Nov 2010 07:40:13 UT

 Maintainer of www/phpbb3,
 
 Please note that PR ports/152535 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152535
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Bo-Yi Wu <appleboy.tw@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/152535: [regression] www/phpbb3: Port upgrade deletes config
Date: Wed, 24 Nov 2010 16:02:13 +0800

 --00163646da746e05880495c7e9b9
 Content-Type: text/plain; charset=ISO-8859-1
 
 ok, please commit it.
 
 Thanks.
 
 Bo-Yi Wu
 
 --00163646da746e05880495c7e9b9
 Content-Type: text/html; charset=ISO-8859-1
 
 ok, please commit it.
 <div><br></div><div>Thanks.</div><div><br></div><div>Bo-Yi Wu</div>
 
 --00163646da746e05880495c7e9b9--

From: Bo-Yi Wu <appleboy.tw@gmail.com>
To: bug-followup@freebsd.org, FreeBSD-gnats-submit@freebsd.org
Cc: lukasz@wasikowski.net
Subject: Re: ports/152535: [regression] www/phpbb3: Port upgrade deletes config
Date: Sat, 27 Nov 2010 21:33:43 +0800

 The patch has been approved. Thanks.
 
 On Wed, Nov 24, 2010 at 3:40 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
 > Maintainer of www/phpbb3,
 >
 > Please note that PR ports/152535 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/152535
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 
 
 --=20
 # Name: Bo-Yi Wu
 # Nick name:appleboy
 # M.S National Chung Cheng University Electric Engineering
 # Resume: http://blog.wu-boy.com/about/

From: Bo-Yi Wu <appleboy.tw@gmail.com>
To: bug-followup@freebsd.org, FreeBSD-gnats-submit@freebsd.org
Cc: lukasz@wasikowski.net
Subject: Re: ports/152535: [regression] www/phpbb3: Port upgrade deletes config
Date: Sat, 27 Nov 2010 21:33:43 +0800

 The patch has been approved. Thanks.
 
 --=20
 # Name: Bo-Yi Wu
 # Nick name:appleboy
 # M.S National Chung Cheng University Electric Engineering
 # Resume: http://blog.wu-boy.com/about/
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Sat Nov 27 21:35:40 UTC 2010 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152535 
Responsible-Changed-From-To: freebsd-ports-bugs->beech 
Responsible-Changed-By: beech 
Responsible-Changed-When: Sun Nov 28 23:27:43 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152535 
State-Changed-From-To: open->closed 
State-Changed-By: beech 
State-Changed-When: Tue Nov 30 21:54:55 UTC 2010 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152535 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/152535: commit references a PR
Date: Tue, 30 Nov 2010 21:54:43 +0000 (UTC)

 beech       2010-11-30 21:54:38 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/phpbb3           pkg-plist 
   Log:
   Fix issue - port upgrade deletes config
   
   PR:             ports/152535
   Submitted by:   Lukasz Wasikowski (lukasz@wasikowski.net)
   Approved by:    Bo-Yi Wu (appleboy.tw@gmail.com) (maintainer)
                   itetcu (implicit)
   
   Revision  Changes    Path
   1.14      +2 -1      ports/www/phpbb3/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
