From nobody@FreeBSD.org  Thu Nov 18 19:15:54 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4AEDA1065673
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Nov 2010 19:15:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C5298FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Nov 2010 19:15:54 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oAIJFrLg074179
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Nov 2010 19:15:54 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id oAIJFrgN074178;
	Thu, 18 Nov 2010 19:15:53 GMT
	(envelope-from nobody)
Message-Id: <201011181915.oAIJFrgN074178@www.freebsd.org>
Date: Thu, 18 Nov 2010 19:15:53 GMT
From: Vitaly Magerya <vmagerya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] lang/qscheme: add a missing dependency and hopefully unbreak
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: erik@smluc.org

>Number:         152375
>Category:       ports
>Synopsis:       [patch] lang/qscheme: add a missing dependency and hopefully unbreak
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 18 19:20:05 UTC 2010
>Closed-Date:    Sun Dec 19 15:10:28 UTC 2010
>Last-Modified:  Sun Dec 19 15:20:07 UTC 2010
>Originator:     Vitaly Magerya
>Release:        FreeBSD 8.1-RELEASE i386
>Organization:
>Environment:
>Description:
QScheme uses some Perl scripts during build, but there's no Perl
dependency. It seems that the build errors at portsmon [1] are
caused by this.

The attached patch adds a build dependency on Perl, removes the
BROKEN line and the MD5 checksum while we're at it.

[1] http://portsmon.freebsd.org/portoverview.py?category=lang&portname=qscheme
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN qscheme.orig/Makefile qscheme/Makefile
--- qscheme.orig/Makefile	2010-11-18 20:44:22.000000000 +0200
+++ qscheme/Makefile	2010-11-18 20:47:06.000000000 +0200
@@ -19,12 +19,12 @@
 		${LOCALBASE}/lib/libgmp.a:${PORTSDIR}/math/gmp
 LIB_DEPENDS=	getline:${PORTSDIR}/devel/libgetline
 
+USE_PERL5_BUILD=yes
+
 GNU_CONFIGURE=	yes
 USE_GMAKE=	yes
 PLIST_SUB+=	PORTVERSION="${PORTVERSION}"
 
-BROKEN=		fails to build
-
 CONFIGURE_ARGS=	--with-pcre-dir=${LOCALBASE}/lib \
 		--with-pcre-inc=${LOCALBASE}/include \
 		--with-avcall-dir=${LOCALBASE}/lib \
diff -ruN qscheme.orig/distinfo qscheme/distinfo
--- qscheme.orig/distinfo	2010-11-18 20:44:22.000000000 +0200
+++ qscheme/distinfo	2010-11-18 20:47:09.000000000 +0200
@@ -1,3 +1,2 @@
-MD5 (qscheme-0.5.1.tar.gz) = 9bb70c527033b04a86320f39d16802fe
 SHA256 (qscheme-0.5.1.tar.gz) = 6d9f9574965af21b3c63c7b46caefcf4e06aa6fbbb02e5e5faf42f54851f1752
 SIZE (qscheme-0.5.1.tar.gz) = 523516


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Nov 18 19:20:12 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152375 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: erik@smluc.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/152375: [patch] lang/qscheme: add a missing dependency and hopefully unbreak
Date: Thu, 18 Nov 2010 19:20:10 UT

 Maintainer of lang/qscheme,
 
 Please note that PR ports/152375 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152375
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Erik Greenwald <erik@bz.bzflag.bz>
To: bug-followup@FreeBSD.org
Cc: vmagerya@gmail.com
Subject: Re: ports/152375: [patch] lang/qscheme: add a missing dependency
 and hopefully unbreak
Date: Thu, 2 Dec 2010 15:35:32 -0500 (EST)

 Looks good to me, thanks!
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Mon Dec 6 18:04:37 UTC 2010 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152375 
State-Changed-From-To: open->closed 
State-Changed-By: makc 
State-Changed-When: Sun Dec 19 15:10:27 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152375 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/152375: commit references a PR
Date: Sun, 19 Dec 2010 15:10:25 +0000 (UTC)

 makc        2010-12-19 15:10:19 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/qscheme         Makefile distinfo 
   Log:
   Unbreak by adding build dependency on perl
   
   PR:             ports/152375
   Submitted by:   Vitaly Magerya <vmagerya at gmail.com>
   Approved by:    Erik Greenwald (maintainer)
   
   Revision  Changes    Path
   1.27      +1 -2      ports/lang/qscheme/Makefile
   1.4       +0 -1      ports/lang/qscheme/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
