From nobody@FreeBSD.org  Mon Oct 25 17:01:26 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 055BE106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Oct 2010 17:01:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id E7ADE8FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Oct 2010 17:01:25 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o9PH1PB8045398
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Oct 2010 17:01:25 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o9PH1PnL045397;
	Mon, 25 Oct 2010 17:01:25 GMT
	(envelope-from nobody)
Message-Id: <201010251701.o9PH1PnL045397@www.freebsd.org>
Date: Mon, 25 Oct 2010 17:01:25 GMT
From: Arseny Nasokin <eirnym@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Lack of NLS option in devel/gmake 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         151719
>Category:       ports
>Synopsis:       [PATCH] Lack of NLS option in devel/gmake
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    autotools
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 25 17:10:07 UTC 2010
>Closed-Date:    Wed Mar 02 22:56:27 UTC 2011
>Last-Modified:  Wed Mar 02 22:56:27 UTC 2011
>Originator:     Arseny Nasokin
>Release:        FreeBSD-CURRENT
>Organization:
>Environment:
# New ports collection makefile for:	GNU make
# Date created:		11 September 1994
# Whom:			jkh
#
# $FreeBSD: ports/devel/gmake/Makefile,v 1.68 2010/05/31 01:58:12 ade Exp $
>Description:
devel/gmake port will depend on devel/gettext if you don't explicitly specify WITHOUT_NLS make option.
>How-To-Repeat:
update ports tree, go to devel/gmake to build gmake and type
#make config
no options to configure
#grep WITHOUT_NLS Makefile
.if !defined(WITHOUT_NLS)
>Fix:
patch attached

Patch attached with submission follows:

--- Makefile.orig	2010-10-25 18:39:42.986958118 +0400
+++ Makefile	2010-10-25 18:44:29.141969160 +0400
@@ -19,9 +19,12 @@
 MAINTAINER=	autotools@FreeBSD.org
 COMMENT=	GNU version of 'make' utility
 
+OPTIONS = NLS "Native Language Support" on
+.include<bsd.port.options.mk>
 USE_BZIP2=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS+=--program-prefix=g
+
 .if !defined(WITHOUT_NLS)
 USE_GETTEXT=	yes
 CONFIGURE_ARGS+=--with-libiconv-prefix=${LOCALBASE} \
@@ -39,7 +42,7 @@
 .ifdef USE_GMAKE
 .error You have `USE_GMAKE' variable defined either in environment or in make(1) arguments. Please undefine and try again.
 .endif
-
+.include <bsd.port.pre.mk>
 post-patch:
 	@${RM} ${WRKSRC}/doc/make.info*
 
@@ -49,4 +52,4 @@
 	@${CHMOD} g-s ${PREFIX}/bin/gmake
 	@chgrp ${BINGRP} ${PREFIX}/bin/gmake
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->autotools 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Oct 25 17:10:12 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151719 

From: Eir Nym <eirnym@gmail.com>
To: bug-followup@freebsd.org, eirnym@gmail.com
Cc:  
Subject: Re: ports/151719: [PATCH] Lack of NLS option in devel/gmake
Date: Thu, 16 Dec 2010 22:22:34 +0300

 Are any news about?
State-Changed-From-To: open->closed 
State-Changed-By: ade 
State-Changed-When: Wed Mar 2 22:54:14 UTC 2011 
State-Changed-Why:  
The code is in there.  Not being a fan of the options framework as it 
stands, I see no reason to create an option for this at the present time. 

If you don't want NLS for whatever reason, just put WITHOUT_NLS=YES in 
/etc/make.conf and be done with it - that will catch everything, whether 
it uses options or not. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151719 
>Unformatted:
