From mad@madpilot.net  Fri Oct 15 10:41:42 2010
Return-Path: <mad@madpilot.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8989A106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Oct 2010 10:41:42 +0000 (UTC)
	(envelope-from mad@madpilot.net)
Received: from megatron.madpilot.net (megatron.madpilot.net [88.149.173.206])
	by mx1.freebsd.org (Postfix) with ESMTP id E4D2C8FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Oct 2010 10:41:40 +0000 (UTC)
Received: from megatron.madpilot.net (localhost [127.0.0.1])
	by megatron.madpilot.net (Postfix) with ESMTP id 5C77215CF
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Oct 2010 12:41:39 +0200 (CEST)
Received: from megatron.madpilot.net ([127.0.0.1])
	by megatron.madpilot.net (megatron.madpilot.net [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id 303OQijkcw9d for <FreeBSD-gnats-submit@freebsd.org>;
	Fri, 15 Oct 2010 12:41:31 +0200 (CEST)
Received: by megatron.madpilot.net (Postfix, from userid 1000)
	id D24BA15C7; Fri, 15 Oct 2010 12:41:31 +0200 (CEST)
Message-Id: <20101015104131.D24BA15C7@megatron.madpilot.net>
Date: Fri, 15 Oct 2010 12:41:31 +0200 (CEST)
From: Guido Falsi <mad@madpilot.net>
Reply-To: Guido Falsi <mad@madpilot.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [maintainer-update] www/squidguard: fix ldap support
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         151473
>Category:       ports
>Synopsis:       [maintainer-update] www/squidguard: fix ldap support
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    rene
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 15 10:50:04 UTC 2010
>Closed-Date:    Sun Oct 31 14:21:37 UTC 2010
>Last-Modified:  Sun Oct 31 14:30:10 UTC 2010
>Originator:     Guido Falsi
>Release:        FreeBSD 8.1-STABLE amd64
>Organization:
none
>Environment:
System: FreeBSD megatron.madpilot.net 8.1-STABLE FreeBSD 8.1-STABLE #22: Tue Sep 21 19:13:06 CEST 2010 root@megatron.madpilot.net:/usr/obj/usr/src/sys/MEGATRON amd64

>Description:

Fix ldap support by helping the port's configure script find lda libraries.

Reported by: cyx on ports@freebsd.org

While I'm here stop the port from echoing ${ECHO_MSG} commands to the terminal.

Bump port version since this can impact availability of ldap functionality.

>How-To-Repeat:

Try to build the port with ldap support enabled, in many cases the
configure script will disble support because it can't find ldap
libraries.

>Fix:

diff -ruN squidguard.old/Makefile squidguard/Makefile
--- squidguard.old/Makefile	2010-10-14 17:09:46.710425824 +0200
+++ squidguard/Makefile	2010-10-14 17:31:42.605581442 +0200
@@ -7,7 +7,7 @@
 
 PORTNAME=	squidGuard
 PORTVERSION=	1.4
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	www
 MASTER_SITES=	http://www.squidguard.org/Downloads/
 
@@ -25,7 +25,7 @@
 		--with-sg-logdir=${LOGDIR} \
 		--exec-prefix=${PREFIX}
 
-CONFIGURE_ENV=	CFLAGS="${CFLAGS} -I${PREFIX}/include"
+CONFIGURE_ENV=	CFLAGS="${CFLAGS} -I${PREFIX}/include" LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib"
 
 CFGINPUT=	${.CURDIR}/files/sgcfg.in
 
@@ -118,7 +118,7 @@
 # Create sample configuration file
 #
 	@if [ ! -f "${PREFIX}/etc/squid/${PORTNAME}.conf" ] ; then \
-		${ECHO_MSG} "===>   Installing sample configuration file" ; \
+		@${ECHO_MSG} "===>   Installing sample configuration file" ; \
 		BLACKLIST_DIRS=`(cd ${DATADIR} && ${FIND} . -type d | \
 		    ${SED} '/^\.$$/d; s/^\.\//!/' | ${XARGS} ${ECHO_CMD})`; \
 		for I in `${ECHO_CMD} $${BLACKLIST_DIRS} | ${SED} 's/!//g'`; do \
@@ -139,9 +139,9 @@
 			${PREFIX}/etc/squid/${PORTNAME}.conf.sample ; \
 		${CHOWN} ${SQUID_UID}:${SQUID_GID} \
 			 ${PREFIX}/etc/squid/${PORTNAME}.conf.sample ; \
-		${ECHO_MSG} "       -> Sample configuration file installed in: ${PREFIX}/etc/squid" ; \
+		@${ECHO_MSG} "       -> Sample configuration file installed in: ${PREFIX}/etc/squid" ; \
 	else \
-		${ECHO_MSG} "===>   Existing configuration file found - sample not installed" ; \
+		@${ECHO_MSG} "===>   Existing configuration file found - sample not installed" ; \
 	fi
 
 #
@@ -154,9 +154,9 @@
 		${PREFIX}/etc/squid/${PORTNAME}.conf.sample -C all ; \
 	${CHOWN} -R ${SQUID_UID}:${SQUID_GID} ${DATADIR} ; \
 	${FIND} ${DATADIR} -type f -name *.db -exec ${CHMOD} 660 {} \; ; \
-	${ECHO_MSG} "       -> Blacklist databases installed in: ${DATADIR}"
+	@${ECHO_MSG} "       -> Blacklist databases installed in: ${DATADIR}"
 .else
-	${ECHO_MSG} "===>   Existing configuration file found - blacklist databases not created"
+	@${ECHO_MSG} "===>   Existing configuration file found - blacklist databases not created"
 .endif
 
 post-install:
>Release-Note:
>Audit-Trail:

From: Guido Falsi <mad@madpilot.net>
To: bug-followup@FreeBSD.org, mad@madpilot.net
Cc:  
Subject: Re: ports/151473: [maintainer-update] www/squidguard: fix ldap
 support
Date: Tue, 26 Oct 2010 13:31:42 +0200

 --jRHKVT23PllUwdXP
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Fixed patch.
 
 Previous one was plainly wrong. Sorry!
 
 -- 
 Guido Falsi <mad@madpilot.net>
 
 --jRHKVT23PllUwdXP
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="sg.diff"
 
 diff -ruN squidguard.old/Makefile squidguard/Makefile
 --- squidguard.old/Makefile	2010-08-13 16:11:05.000000000 +0200
 +++ squidguard/Makefile	2010-10-26 13:05:47.879973000 +0200
 @@ -7,7 +7,7 @@
  
  PORTNAME=	squidGuard
  PORTVERSION=	1.4
 -PORTREVISION=	2
 +PORTREVISION=	3
  CATEGORIES=	www
  MASTER_SITES=	http://www.squidguard.org/Downloads/
  
 @@ -25,7 +25,7 @@
  		--with-sg-logdir=${LOGDIR} \
  		--exec-prefix=${PREFIX}
  
 -CONFIGURE_ENV=	CFLAGS="${CFLAGS} -I${PREFIX}/include"
 +CONFIGURE_ENV=	CFLAGS="${CFLAGS} -I${PREFIX}/include" LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib"
  
  CFGINPUT=	${.CURDIR}/files/sgcfg.in
  
 @@ -156,7 +156,7 @@
  	${FIND} ${DATADIR} -type f -name *.db -exec ${CHMOD} 660 {} \; ; \
  	${ECHO_MSG} "       -> Blacklist databases installed in: ${DATADIR}"
  .else
 -	${ECHO_MSG} "===>   Existing configuration file found - blacklist databases not created"
 +	@${ECHO_MSG} "===>   Existing configuration file found - blacklist databases not created"
  .endif
  
  post-install:
 
 --jRHKVT23PllUwdXP--
Responsible-Changed-From-To: freebsd-ports-bugs->rene 
Responsible-Changed-By: rene 
Responsible-Changed-When: Fri Oct 29 12:32:31 UTC 2010 
Responsible-Changed-Why:  
Grab 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151473 
State-Changed-From-To: open->closed 
State-Changed-By: rene 
State-Changed-When: Sun Oct 31 14:21:23 UTC 2010 
State-Changed-Why:  
Committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151473 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/151473: commit references a PR
Date: Sun, 31 Oct 2010 14:21:22 +0000 (UTC)

 rene        2010-10-31 14:21:16 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/squidguard       Makefile 
   Log:
   - Fix ldap support by helping the port's configure script find the ldap
     libraries. [1]
   - Prevent an ECHO_MSG from being displayed twice
   - Bump PORTREVISION
   PR:             ports/151473
   Submitted by:   maintainer
   Reported by:    cyx on freebsd-ports@
   
   Revision  Changes    Path
   1.27      +3 -3      ports/www/squidguard/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
