From nobody@FreeBSD.org  Mon Oct 11 02:18:47 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2C9BB106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Oct 2010 02:18:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 010268FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Oct 2010 02:18:47 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o9B2Ik0k059899
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Oct 2010 02:18:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o9B2IktF059898;
	Mon, 11 Oct 2010 02:18:46 GMT
	(envelope-from nobody)
Message-Id: <201010110218.o9B2IktF059898@www.freebsd.org>
Date: Mon, 11 Oct 2010 02:18:46 GMT
From: Steve Wills <steve@mouf.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] fix pkg-cofig file created by www/kompozer and other build issues
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         151378
>Category:       ports
>Synopsis:       [PATCH] fix pkg-cofig file created by www/kompozer and other build issues
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beat
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 11 02:20:00 UTC 2010
>Closed-Date:    Tue Mar 01 10:14:13 EST 2011
>Last-Modified:  Tue Mar 01 10:14:13 EST 2011
>Originator:     Steve Wills
>Release:        8.1-amd64
>Organization:
>Environment:
>Description:
installing www/kompozer creates a pkg-config file which is invalid and can cause problems when installing other ports.
>How-To-Repeat:
Install www/kompozer, run pkg-config. You'll see this error message:

Cflags field occurs twice in '/usr/local/libdata/pkgconfig/kompozer-xpcom.pc' 

and pkg-config will exit with error before processing all pkg-config files.
>Fix:
see attached patch

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/www/kompozer/Makefile,v
retrieving revision 1.48
diff -u -r1.48 Makefile
--- Makefile	28 Mar 2010 06:44:51 -0000	1.48
+++ Makefile	11 Oct 2010 01:56:57 -0000
@@ -8,7 +8,7 @@
 
 PORTNAME=	kompozer
 DISTVERSION=	0.8b3
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	www
 MASTER_SITES=	SF/${PORTNAME}/current/${DISTVERSION}
 DISTNAME=	${PORTNAME}-${DISTVERSION}-src
@@ -21,6 +21,9 @@
 USE_BZIP2=	yes
 USE_GECKO=	gecko
 USE_GMAKE=	yes
+USE_XORG=	xext xt x11
+MAKE_JOBS_UNSAFE=	yes
+USE_GNOME=	gnomelibs
 WRKSRC=		${WRKDIR}/mozilla
 MAKEFILE=	client.mk
 ALL_TARGET=	build_all
Index: files/patch-build_unix_mozilla-xpcom.pc.in
===================================================================
RCS file: /home/ncvs/ports/www/kompozer/files/patch-build_unix_mozilla-xpcom.pc.in,v
retrieving revision 1.2
diff -u -r1.2 patch-build_unix_mozilla-xpcom.pc.in
--- files/patch-build_unix_mozilla-xpcom.pc.in	9 Oct 2007 00:26:21 -0000	1.2
+++ files/patch-build_unix_mozilla-xpcom.pc.in	11 Oct 2010 02:02:07 -0000
@@ -1,8 +1,9 @@
---- build/unix/mozilla-xpcom.pc.in.orig	Thu Jun 24 12:23:09 2004
-+++ build/unix/mozilla-xpcom.pc.in	Thu Jun 24 12:23:18 2004
-@@ -8,4 +8,4 @@
+--- build/unix/mozilla-xpcom.pc.in.orig	2009-05-02 12:41:00.000000000 -0400
++++ build/unix/mozilla-xpcom.pc.in	2010-10-10 21:56:08.718545662 -0400
+@@ -8,5 +8,4 @@
+ Description: The Mozilla Cross Platform Component Library
  Version: %MOZILLA_VERSION%
- Requires: mozilla-nspr = %MOZILLA_VERSION%
- Libs: -L${libdir} -lxpcom
--Cflags: -I${includedir}/xpcom -I${includedir}/string
+ Requires: %NSPR_NAME% >= %NSPR_VERSION%
+-Libs: -L${libdir} -lxpcom
+-Cflags: -I${includedir} -I${includedir}/xpcom -I${includedir}/string
 +Cflags: -I${includedir}/xpcom -I${includedir}/string -I${includedir}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gecko 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Oct 11 02:20:06 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151378 
Responsible-Changed-From-To: gecko->beat 
Responsible-Changed-By: beat 
Responsible-Changed-When: Mon Oct 11 07:19:14 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151378 

From: Beat Gaetzi <beat@FreeBSD.org>
To: bug-followup@FreeBSD.org, steve@mouf.net
Cc:  
Subject: Re: ports/151378: [PATCH] fix pkg-cofig file created by www/kompozer
 and other build issues
Date: Wed, 01 Dec 2010 12:04:28 +0100

 Hi,
 
 Sorry that this pr is open for such a long time but I've done a lot of
 testing with kompozer during the last weeks and I'm not able to
 reproduce the pkg-config error nor the build issues on my workstation
 and on my tinderbox.
 
 Could you please provide some additional information how to trigger both
 issues?
 
 Thanks,
 Beat

From: Steve Wills <steve@mouf.net>
To: Beat Gaetzi <beat@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/151378: [PATCH] fix pkg-cofig file created by www/kompozer
 and other build issues
Date: Wed, 01 Dec 2010 22:16:39 -0500

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 On 12/01/10 06:04, Beat Gaetzi wrote:
 > Hi,
 > 
 > Sorry that this pr is open for such a long time but I've done a lot of
 > testing with kompozer during the last weeks and I'm not able to
 > reproduce the pkg-config error nor the build issues on my workstation
 > and on my tinderbox.
 > 
 > Could you please provide some additional information how to trigger both
 > issues?
 
 Sure. For the pkg-config error, install kompozer, then run:
 
 pkg-config --list-all
 
 When I do this, I get an error like this:
 
 Cflags field occurs twice in
 '/usr/local/libdata/pkgconfig/kompozer-xpcom.pc'
 
 Just now when trying to reproduce it, I had to deinstall then reinstall
 kompozer for it to happen.
 
 As far as the build error, I'm unable to recall the exact error, but I
 did try to build it in my tinderbox and got this:
 
 
 checking that static assertion macros used in autoconf tests work...
 checking that static assertion macros used in autoconf tests work...
 cat: conftest.c: No such file or directory
 no
 configure: error: Compiler cannot compile macros used in autoconf tests.
 *** Fix above errors and then restart with               "gmake -f
 client.mk build"
 gmake[1]: *** [configure] Error 1
 
 See:
 
 http://meatwad.mouf.net/tb/errors/8-STABLE-amd64-FreeBSD/kompozer-0.8.b3_1.log
 
 for more detail.
 
 The patch may or may not fix that error.
 
 Steve
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.16 (FreeBSD)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
 iQEcBAEBAgAGBQJM9w+XAAoJEPXPYrMgexuhIYoIAKZzhir0XG95nXgfAnpbPyef
 kdsoHr2XHu75nh+vf20m8V5k/r0lggFnsy64DRdsAiOxAxUJOdD96J+YXfbVHFde
 tT9ac5R7F2pYeI40ZE/aZ1fKnyoNShOcZ/d9xcJI5NDj2GwWwW/eTtUBSG8oRyrz
 d0qhF3AsYn4faiV/gC557QgmdLYEYdAdiIAFpmqSTHhNUgO4OKDXBY+H9cwF5yz2
 Odcm8lhKYInbjxT0IiuE5/AmlNhS2WdA+f2c+ySMvIGf6jjXGTEblDVBytnO9a5K
 voMw+tX0qnrKCkzZ6W335mjksc+7RkE4rHsAY9sByrzM39OF48JE+Qq/z4vEYkw=
 =ma/M
 -----END PGP SIGNATURE-----

From: Beat Gaetzi <beat@FreeBSD.org>
To: bug-followup@FreeBSD.org, steve@mouf.net
Cc:  
Subject: Re: ports/151378: [PATCH] fix pkg-cofig file created by www/kompozer
 and other build issues
Date: Mon, 13 Dec 2010 13:10:02 +0100

 Hi,
 
 Thanks for the information. I was able to reproduce the pkg-config
 problem. It looks like your build problem only occurs with non default
 options set. Could you please send me all your changed options and make
 variables?
 
 Thanks,
 Beat

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/151378: commit references a PR
Date: Tue, 25 Jan 2011 22:56:08 +0000 (UTC)

 beat        2011-01-25 22:56:02 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/kompozer         Makefile 
     www/kompozer/files   patch-build_unix_mozilla-xpcom.pc.in 
   Log:
   - Fix pkg-config file
   - Bump PORTREVISION
   
   PR:             ports/151378
   Submitted by:   swills@
   Feature safe:   yes
   
   Revision  Changes    Path
   1.49      +1 -1      ports/www/kompozer/Makefile
   1.3       +7 -6      ports/www/kompozer/files/patch-build_unix_mozilla-xpcom.pc.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Mar 1 10:14:11 EST 2011 
State-Changed-Why:  
committed - thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151378 
>Unformatted:
