From ecrist@secure-computing.net  Tue Oct  5 18:47:22 2010
Return-Path: <ecrist@secure-computing.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BB19410656AC
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Oct 2010 18:47:22 +0000 (UTC)
	(envelope-from ecrist@secure-computing.net)
Received: from kenny.secure-computing.net (kenny.secure-computing.net [173.8.118.210])
	by mx1.freebsd.org (Postfix) with ESMTP id 8880D8FC22
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Oct 2010 18:47:22 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by kenny.secure-computing.net (Postfix) with SMTP id 1E2572E090
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Oct 2010 13:31:12 -0500 (CDT)
Received: from cartman.secure-computing.net (cartman.secure-computing.net [173.8.118.211])
	by kenny.secure-computing.net (Postfix) with ESMTP id 97F202E079;
	Tue,  5 Oct 2010 13:31:11 -0500 (CDT)
Received: by cartman.secure-computing.net (Postfix, from userid 1001)
	id B00D66D43A; Tue,  5 Oct 2010 13:32:57 -0500 (CDT)
Message-Id: <20101005183257.B00D66D43A@cartman.secure-computing.net>
Date: Tue,  5 Oct 2010 13:32:57 -0500 (CDT)
From: Eric F Crist <ecrist@secure-computing.net>
Reply-To: Eric F Crist <ecrist@secure-computing.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Josh Paetzel <jpaetzel@freebsd.org>
Subject: net-mgmt/nrpe2: update Makefile & pkg-plist for directory creation for pid file
X-Send-Pr-Version: 3.113
X-GNATS-Notify: jarrod@netleader.com.au

>Number:         151230
>Category:       ports
>Synopsis:       net-mgmt/nrpe2: update Makefile & pkg-plist for directory creation for pid file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jpaetzel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 05 18:50:05 UTC 2010
>Closed-Date:    Thu Oct 28 03:28:52 UTC 2010
>Last-Modified:  Fri Oct 29 12:30:11 UTC 2010
>Originator:     Eric F Crist
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
Secure Computing Networks & ClaimLynx, Inc
>Environment:
System: FreeBSD cartman.secure-computing.net 9.0-CURRENT FreeBSD 9.0-CURRENT #2: Mon Apr 12 12:46:23 CDT 2010 root@cartman.secure-computing.net:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
	nrpe2, when installed, does not create a /var/spool/nagios directory, but requires it to create a proper pid file, be default.
	
>How-To-Repeat:
>Fix:
--- nrpe2.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net-mgmt/nrpe2/Makefile,v
retrieving revision 1.27
diff -r1.27 Makefile
10c10
< PORTREVISION=	1
---
> PORTREVISION=	2
85a86
> 	${MKDIR} ${NAGIOSDIR}
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/net-mgmt/nrpe2/pkg-plist,v
retrieving revision 1.6
diff -r1.6 pkg-plist
3a4
> @unexec rmdir /var/spool/nagios 2>/dev/null || true
--- nrpe2.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Oct 5 18:50:11 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151230 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: jarrod@netleader.com.au
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/151230: net-mgmt/nrpe2: update Makefile & pkg-plist for directory creation for pid file
Date: Tue, 5 Oct 2010 18:50:09 UT

 Maintainer of net-mgmt/nrpe2,
 
 Please note that PR ports/151230 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/151230
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->jpaetzel 
Responsible-Changed-By: jpaetzel 
Responsible-Changed-When: Tue Oct 5 19:58:01 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151230 
State-Changed-From-To: feedback->closed 
State-Changed-By: jpaetzel 
State-Changed-When: Thu Oct 28 03:28:14 UTC 2010 
State-Changed-Why:  
Committed, maintainer timeout. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151230 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/151230: commit references a PR
Date: Thu, 28 Oct 2010 03:27:51 +0000 (UTC)

 jpaetzel    2010-10-28 03:27:42 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-mgmt/nrpe2       Makefile pkg-plist 
   Log:
   Create proper default directory for pidfile
   
   PR:     ports/151230
   Submitted by:   Eric F Crist <ecrist@secure-computing.net>
   Approved by:    Maintainer timeout
   
   Revision  Changes    Path
   1.28      +2 -1      ports/net-mgmt/nrpe2/Makefile
   1.7       +1 -0      ports/net-mgmt/nrpe2/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Oliver Fromme <olli@lurza.secnetix.de>
To: bug-followup@FreeBSD.org, ecrist@secure-computing.net,
        jpaetzel@FreeBSD.org
Cc:  
Subject: Re: ports/151230: net-mgmt/nrpe2: update Makefile & pkg-plist for directory creation for pid file
Date: Fri, 29 Oct 2010 13:57:30 +0200 (CEST)

 Hi,
 
 I think the change to pkg-plist is redundant, because it
 already removed the directory before.  Now it contains
 these two lines:
 
 @unexec rmdir /var/spool/nagios 2>/dev/null || true
 @unexec rmdir %%NAGIOSDIR%% 2>/dev/null || true
 
 and %%NAGIOSDIR%% expands to /var/spool/nagios by default,
 so those two lines basically do the same thing.  Therefore
 I think that r1.7 of ports/net-mgmt/nrpe2/pkg-plist should
 be reverted.
 
 Best regards
    Oliver
 
 -- 
 Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
 Handelsregister: Registergericht Muenchen, HRA 74606,  Geschftsfuehrung:
 secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mn-
 chen, HRB 125758,  Geschftsfhrer: Maik Bachmann, Olaf Erb, Ralf Gebhart
 
 FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd
 
   > Can the denizens of this group enlighten me about what the
   > advantages of Python are, versus Perl ?
 "python" is more likely to pass unharmed through your spelling
 checker than "perl".
         -- An unknown poster and Fredrik Lundh

From: Eric Crist <ecrist@secure-computing.net>
To: Oliver Fromme <olli@lurza.secnetix.de>
Cc: bug-followup@FreeBSD.org,
 jpaetzel@FreeBSD.org
Subject: Re: ports/151230: net-mgmt/nrpe2: update Makefile & pkg-plist for directory creation for pid file
Date: Fri, 29 Oct 2010 07:26:38 -0500

 You are correct, the unexec rmdir is redundant.
 
 Eric
 
 
 On Oct 29, 2010, at 06:57:30, Oliver Fromme wrote:
 
 >=20
 > Hi,
 >=20
 > I think the change to pkg-plist is redundant, because it
 > already removed the directory before.  Now it contains
 > these two lines:
 >=20
 > @unexec rmdir /var/spool/nagios 2>/dev/null || true
 > @unexec rmdir %%NAGIOSDIR%% 2>/dev/null || true
 >=20
 > and %%NAGIOSDIR%% expands to /var/spool/nagios by default,
 > so those two lines basically do the same thing.  Therefore
 > I think that r1.7 of ports/net-mgmt/nrpe2/pkg-plist should
 > be reverted.
 >=20
 > Best regards
 >   Oliver
 >=20
 > --=20
 > Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. =
 M.
 > Handelsregister: Registergericht Muenchen, HRA 74606,  =
 Gesch=E4ftsfuehrung:
 > secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht =
 M=FCn-
 > chen, HRB 125758,  Gesch=E4ftsf=FChrer: Maik Bachmann, Olaf Erb, Ralf =
 Gebhart
 >=20
 > FreeBSD-Dienstleistungen, -Produkte und mehr:  =
 http://www.secnetix.de/bsd
 >=20
 >> Can the denizens of this group enlighten me about what the
 >> advantages of Python are, versus Perl ?
 > "python" is more likely to pass unharmed through your spelling
 > checker than "perl".
 >        -- An unknown poster and Fredrik Lundh
 >=20
 
>Unformatted:
