From rnejdl@tethys.ringofsaturn.com  Wed Sep 22 20:29:47 2010
Return-Path: <rnejdl@tethys.ringofsaturn.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 69A67106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 22 Sep 2010 20:29:47 +0000 (UTC)
	(envelope-from rnejdl@tethys.ringofsaturn.com)
Received: from tethys.ringofsaturn.com (tethys.ringofsaturn.com [71.252.219.43])
	by mx1.freebsd.org (Postfix) with ESMTP id 37E4C8FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 22 Sep 2010 20:29:46 +0000 (UTC)
Received: from ASSP.nospam (localhost [127.0.0.1])
	by tethys.ringofsaturn.com (8.14.4/8.14.4) with ESMTP id o8MKTkAs055564
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 22 Sep 2010 15:29:46 -0500 (CDT)
	(envelope-from rnejdl@tethys.ringofsaturn.com)
Received: from tethys.ringofsaturn.com ([127.0.0.1] helo=tethys.ringofsaturn.com)
	with IPv4:25 by ASSP.nospam; 22 Sep 2010 15:29:45 -0500
Received: (from rnejdl@localhost)
	by tethys.ringofsaturn.com (8.14.4/8.14.4/Submit) id o8MKTjTg055563;
	Wed, 22 Sep 2010 15:29:45 -0500 (CDT)
	(envelope-from rnejdl)
Message-Id: <201009222029.o8MKTjTg055563@tethys.ringofsaturn.com>
Date: Wed, 22 Sep 2010 15:29:45 -0500 (CDT)
From: Rusty Nejdl <rnejdl@tethys.ringofsaturn.com>
Reply-To: Rusty Nejdl <rnejdl@tethys.ringofsaturn.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Update ports mail/assp to fix upgrade issues
X-Send-Pr-Version: 3.113
X-GNATS-Notify: rnejdl@ringofsaturn.com

>Number:         150866
>Category:       ports
>Synopsis:       Update ports mail/assp to fix upgrade issues
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    decke
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 22 20:30:04 UTC 2010
>Closed-Date:    Wed Sep 29 13:14:48 UTC 2010
>Last-Modified:  Wed Sep 29 13:14:48 UTC 2010
>Originator:     Rusty Nejdl
>Release:        FreeBSD 8.1-STABLE amd64
>Organization:
>Environment:
System: FreeBSD tethys.ringofsaturn.com 8.1-STABLE FreeBSD 8.1-STABLE #0: Wed Aug 25 21:56:52 CDT 2010 root@tethys.ringofsaturn.com:/usr/obj/usr/src/sys/SATURN amd64


	
>Description:
	This patch fixes upgrades which have been broken for some time.
>How-To-Repeat:
	This patch fixes upgrades.
>Fix:

	

--- assp.diff begins here ---
diff -ruN assp/Makefile assp-new/Makefile
--- assp/Makefile	2010-09-22 15:26:33.000000000 -0500
+++ assp-new/Makefile	2010-09-22 15:28:27.000000000 -0500
@@ -7,7 +7,7 @@
 
 PORTNAME=	assp
 PORTVERSION=	1.7.5.7
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	mail
 MASTER_SITES=	SF/${PORTNAME}/ASSP%20Installation/${PORTNAME:U}%20${PORTVERSION}/
 DISTNAME=	${PORTNAME:U}_${PORTVERSION}-Install
@@ -177,10 +177,10 @@
 	${MKDIR} ${ASSP_HOME}
 	${CHOWN} ${ASSP_USER}:${ASSP_GROUP} ${ASSP_HOME}
 	${CHMOD} 700 ${ASSP_HOME}
-	${LN} -s ${DATADIR}/files ${ASSP_HOME}
-	${LN} -s ${DATADIR}/images ${ASSP_HOME}
-	${LN} -s ${DATADIR}/reports ${ASSP_HOME}
-	${LN} -s ${ASSP_LOG} ${ASSP_HOME}/logs
+	${LN} -fs ${DATADIR}/files ${ASSP_HOME}
+	${LN} -fs ${DATADIR}/images ${ASSP_HOME}
+	${LN} -fs ${DATADIR}/reports ${ASSP_HOME}
+	${LN} -fs ${ASSP_LOG} ${ASSP_HOME}/logs
 
 	${MKDIR} ${PREFIX}/etc/periodic/daily
 	${INSTALL_SCRIPT} ${WRKDIR}/periodic-assp.sh ${PREFIX}/etc/periodic/daily/510.assp
--- assp.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Sep 22 20:30:18 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150866 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: rnejdl@ringofsaturn.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/150866: Update ports mail/assp to fix upgrade issues
Date: Wed, 22 Sep 2010 20:30:15 UT

 Maintainer of mail/assp,
 
 Please note that PR ports/150866 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150866
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Wed Sep 22 21:05:55 UTC 2010 
State-Changed-Why:  
Submitter is maintainer from other address 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150866 

From: Rusty Nejdl <rnejdl@ringofsaturn.com>
To: edwin@FreeBSD.org
Cc: rnejdl@tethys.ringofsaturn.com, freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/150866: Update ports mail/assp to fix upgrade issues
Date: Wed, 22 Sep 2010 15:32:50 -0500

  On Wed, 22 Sep 2010 20:30:19 GMT, edwin@FreeBSD.org wrote:
 > Synopsis: Update ports mail/assp to fix upgrade issues
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: edwin
 > State-Changed-When: Wed Sep 22 20:30:18 UTC 2010
 > State-Changed-Why:
 > Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=150866
  
  Edwin,
  
  Sorry about that... I am the maintainer but didn't fix my email address 
  to show as correctly.  Please commit when you can.
  
  Rusty Nejdl
 
Responsible-Changed-From-To: freebsd-ports-bugs->decke 
Responsible-Changed-By: decke 
Responsible-Changed-When: Fri Sep 24 07:17:13 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150866 

From: Bernhard Froehlich <decke@FreeBSD.org>
To: bug-followup@FreeBSD.org, rnejdl@tethys.ringofsaturn.com
Cc:  
Subject: Re: ports/150866: Update ports mail/assp to fix upgrade issues
Date: Mon, 27 Sep 2010 20:33:13 +0200

 What is the problem that this patch fixes? I tried to imagine a
 few situations but couldn't find a matching one so I'm curious.
 
 -- 
 Bernhard Froehlich
 http://www.bluelife.at/
 

From: Rusty Nejdl <rnejdl@ringofsaturn.com>
To: Bernhard Froehlich <decke@FreeBSD.org>
Cc: <bug-followup@FreeBSD.org>, <rnejdl@tethys.ringofsaturn.com>
Subject: Re: ports/150866: Update ports mail/assp to fix upgrade issues
Date: Mon, 27 Sep 2010 13:34:32 -0500

  On Mon, 27 Sep 2010 20:33:13 +0200, Bernhard Froehlich 
  <decke@FreeBSD.org> wrote:
 > What is the problem that this patch fixes? I tried to imagine a
 > few situations but couldn't find a matching one so I'm curious.
  
  If the symlinks already exist, then it just recreates them.  In the 
  past, if you had this installed, it wouldn't remove the symlinks on 
  uninstall and reinstalling would die because the symlinks existed 
  already.  It's probably not the cleanest way but it is better than it 
  was.  I'm open for suggestions though.
  
  Rusty

From: Bernhard Froehlich <decke@FreeBSD.org>
To: Rusty Nejdl <rnejdl@ringofsaturn.com>
Cc: <bug-followup@FreeBSD.org>, <rnejdl@tethys.ringofsaturn.com>
Subject: Re: ports/150866: Update ports mail/assp to fix upgrade issues
Date: Tue, 28 Sep 2010 08:17:17 +0000

 On Mon, 27 Sep 2010 13:34:32 -0500, Rusty Nejdl
 <rnejdl@ringofsaturn.com> wrote:
 > On Mon, 27 Sep 2010 20:33:13 +0200, Bernhard Froehlich
 > <decke@FreeBSD.org> wrote:
 >> What is the problem that this patch fixes? I tried to imagine a
 >> few situations but couldn't find a matching one so I'm curious.
 > 
 > If the symlinks already exist, then it just recreates them.  In the
 > past, if you had this installed, it wouldn't remove the symlinks on
 > uninstall and reinstalling would die because the symlinks existed
 > already.  It's probably not the cleanest way but it is better than it
 > was.  I'm open for suggestions though.
 
 All symlinks have pkg-plist entries so they should be removed at
 uninstall. I can't see a reason why removing the symlinks should fail.
 
 -- 
 Bernhard Froehlich
 http://www.bluelife.at/

From: Rusty Nejdl <rnejdl@ringofsaturn.com>
To: Bernhard Froehlich <decke@FreeBSD.org>
Cc: <bug-followup@FreeBSD.org>, <rnejdl@tethys.ringofsaturn.com>
Subject: Re: ports/150866: Update ports mail/assp to fix upgrade issues
Date: Tue, 28 Sep 2010 13:50:44 -0500

  On Tue, 28 Sep 2010 08:17:17 +0000, Bernhard Froehlich 
  <decke@FreeBSD.org> wrote:
 > On Mon, 27 Sep 2010 13:34:32 -0500, Rusty Nejdl
 > <rnejdl@ringofsaturn.com> wrote:
 >> On Mon, 27 Sep 2010 20:33:13 +0200, Bernhard Froehlich
 >> <decke@FreeBSD.org> wrote:
 >>> What is the problem that this patch fixes? I tried to imagine a
 >>> few situations but couldn't find a matching one so I'm curious.
 >>
 >> If the symlinks already exist, then it just recreates them.  In the
 >> past, if you had this installed, it wouldn't remove the symlinks on
 >> uninstall and reinstalling would die because the symlinks existed
 >> already.  It's probably not the cleanest way but it is better than 
 >> it
 >> was.  I'm open for suggestions though.
 >
 > All symlinks have pkg-plist entries so they should be removed at
 > uninstall. I can't see a reason why removing the symlinks should 
 > fail.
  
  Bernhard,
  
  So far, in my test environment, you are absolutely correct that this 
  change is not needed.  I think though that in my production setup I have 
  additional files which assp generated and the upgrades conflict with.  
  So, I will be testing that further and seeing what I need to do with the 
  port to make it work better, if anything at all.  You can go ahead and 
  close this PR out for now.
  
  Sincerely,
  Rusty Nejdl
State-Changed-From-To: open->closed 
State-Changed-By: decke 
State-Changed-When: Wed Sep 29 13:14:47 UTC 2010 
State-Changed-Why:  
Closed by submitters request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150866 
>Unformatted:
