From swell.k@gmail.com  Sat Sep 18 05:13:32 2010
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6B753106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Sep 2010 05:13:32 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 3360C8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Sep 2010 05:13:31 +0000 (UTC)
Received: by iwn34 with SMTP id 34so3021034iwn.13
        for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Sep 2010 22:13:31 -0700 (PDT)
Received: by 10.231.193.135 with SMTP id du7mr5508670ibb.176.1284786811227;
        Fri, 17 Sep 2010 22:13:31 -0700 (PDT)
Received: from localhost (tor-exit-proxy3-readme.formlessnetworking.net [208.53.142.39])
        by mx.google.com with ESMTPS id e12sm4489918iba.12.2010.09.17.22.13.29
        (version=SSLv3 cipher=RC4-MD5);
        Fri, 17 Sep 2010 22:13:30 -0700 (PDT)
Message-Id: <8662y3mygi.fsf@gmail.com>
Date: Sat, 18 Sep 2010 09:07:25 +0400
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] devel/rlwrap: update to 0.37

>Number:         150694
>Category:       ports
>Synopsis:       [patch] devel/rlwrap: update to 0.37
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 18 05:20:00 UTC 2010
>Closed-Date:    Tue Oct 19 08:16:57 UTC 2010
>Last-Modified:  Tue Oct 19 08:16:57 UTC 2010
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
- update
- remove -lutil cruft from before AC_CHECK_LIB() was added
- either use openpty() or search manually (not sure)[1]

[1] PTYS_ARE_PTMX ifdef patch was incorrect, anyway. According to
    configure.ac there can be only one of PTYS_ARE_XXX be defined at a
    time because the check uses `else if'.
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: devel/rlwrap/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/rlwrap/Makefile,v
retrieving revision 1.32
diff -u -p -r1.32 Makefile
--- devel/rlwrap/Makefile	27 Jan 2010 13:01:11 -0000	1.32
+++ devel/rlwrap/Makefile	18 Sep 2010 04:59:09 -0000
@@ -7,7 +7,7 @@
 #
 
 PORTNAME=	rlwrap
-PORTVERSION=	0.36
+PORTVERSION=	0.37
 CATEGORIES=	devel
 MASTER_SITES=	http://utopia.knoware.nl/~hlub/uck/rlwrap/ \
 		${MASTER_SITE_LOCAL} \
@@ -18,13 +18,15 @@ MAINTAINER=	gamato@users.sf.net
 COMMENT=	Readline wrapper
 
 GNU_CONFIGURE=		yes
-CONFIGURE_ENV+=		ptyttylib_cv_ptys=BSD LDFLAGS=-lutil
 
 MAN1=	rlwrap.1
 MAN3=	RlwrapFilter.3pm
 
 PORTDOCS=	AUTHORS BUGS NEWS PLEA README TODO
 
+post-patch:	.SILENT
+	${REINPLACE_CMD} 's|/dev/ptmx|${NONEXISTENT}|' ${WRKSRC}/configure
+
 post-install:
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
Index: devel/rlwrap/distinfo
===================================================================
RCS file: /a/.cvsup/ports/devel/rlwrap/distinfo,v
retrieving revision 1.15
diff -u -p -r1.15 distinfo
--- devel/rlwrap/distinfo	27 Jan 2010 13:01:11 -0000	1.15
+++ devel/rlwrap/distinfo	18 Sep 2010 04:44:26 -0000
@@ -1,3 +1,3 @@
-MD5 (rlwrap-0.36.tar.gz) = f3d687658336789d5155322abcc84a7f
-SHA256 (rlwrap-0.36.tar.gz) = 87f416dfda0e26d3b59a7d940dd2a871279bc56879f3fe2f0ff5f9bf5369892f
-SIZE (rlwrap-0.36.tar.gz) = 247198
+MD5 (rlwrap-0.37.tar.gz) = 04cd6e2c257eb5a86b297f2ebf91dbbf
+SHA256 (rlwrap-0.37.tar.gz) = 8403a2c184a33ee293a30637afd1362e7dbe0ee642c33b54b2fca68162498bbd
+SIZE (rlwrap-0.37.tar.gz) = 251438
Index: devel/rlwrap/pkg-plist
===================================================================
RCS file: /a/.cvsup/ports/devel/rlwrap/pkg-plist,v
retrieving revision 1.5
diff -u -p -r1.5 pkg-plist
--- devel/rlwrap/pkg-plist	27 Jan 2010 13:01:11 -0000	1.5
+++ devel/rlwrap/pkg-plist	26 Aug 2010 15:49:03 -0000
@@ -7,6 +7,7 @@ bin/rlwrap
 %%DATADIR%%/filters/censor_passwords
 %%DATADIR%%/filters/count_in_prompt
 %%DATADIR%%/filters/ftp_filter
+%%DATADIR%%/filters/history_format
 %%DATADIR%%/filters/listing
 %%DATADIR%%/filters/logger
 %%DATADIR%%/filters/null
Index: devel/rlwrap/files/patch-src::ptytty.c
===================================================================
RCS file: /a/.cvsup/ports/devel/rlwrap/files/patch-src::ptytty.c,v
retrieving revision 1.4
diff -u -p -r1.4 patch-src::ptytty.c
--- devel/rlwrap/files/patch-src::ptytty.c	27 Jan 2010 13:01:11 -0000	1.4
+++ devel/rlwrap/files/patch-src::ptytty.c	18 Sep 2010 04:59:21 -0000
@@ -1,14 +1,5 @@
 --- src/ptytty.c.orig	2010-01-24 01:05:53.000000000 -0800
 +++ src/ptytty.c	2010-01-24 01:09:19.000000000 -0800
-@@ -41,7 +41,7 @@
- #ifdef HAVE_SYS_IOCTL_H
- # include <sys/ioctl.h>
- #endif
--#if defined(PTYS_ARE_PTMX) && !defined(__CYGWIN32__)
-+#if defined(PTYS_ARE_PTMX) && !defined(__CYGWIN32__) && !defined(__FreeBSD__)
- # include <sys/stropts.h>       /* for I_PUSH */
- #endif
- 
 @@ -159,11 +159,19 @@
      char pty_name[] = "/dev/pty??";
      char tty_name[] = "/dev/tty??";
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Sep 18 05:20:06 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150694 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: gamato@users.sf.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/150694: [patch] devel/rlwrap: update to 0.37
Date: Sat, 18 Sep 2010 05:20:04 UT

 Maintainer of devel/rlwrap,
 
 Please note that PR ports/150694 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150694
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Wed Sep 22 06:12:49 UTC 2010 
Responsible-Changed-Why:  
I will take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150694 
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Wed Oct 6 03:30:17 UTC 2010 
State-Changed-Why:  
maintainer timeout (gamato@users.sf.net ; 14 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150694 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Wed Oct 6 03:40:59 UTC 2010 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150694 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/150694: commit references a PR
Date: Wed,  6 Oct 2010 03:40:51 +0000 (UTC)

 pgollucci    2010-10-06 03:40:46 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/rlwrap         Makefile distinfo pkg-plist 
     devel/rlwrap/files   patch-src::ptytty.c 
   Log:
   - update to 0.37
   - remove -lutil cruft from before AC_CHECK_LIB() was added
   - either use openpty() or search manually (not sure)[1]
   
   [1] PTYS_ARE_PTMX ifdef patch was incorrect, anyway. According to
   configure.ac there can be only one of PTYS_ARE_XXX be defined at a
   time because the check uses `else if'.
   
   PR:             ports/150694
   Submitted by:   swell.k@gmail.com
   Approved by:    maintainer timeout (gamato@users.sf.net ; 14 days)
   
   Revision  Changes    Path
   1.33      +4 -2      ports/devel/rlwrap/Makefile
   1.16      +3 -3      ports/devel/rlwrap/distinfo
   1.5       +0 -9      ports/devel/rlwrap/files/patch-src::ptytty.c
   1.6       +1 -0      ports/devel/rlwrap/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: mato <gamato@users.sf.net>
To: bug-followup@FreeBSD.org
Cc: Edwin Groothuis <edwin@FreeBSD.org>
Subject: Re: ports/150694: [patch] devel/rlwrap: update to 0.37
Date: Mon, 11 Oct 2010 22:41:38 +0200

 Edwin Groothuis wrote:
 > Maintainer of devel/rlwrap,
 >
 > Please note that PR ports/150694 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150694
 >
 >    
 
 Ok, I approve.  Sorry for delay.
 
 Btw, this is a feedback from rlwrap maintainer on our (previous) port:
 
 Hi Martin
 
 The solution is trivial: the line
 
     CONFIGURE_ENV+=         ptyttylib_cv_ptys=BSD LDFLAGS=-lutil
 
 in the port Makefile forces the configure script to skip autodetection 
 of pty type, and to take the wrong decision. It may have been necessary 
 long, long ago, but not anymore. Just remove it, and everything will 
 work just fine.
 
 I will rename the $ptyttylib_cv_ptys value "BSD" to "PREHISTORIC" to 
 remove the temptation for BSD people to set this varable...
 
 regards
 
 Hans
State-Changed-From-To: closed->open 
State-Changed-By: pgollucci 
State-Changed-When: Mon Oct 11 21:11:50 UTC 2010 
State-Changed-Why:  
Maintainer approved 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150694 
State-Changed-From-To: open->feedback 
State-Changed-By: pgollucci 
State-Changed-When: Tue Oct 19 05:17:38 UTC 2010 
State-Changed-Why:  
Request Feedback: do I need to change something else here?  A diff would 
be appreciated. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150694 

From: Anonymous <swell.k@gmail.com>
To: pgollucci@FreeBSD.org
Cc: bug-followup@freebsd.org, gamato@users.sf.net
Subject: Re: ports/150694: [patch] devel/rlwrap: update to 0.37
Date: Tue, 19 Oct 2010 11:30:51 +0400

 pgollucci@FreeBSD.org writes:
 
 > Request Feedback: do I need to change something else here?  A diff would
 > be appreciated.
 
 I've made that diff with s/BSD/PREHISTORIC/ in mind. And maintainer
 approved the changes, too. I think it can be closed.
State-Changed-From-To: feedback->closed 
State-Changed-By: pgollucci 
State-Changed-When: Tue Oct 19 08:16:56 UTC 2010 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150694 
>Unformatted:
