From rea-fbsd@codelabs.ru  Sat Sep 11 05:53:34 2010
Return-Path: <rea-fbsd@codelabs.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E8574106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Sep 2010 05:53:34 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 9A1E18FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 11 Sep 2010 05:53:34 +0000 (UTC)
Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25])
	by 0.mx.codelabs.ru with esmtps (TLSv1:CAMELLIA256-SHA:256)
	id 1OuJ1j-0006H9-Iq for FreeBSD-gnats-submit@freebsd.org; Sat, 11 Sep 2010 09:53:27 +0400
Message-Id: <20100911055327.65D7DDA81A@void.codelabs.ru>
Date: Sat, 11 Sep 2010 09:53:27 +0400 (MSD)
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Reply-To: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] www/trac: introduce Babel dependency
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         150483
>Category:       ports
>Synopsis:       [patch] www/trac: introduce Babel dependency
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 11 06:00:14 UTC 2010
>Closed-Date:    Mon Oct 11 22:41:26 UTC 2010
>Last-Modified:  Tue Oct 12 06:30:07 UTC 2010
>Originator:     Eygene Ryabinkin
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
Code Labs
>Environment:

System: FreeBSD 9.0-CURRENT amd64

>Description:

Current Trac port requires no Babel (devel/py-babel), but it behaves
differently when Babel is present and when it is not present in the
system. Most notably, when one installs Trac 0.12 without installed
Babel and installs Babel later, Trac will refuse to work with the error
"KeyError: trac/locale".

There is Trac ticket about this:
  http://trac.edgewall.org/ticket/9439

There is an announcement that Trac 0.12 has i18n/L10n and uses Babel
for it:
  http://trac.edgewall.org/wiki/TracL10N

>How-To-Repeat:

Install Trac when no devel/py-babel is present in the system, install
py-babel and watch how Trac will be broken: it will refuse to work giving
the message "KeyError: trac/locale".

>Fix:

We should just add Babel dependency.  Here is the patch for this:
  http://codelabs.ru/fbsd/ports/trac/0.12-add-babel-dependency.diff

It was tested on our Trac 0.12; updated port passed Tinderbox builds
for 7.x/8.x and 9.x.

There is one issue: when Babel will be installed, Trac will start to
use speaker's natural locale (it uses browser charset negotiation)
and that't not desirable for every installation, since some translations
are very "unnatural".  Trac 0.12.1 will have the knob 'default_language'
that will allow Trac administrator to specify the default L10n language.
I had extracted that patch from the 0.12 repository, added it to our
Trac and tested for some days.  It works fine and behaves as expected.
The patch that can be dropped to port's files/ directory is available
at the following URL:
  http://codelabs.ru/fbsd/ports/trac/0.12-upstream-patch-add-default_language-knob.diff
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Sep 11 06:00:25 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150483 

From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/150483: [patch] www/trac: introduce Babel dependency
Date: Fri, 17 Sep 2010 21:43:36 +0400

 Gentlemen, can we push this PR into the review?
 -- 
 Eygene
  _                ___       _.--.   #
  \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
  /  ' `         ,       __.--'      #  to read the on-line manual
  )/' _/     \   `-_,   /            #  while single-stepping the kernel.
  `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
      _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
     {_.-``-'         {_/            #

From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/150483: [patch] www/trac: introduce Babel dependency
Date: Mon, 4 Oct 2010 00:41:38 +0400

 Fri, Sep 17, 2010 at 09:43:36PM +0400, Eygene Ryabinkin wrote:
 > Gentlemen, can we push this PR into the review?
 
 Anyone?
 -- 
 Eygene
  _                ___       _.--.   #
  \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
  /  ' `         ,       __.--'      #  to read the on-line manual
  )/' _/     \   `-_,   /            #  while single-stepping the kernel.
  `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
      _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
     {_.-``-'         {_/            #
Responsible-Changed-From-To: clsung->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Mon Oct 11 21:03:50 UTC 2010 
Responsible-Changed-Why:  
committer&maintainer timeout (clsung ; 30 days) / last commit: 21 days 
ago 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150483 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Mon Oct 11 22:41:25 UTC 2010 
State-Changed-Why:  
Committed, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150483 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/150483: commit references a PR
Date: Tue, 12 Oct 2010 06:20:37 +0000 (UTC)

 pgollucci    2010-10-12 06:20:30 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/trac             Makefile 
   Added files:
     www/trac/files       patch-trac__util__translation.py 
                          patch-trac__web__main.py 
   Log:
   - Fix http://trac.edgewall.org/ticket/9439, http://trac.edgewall.org/wiki/TracL10N
   - Bump PORTREVISION
   
   Current Trac port requires no Babel (devel/py-babel), but it behaves
   differently when Babel is present and when it is not present in the
   system. Most notably, when one installs Trac 0.12 without installed
   Babel and installs Babel later, Trac will refuse to work with the error
   "KeyError: trac/locale".
   
   PR:             ports/150483
   Submitted by:   Eygene Ryabinkin <rea-fbsd@codelabs.ru>
   Approved by:    maintainer timeout (clsung ; 30 days)
   
   Revision  Changes    Path
   1.49      +3 -1      ports/www/trac/Makefile
   1.1       +35 -0     ports/www/trac/files/patch-trac__util__translation.py (new)
   1.1       +58 -0     ports/www/trac/files/patch-trac__web__main.py (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
