From nobody@FreeBSD.org  Tue Sep  7 19:17:56 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AD29310656BE
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Sep 2010 19:17:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 819A18FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Sep 2010 19:17:56 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o87JHuwu018260
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 7 Sep 2010 19:17:56 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o87JHuHH018239;
	Tue, 7 Sep 2010 19:17:56 GMT
	(envelope-from nobody)
Message-Id: <201009071917.o87JHuHH018239@www.freebsd.org>
Date: Tue, 7 Sep 2010 19:17:56 GMT
From: Kuan-Chung Chiu <buganini@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] provide script to bind with nautilus for multimedia/ffmpegthumbnailer
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: dierk@blaxxtarz.de

>Number:         150361
>Category:       ports
>Synopsis:       [patch] provide script to bind with nautilus for multimedia/ffmpegthumbnailer
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    stephen
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 07 19:20:04 UTC 2010
>Closed-Date:    Tue Jul 05 21:48:20 UTC 2011
>Last-Modified:  Tue Jul  5 21:50:05 UTC 2011
>Originator:     Kuan-Chung Chiu
>Release:        9.0-CURRENT
>Organization:
N/A
>Environment:
FreeBSD Elizabeth.twbbs.org 9.0-CURRENT FreeBSD 9.0-CURRENT #8 r212185: Sun Sep  5 04:42:26 CST 2010     root@elizabeth.twbbs.org:/usr/obj/usr/src/sys/ELIZABETH  amd64
>Description:
Provide a script that user can easily bind ffmpegthumbnailer with nautilus
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN ffmpegthumbnailer.orig/Makefile ffmpegthumbnailer/Makefile
--- ffmpegthumbnailer.orig/Makefile	2010-09-08 02:56:40.000000000 +0800
+++ ffmpegthumbnailer/Makefile	2010-09-08 03:03:53.000000000 +0800
@@ -29,4 +29,7 @@
 
 MAN1=		ffmpegthumbnailer.1
 
+post-install:
+	@${CAT} ${PKGMESSAGE}
+
 .include <bsd.port.mk>
diff -ruN ffmpegthumbnailer.orig/files/bind-nautilus.sh ffmpegthumbnailer/files/bind-nautilus.sh
--- ffmpegthumbnailer.orig/files/bind-nautilus.sh	1970-01-01 08:00:00.000000000 +0800
+++ ffmpegthumbnailer/files/bind-nautilus.sh	2010-09-08 03:13:45.000000000 +0800
@@ -0,0 +1,14 @@
+#!/bin/sh
+
+type="application@x-extension-webm video/3gpp video/3gpp2 video@avi \
+video@flv video@mkv video@mp4 video@mpeg video@ogg video@quicktime video@webm \
+video@x-avi video@x-flv video@x-m4v video@x-matroska video@x-mkv video@x-mp4 \
+video@x-mpeg video@x-ms-asf video@x-ms-wmv video@x-ms-wvx video@x-msvideo \
+video@x-msvideo@avi video@x-theora@ogg video@x-theora@ogv video@x-webm"
+
+cmd="/usr/bin/ffmpegthumbnailer -s %s -i %i -o %o -f"
+
+for i in $type; do
+gconftool-2 -s "/desktop/gnome/thumbnailers/$i/command" -t string "$cmd"
+gconftool-2 -s "/desktop/gnome/thumbnailers/$i/enable" -t boolean "true"
+done
diff -ruN ffmpegthumbnailer.orig/pkg-message ffmpegthumbnailer/pkg-message
--- ffmpegthumbnailer.orig/pkg-message	1970-01-01 08:00:00.000000000 +0800
+++ ffmpegthumbnailer/pkg-message	2010-09-08 03:05:56.000000000 +0800
@@ -0,0 +1,3 @@
+For Gnome user:
+	If you wish to bind this with nautilus, see files/bind-nautilus.sh
+


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Sep 7 19:20:14 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150361 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: dierk@blaxxtarz.de
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/150361: [patch] provide script to bind with nautilus for multimedia/ffmpegthumbnailer
Date: Tue, 7 Sep 2010 19:20:12 UT

 Maintainer of multimedia/ffmpegthumbnailer,
 
 Please note that PR ports/150361 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150361
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Thu Sep 23 05:18:25 UTC 2010 
State-Changed-Why:  
maintainer timeout (dierk@blaxxtarz.de ; 16 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150361 
State-Changed-From-To: open->feedback 
State-Changed-By: stephen 
State-Changed-When: Mon Jul 4 01:21:02 UTC 2011 
State-Changed-Why:  
I have questions for the submitter. 


Responsible-Changed-From-To: freebsd-ports-bugs->stephen 
Responsible-Changed-By: stephen 
Responsible-Changed-When: Mon Jul 4 01:21:02 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150361 

From: Stephen Montgomery-Smith <stephen@missouri.edu>
To: bug-followup@FreeBSD.org, buganini@gmail.com
Cc:  
Subject: Re: ports/150361: [patch] provide script to bind with nautilus for
 multimedia/ffmpegthumbnailer
Date: Sun, 03 Jul 2011 20:22:45 -0500

 It seems to me that a problem with this patch is that the 
 bind-nautilus.sh script is not available to anyone who installs this as 
 a package.  So:
 
 # pkg_add ffmpegthumbnailer-2.0.4_1.tbz
 
 For Gnome user:
 	If you wish to bind this with nautilus, see files/bind-nautilus.sh
 
 The user installing this using a package doesn't have any idea where 
 files/bind-nautilus.sh is.
 
 Shouldn't this script be stored somewhere under /usr/local?  I must 
 admit that I don't know where this sort of thing is conventionally stored.

From: Buganini <buganini@gmail.com>
To: bug-followup@FreeBSD.org, buganini@gmail.com
Cc:  
Subject: Re: ports/150361: [patch] provide script to bind with nautilus for multimedia/ffmpegthumbnailer
Date: Mon, 4 Jul 2011 11:55:15 +0800

 --001517740d92bec7d004a736552e
 Content-Type: text/plain; charset=UTF-8
 
 how about put it in share/ (%%DATADIR%%) ?
 
 --001517740d92bec7d004a736552e
 Content-Type: text/html; charset=UTF-8
 
 how about put it in share/ (%%DATADIR%%) ?<br>
 
 --001517740d92bec7d004a736552e--

From: Stephen Montgomery-Smith <stephen@missouri.edu>
To: bug-followup@FreeBSD.org, buganini@gmail.com
Cc:  
Subject: Re: ports/150361: [patch] provide script to bind with nautilus for
 multimedia/ffmpegthumbnailer
Date: Mon, 04 Jul 2011 01:38:02 -0500

 This is a multi-part message in MIME format.
 --------------000909020703080207050408
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 I made some changes to your patch.  First, I have put the script into 
 %%DATADIR%% as you suggest.  Second, I changed the typesetting of 
 pkg-message.  portlint doesn't like blank lines at the end of 
 pkg-message.  Thirdly, I added a comment to bind-nautilus.sh so that a 
 casual user who comes across it will understand what it is about.
 
 Tell me what you think.
 
 I am a new committer, so after making the changes I will have to submit 
 it to my mentors for approval.
 
 --------------000909020703080207050408
 Content-Type: text/plain;
  name="ddd"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="ddd"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/multimedia/ffmpegthumbnailer/Makefile,v
 retrieving revision 1.12
 diff -u -r1.12 Makefile
 --- Makefile	24 Jun 2011 22:38:58 -0000	1.12
 +++ Makefile	4 Jul 2011 06:28:33 -0000
 @@ -17,8 +17,7 @@
  		swscale:${PORTSDIR}/multimedia/ffmpeg \
  		jpeg.11:${PORTSDIR}/graphics/jpeg
  
 -CONFIGURE_ENV=	CPPFLAGS="${PTHREAD_CFLAGS} -I${LOCALBASE}/include" \
 -		LDFLAGS="${PTHREAD_LIBS} -L${LOCALBASE}/lib"
 +CONFIGURE_ENV=	LDFLAGS="${PTHREAD_LIBS} -L${LOCALBASE}/lib"
  CONFIGURE_ARGS=	--with-pkgconfigdir=${PREFIX}/libdata/pkgconfig
  
  GNU_CONFIGURE=	yes
 @@ -28,7 +27,12 @@
  
  MAN1=		ffmpegthumbnailer.1
  
 +SUB_FILES=	pkg-message
 +
  post-install:
  	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
 +	${MKDIR} ${DATADIR}
 +	${INSTALL_SCRIPT} ${FILESDIR}/bind-nautilus.sh ${DATADIR}
 +	@${CAT} ${PKGMESSAGE}
  
  .include <bsd.port.mk>
 Index: pkg-plist
 ===================================================================
 RCS file: /home/pcvs/ports/multimedia/ffmpegthumbnailer/pkg-plist,v
 retrieving revision 1.4
 diff -u -r1.4 pkg-plist
 --- pkg-plist	4 Dec 2010 18:01:26 -0000	1.4
 +++ pkg-plist	4 Jul 2011 06:28:33 -0000
 @@ -10,4 +10,6 @@
  lib/libffmpegthumbnailer.so
  lib/libffmpegthumbnailer.so.4
  libdata/pkgconfig/libffmpegthumbnailer.pc
 +%%DATADIR%%/bind-nautilus.sh
  @dirrm include/libffmpegthumbnailer
 +@dirrm %%DATADIR%%
 Index: files/bind-nautilus.sh
 ===================================================================
 RCS file: files/bind-nautilus.sh
 diff -N files/bind-nautilus.sh
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/bind-nautilus.sh	4 Jul 2011 06:28:33 -0000
 @@ -0,0 +1,16 @@
 +#!/bin/sh
 +
 +# Use this script to bind ffmpegthumbnailer to nautilus.
 +
 +type="application@x-extension-webm video/3gpp video/3gpp2 video@avi \
 +video@flv video@mkv video@mp4 video@mpeg video@ogg video@quicktime video@webm \
 +video@x-avi video@x-flv video@x-m4v video@x-matroska video@x-mkv video@x-mp4 \
 +video@x-mpeg video@x-ms-asf video@x-ms-wmv video@x-ms-wvx video@x-msvideo \
 +video@x-msvideo@avi video@x-theora@ogg video@x-theora@ogv video@x-webm"
 +
 +cmd="/usr/bin/ffmpegthumbnailer -s %s -i %i -o %o -f"
 +
 +for i in $type; do
 +gconftool-2 -s "/desktop/gnome/thumbnailers/$i/command" -t string "$cmd"
 +gconftool-2 -s "/desktop/gnome/thumbnailers/$i/enable" -t boolean "true"
 +done
 Index: files/pkg-message.in
 ===================================================================
 RCS file: files/pkg-message.in
 diff -N files/pkg-message.in
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/pkg-message.in	4 Jul 2011 06:28:33 -0000
 @@ -0,0 +1,2 @@
 +Gnome users may bind ffmpegthumbnailer to nautilus using:
 +%%DATADIR%%/bind-nautilus.sh.
 
 --------------000909020703080207050408--

From: Buganini <buganini@gmail.com>
To: bug-followup@FreeBSD.org, buganini@gmail.com
Cc:  
Subject: Re: ports/150361: [patch] provide script to bind with nautilus for multimedia/ffmpegthumbnailer
Date: Mon, 4 Jul 2011 15:28:39 +0800

 --90e6ba6135b4ece0fa04a7395068
 Content-Type: text/plain; charset=UTF-8
 
 that's good, thank you!
 
 --90e6ba6135b4ece0fa04a7395068
 Content-Type: text/html; charset=UTF-8
 
 that&#39;s good, thank you!<br>
 
 --90e6ba6135b4ece0fa04a7395068--
State-Changed-From-To: feedback->closed 
State-Changed-By: stephen 
State-Changed-When: Tue Jul 5 21:47:55 UTC 2011 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150361 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/150361: commit references a PR
Date: Tue,  5 Jul 2011 21:46:20 +0000 (UTC)

 stephen     2011-07-05 21:46:07 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/ffmpegthumbnailer Makefile pkg-plist 
   Added files:
     multimedia/ffmpegthumbnailer/files bind-nautilus.sh 
                                        pkg-message.in 
   Log:
   - Add script to allow users to bind with nautilus.
   - Bump portrevision.
   
   PR:             ports/150361
   Submitted by:   Kuan-Chung Chiu <buganini@gmail.com>
   Approved by:    maho (mentor)
   
   Revision  Changes    Path
   1.13      +7 -3      ports/multimedia/ffmpegthumbnailer/Makefile
   1.1       +16 -0     ports/multimedia/ffmpegthumbnailer/files/bind-nautilus.sh (new)
   1.1       +2 -0      ports/multimedia/ffmpegthumbnailer/files/pkg-message.in (new)
   1.5       +2 -0      ports/multimedia/ffmpegthumbnailer/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
