From nobody@FreeBSD.org  Sat Sep  4 18:02:22 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 705E210656B8
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  4 Sep 2010 18:02:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 45C4C8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  4 Sep 2010 18:02:22 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o84I2Mgs059971
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 4 Sep 2010 18:02:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o84I2L9o059970;
	Sat, 4 Sep 2010 18:02:21 GMT
	(envelope-from nobody)
Message-Id: <201009041802.o84I2L9o059970@www.freebsd.org>
Date: Sat, 4 Sep 2010 18:02:21 GMT
From: Max Brazhnikov <makc@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: audio/libtunepimp: add missing dependency on libmpcdec
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: bsdkaffee@gmail.com

>Number:         150285
>Category:       ports
>Synopsis:       audio/libtunepimp: add missing dependency on libmpcdec
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    makc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 04 18:10:02 UTC 2010
>Closed-Date:    Mon Sep 06 18:11:14 UTC 2010
>Last-Modified:  Mon Sep 06 18:11:14 UTC 2010
>Originator:     Max Brazhnikov
>Release:        FreeBSD 8.1-STABLE amd64
>Organization:
>Environment:
FreeBSD luna.dio.ru 8.1-STABLE FreeBSD 8.1-STABLE #10: Tue Aug 31 10:36:57 MSD 2010     root@luna.dio.ru:/usr/obj/usr/freebsd/8/src/sys/LUNA  amd64
>Description:
tunepimp links with libmpcdec when installed

ldd /usr/local/lib/tunepimp/plugins/mpc.tpp
/usr/local/lib/tunepimp/plugins/mpc.tpp:
        libtag.so.1 => /usr/local/lib/libtag.so.1 (0x800c00000)
        libmpcdec.so.5 => not found (0x0)
        libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x800d9f000)
        libcurl.so.6 => /usr/local/lib/libcurl.so.6 (0x800f99000)
        libssl.so.6 => /usr/lib/libssl.so.6 (0x8010e6000)
        libcrypto.so.6 => /lib/libcrypto.so.6 (0x801239000)
        libz.so.5 => /lib/libz.so.5 (0x8014db000)
        libofa.so.0 => /usr/local/lib/libofa.so.0 (0x8015f0000)
        libfftw3.so.5 => /usr/local/lib/libfftw3.so.5 (0x801708000)
        libmusicbrainz.so.4 => /usr/local/lib/libmusicbrainz.so.4 (0x801972000)
        libexpat.so.6 => /usr/local/lib/libexpat.so.6 (0x801aa4000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x801bc7000)
        libm.so.5 => /lib/libm.so.5 (0x801dd7000)
        libc.so.7 => /lib/libc.so.7 (0x800647000)
        libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x801ef7000)
        libthr.so.3 => /lib/libthr.so.3 (0x802005000)
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/libtunepimp/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- Makefile	11 Aug 2010 20:58:03 -0000	1.28
+++ Makefile	4 Sep 2010 17:50:10 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	libtunepimp
 PORTVERSION=	0.5.3
-PORTREVISION=	7
+PORTREVISION=	8
 PORTEPOCH=	1
 CATEGORIES=	audio
 MASTER_SITES=	http://ftp.musicbrainz.org/pub/musicbrainz/ \
@@ -24,7 +24,8 @@
 		ogg:${PORTSDIR}/audio/libogg \
 		tag:${PORTSDIR}/audio/taglib \
 		vorbis:${PORTSDIR}/audio/libvorbis \
-		ofa:${PORTSDIR}/audio/libofa
+		ofa:${PORTSDIR}/audio/libofa \
+		mpcdec:${PORTSDIR}/audio/libmpcdec
 
 CONFLICTS=	trm-0*
 USE_GMAKE=	yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->makc 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Sep 4 18:10:12 UTC 2010 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150285 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Sep 4 18:10:16 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150285 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: bsdkaffee@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/150285: audio/libtunepimp: add missing dependency on libmpcdec
Date: Sat, 4 Sep 2010 18:10:14 UT

 Maintainer of audio/libtunepimp,
 
 Please note that PR ports/150285 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150285
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Jason E. Hale" <bsdkaffee@gmail.com>
To: bug-followup@freebsd.org,
 makc@freebsd.org
Cc:  
Subject: Re: ports/150285: audio/libtunepimp: add missing dependency on libmpcdec
Date: Mon, 6 Sep 2010 04:08:56 -0400

 I approve the patch.  If libmpcdec is already installed, it will be linked to.  
 There isn't a real easy way to make it into an option, but libmpcdec is pretty 
 small.
 
 Thanks,
 Jason

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/150285: commit references a PR
Date: Mon,  6 Sep 2010 18:09:11 +0000 (UTC)

 makc        2010-09-06 18:09:02 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/libtunepimp    Makefile 
   Log:
   Add missing dependency on libmpcdec
   
   PR:             ports/150285
   Approved by:    Jason E. Hale (maintainer)
   
   Revision  Changes    Path
   1.29      +3 -2      ports/audio/libtunepimp/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->open 
State-Changed-By: makc 
State-Changed-When: Mon Sep 6 18:10:52 UTC 2010 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150285 
State-Changed-From-To: open->closed 
State-Changed-By: makc 
State-Changed-When: Mon Sep 6 18:11:13 UTC 2010 
State-Changed-Why:  
Committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150285 
>Unformatted:
