From nobody@FreeBSD.org  Tue Aug 31 11:05:19 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 39AC01065694
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Aug 2010 11:05:19 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 294CB8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Aug 2010 11:05:19 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o7VB5IB4061542
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Aug 2010 11:05:18 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o7VB5It1061541;
	Tue, 31 Aug 2010 11:05:18 GMT
	(envelope-from nobody)
Message-Id: <201008311105.o7VB5It1061541@www.freebsd.org>
Date: Tue, 31 Aug 2010 11:05:18 GMT
From: Sergey Zaykov <mail_of_sergey@mail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] comm/hylafax port BATCH portupgrading may broken installed application
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         150144
>Category:       ports
>Synopsis:       [patch] comms/hylafax port BATCH portupgrading may broken installed application
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 31 11:10:04 UTC 2010
>Closed-Date:    Mon Nov 15 09:31:11 CET 2010
>Last-Modified:  Mon Nov 15 09:31:11 CET 2010
>Originator:     Sergey Zaykov
>Release:        FreeBSD 8.0-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD acc.acc.tula.ru 8.0-RELEASE-p4 FreeBSD 8.0-RELEASE-p4 #3: Tue Jul 13 11:26:05 MSD 2

>Description:
BATCH portupgrading comm/hylafax port reinstall application with default pathes. 
If comm/hylafax port was installed for using non-default pathes, then using application is impossible:

hylafax

FATAL ERROR: /var/spool/hylafax/etc/setup.cache is missing!

The file /var/spool/hylafax/etc/setup.cache is not present.  This
probably means the machine has not been setup using the faxsetup(8C)
command.  Read the documentation on setting up HylaFAX before you
startup a server system.

>How-To-Repeat:
1. Install comm/hylafax port into non-default pathes
2. Do BATCH portupgrade
3. Try to run or restart /usr/local/etc/rc.d/hylafax
4. Get the error
>Fix:
Add IS_INTERACTIVE=YES into Makefile

Patch attached with submission follows:

--- Makefile.orig	2010-08-27 12:33:27.000000000 +0400
+++ Makefile	2010-08-31 13:55:31.000000000 +0400
@@ -43,6 +43,8 @@
 HAS_CONFIGURE=	yes
 CONFIGURE_ENV=	ENVOPTS="${CFLAGS}"
 
+IS_INTERACTIVE=	YES
+
 MAN1=	edit-faxcover.1 faxalter.1 faxcover.1 faxmail.1 faxrm.1 faxstat.1 \
 	hylafax-client.1 sendfax.1 sendpage.1 sgi2fax.1 textfmt.1
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Sep 13 06:35:15 UTC 2010 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150144 
State-Changed-From-To: open->feedback 
State-Changed-By: dinoex 
State-Changed-When: Tue Sep 14 07:27:08 CEST 2010 
State-Changed-Why:  

If you use non default path for PREFIX, 
then you must build with your PREFIX. 

Do not change any options between 
configure, build and install phase! 

This sequence will fail for almost all ports: 
make clean 
make  
make install PREFIX=/usr/opt 

This sequence will work: 
make clean 
make PREFIX=/usr/opt 
make install PREFIX=/usr/opt 

please test. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=150144 

From: =?UTF-8?B?0KHQtdGA0LPQtdC5?= <mail_of_sergey@mail.ru>
To: bug-followup@FreeBSD.org, mail_of_sergey@mail.ru
Cc:  
Subject: Re: ports/150144: [patch] comms/hylafax port BATCH portupgrading
 may broken installed application
Date: Fri, 17 Sep 2010 00:00:48 +0400

 Lets imagine this case:
 During installing I change "Directory for spooling" value from default 
 "/var/spool/hylafax" to "/export/hylafax" at HylaFAX configuration 
 parameters (part 1 of 2).
 
 Which path for "Directory for spooling" will be used when I run 
 portupgrade --batch?

Date: Wed, 15 Sep 2010 20:05:26 +0400
From: =?koi8-r?Q?=F3=C5=D2=C7=C5=CA_=E7=C5=CE=CE=C1=C4=D8=C5=D7=C9=DE?= <mail_of_sergey@mail.ru>
Reply-To: =?koi8-r?Q?=F3=C5=D2=C7=C5=CA_=E7=C5=CE=CE=C1=C4=D8=C5=D7=C9=DE?= <mail_of_sergey@mail.ru>
To: bug-followup@FreeBSD.org,
	mail_of_sergey@mail.ru
Subject: Re: ports/150144: [patch] comms/hylafax port BATCH portupgrading may broken installed application

 Lets imagine another case. 
 During installing at HylaFAX configuration parameters (part 1 of 2) I change
 "Directory for spooling" from default value "/var/spool/hylafax" to "/export/hylafax" value.
 
 Later, when BATCH portupgrade will be maked, which value of "Directory for spooling" will be used?
 
 -- 
 Serg

From: dirk.meyer@dinoex.sub.org (Dirk Meyer)
To: mail_of_sergey@mail.ru (=?UTF-8?B?0KHQtdGA0LPQtdC5?=),
        FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/150144: [patch] comms/hylafax port BATCH portupgrading
	may broken installed application
Date: Fri, 17 Sep 2010 14:40:45 +0200

 Hallo 
 
 >  Lets imagine this case:
 >  During installing I change "Directory for spooling" value from default 
 >  "/var/spool/hylafax" to "/export/hylafax" at HylaFAX configuration 
 >  parameters (part 1 of 2).
 
 This is to late.
 The binaries installed will have the old path from configiger stage build in.
   
 >  Which path for "Directory for spooling" will be used when I run 
 >  portupgrade --batch?
 
 I do not use portupgrade.
 Please set such options in /etc/make.conf or similar.
 
 kind regards Dirk
 
 - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
 - [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]
 http://people.freebsd.org/~dinoex/errorlogs/

From: =?UTF-8?B?0KHQtdGA0LPQtdC5?= <mail_of_sergey@mail.ru>
To: bug-followup@FreeBSD.org, mail_of_sergey@mail.ru
Cc:  
Subject: Re: ports/150144: [patch] comms/hylafax port BATCH portupgrading
 may broken installed application
Date: Thu, 23 Sep 2010 07:46:08 +0400

 Hello
  > Please set options in /etc/make.conf or similar.
 Ja, ja, nat&#252;rlich :)
 I make patch for setting Hylafax spool directory into HYLAFAX_SPOOL 
 environment variable.
 
 # This is a shell archive. Save it in a file, remove anything before
 # this line, and then unpack it by entering "sh file". Note, it may
 # create directories; files and directories will be owned by you and
 # have default permissions.
 #
 # This archive contains:
 #
 # spoll.patch
 #
 echo x - spoll.patch
 sed 's/^X//' >spoll.patch << '0e868e0a57b31142e0f3bc3832fd2b00'
 X--- Makefile.orig 2010-09-18 13:08:09.000000000 +0400
 X+++ Makefile 2010-09-18 13:14:55.000000000 +0400
 X@@ -69,6 +69,11 @@
 X CONFIGURE_ARGS+=--with-PAGESIZE="${PAGESIZE}"
 X .endif
 X
 X+# Redefine path for spool
 X+.if defined(HYLAFAX_SPOOL)
 X+CONFIGURE_ARGS+=--with-DIR_SPOOL="${HYLAFAX_SPOOL}"
 X+.endif
 X+
 X # Want PAM?
 X .if defined(WITHOUT_PAM)
 X CONFIGURE_ARGS+=--disable-pam
 0e868e0a57b31142e0f3bc3832fd2b00
 exit
State-Changed-From-To: feedback->closed 
State-Changed-By: dinoex 
State-Changed-When: Mon Nov 15 09:30:01 CET 2010 
State-Changed-Why:  

I already commited a similar patch: 

date: 2010/09/19 12:04:42; 
- new option HYLAFAX_SPOOL 


http://www.freebsd.org/cgi/query-pr.cgi?pr=150144 
>Unformatted:
