From amdmi3@amdmi3.ru  Mon Aug 16 19:46:57 2010
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7DE8A10656B9
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Aug 2010 19:46:57 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BA158FC1C
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Aug 2010 19:46:56 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.71)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1Ol5e3-0007xw-AQ; Mon, 16 Aug 2010 23:46:55 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id A68F2B84D;
	Mon, 16 Aug 2010 23:46:54 +0400 (MSD)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 931E6B84E; Mon, 16 Aug 2010 23:46:54 +0400 (MSD)
Message-Id: <20100816194654.931E6B84E@hades.panopticon>
Date: Mon, 16 Aug 2010 23:46:54 +0400 (MSD)
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: alepulver@FreeBSD.org
Subject: [PATCH] emulators/generator: fix make warning
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         149715
>Category:       ports
>Synopsis:       [PATCH] emulators/generator: fix make warning
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    alepulver
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 16 19:50:00 UTC 2010
>Closed-Date:    Sun Oct 10 17:12:23 UTC 2010
>Last-Modified:  Sun Oct 10 17:20:01 UTC 2010
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 8.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Fri Jul 30 02:50:28 MSD 2010
>Description:
Port's Makefile define two post-patch targets for non-i386 and non-amd64 architectures, which lead to make warning and (judging from the warning) incorrect behaviour:

"Makefile", line 71: warning: duplicate script for target "post-patch" ignored

Port maintainer (alepulver@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
ARCH=ia64 make -C/usr/ports/emulators/generator -VPORTNAME
>Fix:

--- generator-0.35_11.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/emulators/generator/Makefile,v
retrieving revision 1.29
diff -u -u -r1.29 Makefile
--- Makefile	5 Feb 2010 11:36:46 -0000	1.29
+++ Makefile	16 Aug 2010 19:43:46 -0000
@@ -37,18 +37,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${ARCH} != "amd64" && ${ARCH} != "i386"
-post-patch:
-# These architectures do not support "-minline-all-stringops"
-	@${REINPLACE_CMD} -e 's|-minline-all-stringops||g' \
-		${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT}
-.   if ${ARCH} == "alpha"
-# "-ffast-math" does not work on alpha
-	@${REINPLACE_CMD} -e 's|-ffast-math||g' \
-		${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT}
-.   endif
-.endif
-
 .if !defined(WITHOUT_OPTIMIZED_CFLAGS)
 CONFIGURE_ARGS+=--with-gcc=3
 .else
@@ -67,6 +55,16 @@
 .endif
 
 post-patch:
+.if ${ARCH} != "amd64" && ${ARCH} != "i386"
+# These architectures do not support "-minline-all-stringops"
+	@${REINPLACE_CMD} -e 's|-minline-all-stringops||g' \
+		${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT}
+.   if ${ARCH} == "alpha"
+# "-ffast-math" does not work on alpha
+	@${REINPLACE_CMD} -e 's|-ffast-math||g' \
+		${CONFIGURE_WRKSRC}/${CONFIGURE_SCRIPT}
+.   endif
+.endif
 	@${REINPLACE_CMD} -e '/%define %1 @UNDERSCORE@%1 /d' \
 		${WRKSRC}/raze/raze.asm.in
 
--- generator-0.35_11.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->alepulver 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Aug 16 19:50:10 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149715 
State-Changed-From-To: open->closed 
State-Changed-By: alepulver 
State-Changed-When: Sun Oct 10 17:12:22 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149715 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/149715: commit references a PR
Date: Sun, 10 Oct 2010 17:12:07 +0000 (UTC)

 alepulver    2010-10-10 17:12:02 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/generator  Makefile 
   Log:
   - Avoid overriding post-patch target on some architectures.
   
   PR:             ports/149715
   Submitted by:   Dmitry Marakasov <amdmi3@amdmi3.ru>
   
   Revision  Changes    Path
   1.30      +10 -12    ports/emulators/generator/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
