From glarkin@sourcehosting.net  Thu Aug 12 18:18:02 2010
Return-Path: <glarkin@sourcehosting.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 78C3F1065695
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 12 Aug 2010 18:18:02 +0000 (UTC)
	(envelope-from glarkin@sourcehosting.net)
Received: from mail1.sourcehosting.net (113901-app1.sourcehosting.net [72.32.213.11])
	by mx1.freebsd.org (Postfix) with ESMTP id 5541F8FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 12 Aug 2010 18:18:02 +0000 (UTC)
Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=cube.entropy.prv)
	by mail1.sourcehosting.net with esmtp (Exim 4.69 (FreeBSD))
	(envelope-from <glarkin@sourcehosting.net>)
	id 1OjcLj-0001DO-0h; Thu, 12 Aug 2010 14:18:01 -0400
Received: from fbsd70.entropy.prv (fbsd70.entropy.prv [192.168.1.14])
	by cube.entropy.prv (Postfix) with ESMTP
	id C10D94394E24; Thu, 12 Aug 2010 14:17:55 -0400 (EDT)
Received: from fbsd70.entropy.prv (localhost [127.0.0.1])
	by fbsd70.entropy.prv (8.14.2/8.14.2) with ESMTP id o7CIHtXW008261;
	Thu, 12 Aug 2010 14:17:55 -0400 (EDT)
	(envelope-from glarkin@fbsd70.entropy.prv)
Received: (from glarkin@localhost)
	by fbsd70.entropy.prv (8.14.2/8.14.2/Submit) id o7CIHtLE008260;
	Thu, 12 Aug 2010 14:17:55 -0400 (EDT)
	(envelope-from glarkin)
Message-Id: <201008121817.o7CIHtLE008260@fbsd70.entropy.prv>
Date: Thu, 12 Aug 2010 14:17:55 -0400 (EDT)
From: Greg Larkin <glarkin@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: hsmtkk@gmail.com
Subject: [PATCH] devel/py-unittestplus: Fails to build correctly with Python 2.4/2.5
X-Send-Pr-Version: 3.113
X-GNATS-Notify: hsmtkk@gmail.com

>Number:         149585
>Category:       ports
>Synopsis:       [PATCH] devel/py-unittestplus: Fails to build correctly with Python 2.4/2.5
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glarkin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 12 18:20:06 UTC 2010
>Closed-Date:    Wed Aug 18 09:31:41 EDT 2010
>Last-Modified:  Wed Aug 18 13:40:01 UTC 2010
>Originator:     Greg Larkin
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD fbsd70.entropy.prv 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008
>Description:
py-unittestplus fails to build correctly with Python 2.4 or 2.5 selected:

byte-compiling /usr/local/lib/python2.4/site-packages/unittestplus/tests/testcaseplus_test.py to testcaseplus_test.pyc
  File "/usr/local/lib/python2.4/site-packages/unittestplus/tests/testcaseplus_t
est.py", line 246
    except AssertionError as exc:
                           ^
SyntaxError: invalid syntax
byte-compiling /usr/local/lib/python2.4/site-packages/unittestplus/tests/__init__.py to __init__.pycwriting byte-compilation script '/tmp/tmpv3Ah4Y.py'
/usr/local/bin/python2.4 -O /tmp/tmpv3Ah4Y.py
  File "/usr/local/lib/python2.4/site-packages/unittestplus/tests/testcaseplus_test.py", line 246
    except AssertionError as exc:
                           ^
SyntaxError: invalid syntax
removing /tmp/tmpv3Ah4Y.py

Port maintainer (hsmtkk@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:

make PYTHON_VERSION=python2.4 PYTHON_DEFAULT_VERSION=python2.4 install

-or- 

make PYTHON_VERSION=python2.5 PYTHON_DEFAULT_VERSION=python2.5 install

>Fix:

--- py26-unittestplus-1.1.1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/py-unittestplus/Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- Makefile	13 Jul 2009 14:35:36 -0000	1.1
+++ Makefile	12 Aug 2010 18:14:56 -0000
@@ -15,7 +15,7 @@
 COMMENT=		Test utilities built on unittest
 
 USE_ZIP=		yes
-USE_PYTHON=		yes
+USE_PYTHON=		2.6+
 USE_PYDISTUTILS=	yes
 
 .include <bsd.port.mk>
--- py26-unittestplus-1.1.1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->glarkin 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Aug 12 18:22:48 UTC 2010 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149585 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Aug 12 18:22:54 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149585 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: hsmtkk@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/149585: [PATCH] devel/py-unittestplus: Fails to build correctly with Python 2.4/2.5
Date: Thu, 12 Aug 2010 18:22:50 UT

 Maintainer of devel/py-unittestplus,
 
 Please note that PR ports/149585 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149585
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Kouki Hashimoto <hsmtkk@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/149585: [PATCH] devel/py-unittestplus: Fails to build
 correctly with Python 2.4/2.5
Date: Sat, 14 Aug 2010 08:36:51 +0900

 To Greg;
 Thank you for your patch.
 
 To Edwin;
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > The full text of the PR can be found at:
 > =C2=A0 =C2=A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/149585
 I have tested this patch and it works correctly.
 I agree with this patch.
 Please commit it.
 
 --=20
 Kouki Hashimoto
 hsmtkk@gmail.com
State-Changed-From-To: feedback->closed 
State-Changed-By: glarkin 
State-Changed-When: Wed Aug 18 09:31:28 EDT 2010 
State-Changed-Why:  
Committed, thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149585 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/149585: commit references a PR
Date: Wed, 18 Aug 2010 13:31:08 +0000 (UTC)

 glarkin     2010-08-18 13:30:54 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/py-unittestplus Makefile 
   Log:
   - Restrict port to use Python 2.6+, since 2.4/2.5 fail to build it
     with a syntax error.
   
   PR:             ports/149585
   Submitted by:   glarkin
   Approved by:    Kouki Hashimoto <hsmtkk at gmail dot com> (maintainer)
   
   Revision  Changes    Path
   1.2       +1 -1      ports/devel/py-unittestplus/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
