From swell.k@gmail.com  Tue Aug 10 02:20:25 2010
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9BCAB106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Aug 2010 02:20:25 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 26DA18FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Aug 2010 02:20:24 +0000 (UTC)
Received: by fxm4 with SMTP id 4so476226fxm.13
        for <FreeBSD-gnats-submit@freebsd.org>; Mon, 09 Aug 2010 19:20:24 -0700 (PDT)
Received: by 10.223.126.14 with SMTP id a14mr10640026fas.44.1281406823585;
        Mon, 09 Aug 2010 19:20:23 -0700 (PDT)
Received: from localhost (spftor1.privacyfoundation.de [87.118.104.203])
        by mx.google.com with ESMTPS id m3sm2101845fai.41.2010.08.09.19.20.21
        (version=SSLv3 cipher=RC4-MD5);
        Mon, 09 Aug 2010 19:20:22 -0700 (PDT)
Message-Id: <86fwynky3v.fsf@gmail.com>
Date: Tue, 10 Aug 2010 06:20:04 +0400
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] games/wesnoth: update to 1.8.4

>Number:         149485
>Category:       ports
>Synopsis:       [patch] games/wesnoth: update to 1.8.4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    philip
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 10 02:30:01 UTC 2010
>Closed-Date:    Thu Aug 26 11:28:20 UTC 2010
>Last-Modified:  Thu Aug 26 11:30:10 UTC 2010
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
- update
- include ports/148880
- drop desktopfileutils dependency[1] but update database when it's installed
- specific directory for desktopfileutils
- allow overriding PKG_CONFIG from environ or make.conf
- sort pixmaps in plist (cosmetic)

[1] it's not mandatory
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: games/wesnoth/Makefile
===================================================================
RCS file: /a/.cvsup/ports/games/wesnoth/Makefile,v
retrieving revision 1.81
diff -u -p -r1.81 Makefile
--- games/wesnoth/Makefile	20 Jul 2010 10:57:06 -0000	1.81
+++ games/wesnoth/Makefile	10 Aug 2010 00:38:00 -0000
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	wesnoth
-PORTVERSION=	1.8.3
+PORTVERSION=	1.8.4
 CATEGORIES=	games
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}-${PORTVERSION:R}/${PORTNAME}-${PORTVERSION} \
 		http://files.wesnoth.org/
@@ -23,7 +23,7 @@ LICENSE_FILE=	${WRKSRC}/COPYING
 CONFLICTS=	wesnoth-devel-[0-9]*
 
 USE_SDL=	image mixer net ttf
-USE_GNOME=	desktopfileutils gnometarget pango
+USE_GNOME=	gnometarget pango
 USE_GMAKE=	yes
 MAKE_JOBS_SAFE=	yes
 WANT_GNOME=	yes
@@ -32,7 +32,7 @@ USE_LUA=	5.1
 USE_AUTOTOOLS=	aclocal:110 autoheader:262 automake:110 autoconf:262
 ACLOCAL_ARGS=	-Im4
 AUTOMAKE_ARGS=	--add-missing --copy
-CONFIGURE_ENV=	PKG_CONFIG=${LOCALBASE}/bin/pkg-config \
+CONFIGURE_ENV=	PKG_CONFIG="${PKG_CONFIG}" \
 		LDFLAGS="${LDFLAGS}"
 CONFIGURE_ARGS=	--localstatedir=/var \
 		--with-boost=${LOCALBASE} \
@@ -40,6 +40,7 @@ CONFIGURE_ARGS=	--localstatedir=/var \
 		--with-libiconv-prefix=${LOCALBASE} \
 		--with-libintl-prefix=${LOCALBASE} \
 		--with-localedir=${PREFIX}/share/locale
+PKG_CONFIG?=	${LOCALBASE}/bin/pkg-config
 
 MANLANG=	"" cs de en_GB es et fi fr gl hu it ja lt pl pt_BR sk \
 		sr sr@ijekavian sr@ijekavianlatin sr@latin tr zh_CN zh_TW
@@ -54,7 +55,6 @@ OPTIONS=	BWMON	 "Enable bandwidth monito
 		EDITOR	 "Enable map editor"		On \
 		FRIBIDI	 "Enable bidirectional support"	On \
 		LOWMEM	 "Reduce memory usage (disables animations)" Off \
-		NLS	 "Enable localization"		On \
 		NOTIFY	 "Enable desktop notifications"	On \
 		POOLALLOC "Use wesnoth own memory allocator" Off \
 		PYTHON	 "Enable python developer tools" On \
@@ -194,10 +194,6 @@ PLIST_SUB+=		TOOLS=""
 CONFIGURE_ARGS+=	--docdir=${WRKDIR}/docs
 .endif
 
-.if (defined(WITH_CAMPAIGN) || defined(WITH_SERVER) || defined(WITH_TOOLS)) && defined(WITHOUT_NLS)
-BROKEN=		you need NLS support for `campaignd' or `wesnothd' or tools to link against gettext
-.endif
-
 .if defined(NOPORTDATA)
 IGNORE=		game data is required, undefine NOPORTDATA
 .endif
@@ -207,7 +203,7 @@ post-patch:	.SILENT
 		-e 's|png_error_ptr_NULL|NULL|g' \
 		${WRKSRC}/src/tools/exploder_utils.cpp
 
-post-install:	.SILENT
-	-update-desktop-database
+post-install:
+	-update-desktop-database ${PREFIX}/share/applications
 
 .include <bsd.port.post.mk>
Index: games/wesnoth/distinfo
===================================================================
RCS file: /a/.cvsup/ports/games/wesnoth/distinfo,v
retrieving revision 1.51
diff -u -p -r1.51 distinfo
--- games/wesnoth/distinfo	20 Jul 2010 10:57:06 -0000	1.51
+++ games/wesnoth/distinfo	10 Aug 2010 00:45:32 -0000
@@ -1,3 +1,3 @@
-MD5 (wesnoth-1.8.3.tar.bz2) = 62ba3a4938d3e722797cfbe9450d3e36
-SHA256 (wesnoth-1.8.3.tar.bz2) = 985d40ff04cf95bb6f8abb3353ec955c3286a6f9edb1bd29b6f26f8b12280928
-SIZE (wesnoth-1.8.3.tar.bz2) = 298923248
+MD5 (wesnoth-1.8.4.tar.bz2) = 2dce83f835ecce1d505ea60e46b7356f
+SHA256 (wesnoth-1.8.4.tar.bz2) = af29ddf40f83ee016972d6edb8761d7323f8ed5d6bf15005659bff4fd7190eb9
+SIZE (wesnoth-1.8.4.tar.bz2) = 300557790
Index: games/wesnoth/pkg-plist
===================================================================
RCS file: /a/.cvsup/ports/games/wesnoth/pkg-plist,v
retrieving revision 1.57
diff -u -p -r1.57 pkg-plist
--- games/wesnoth/pkg-plist	20 Jul 2010 10:57:06 -0000	1.57
+++ games/wesnoth/pkg-plist	27 Jul 2010 04:37:45 -0000
@@ -34,8 +34,6 @@ bin/wesnoth
 %%PYTHON%%%%PYTHON_SITELIBDIR%%/wesnoth/wmltools.pyo
 share/applications/wesnoth.desktop
 %%EDITOR%%share/applications/wesnoth_editor.desktop
-share/pixmaps/wesnoth-icon.png
-%%EDITOR%%share/pixmaps/wesnoth_editor-icon.png
 %%NLS%%share/locale/af/LC_MESSAGES/wesnoth-anl.mo
 %%NLS%%share/locale/af/LC_MESSAGES/wesnoth-aoi.mo
 %%NLS%%share/locale/af/LC_MESSAGES/wesnoth-did.mo
@@ -1232,6 +1230,8 @@ share/pixmaps/wesnoth-icon.png
 %%NLS%%share/locale/zh_TW/LC_MESSAGES/wesnoth-units.mo
 %%NLS%%share/locale/zh_TW/LC_MESSAGES/wesnoth-utbs.mo
 %%NLS%%share/locale/zh_TW/LC_MESSAGES/wesnoth.mo
+share/pixmaps/wesnoth-icon.png
+%%EDITOR%%share/pixmaps/wesnoth_editor-icon.png
 %%PYTHON%%@dirrm %%PYTHON_SITELIBDIR%%/wesnoth
 @dirrmtry man/af/man6
 @dirrmtry man/af
@@ -1358,6 +1358,6 @@ share/pixmaps/wesnoth-icon.png
 %%NLS%%@dirrmtry share/locale/sr@latin
 %%NLS%%@dirrmtry share/locale/tl/LC_MESSAGES
 %%NLS%%@dirrmtry share/locale/tl
+@exec %%LOCALBASE%%/bin/update-desktop-database %D/share/applications 2>/dev/null || true
+@unexec %%LOCALBASE%%/bin/update-desktop-database %D/share/applications 2>/dev/null || true
 %%SERVER%%@unexec rmdir /var/run/wesnothd 2>/dev/null || echo "If you are permanently removing this port, you should do a 'rm -rf /var/run/wesnothd' to remove it." | fmt
-@exec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
-@unexec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
Index: games/wesnoth/files/patch-configure.ac
===================================================================
RCS file: /a/.cvsup/ports/games/wesnoth/files/patch-configure.ac,v
retrieving revision 1.2
diff -u -p -r1.2 patch-configure.ac
--- games/wesnoth/files/patch-configure.ac	20 Jul 2010 10:57:07 -0000	1.2
+++ games/wesnoth/files/patch-configure.ac	10 Aug 2010 00:50:38 -0000
@@ -9,15 +9,3 @@
  test_build=yes
  if test $svn_in_version = 0 
  then
-@@ -428,9 +428,9 @@ if test "x$fribidi" != "xno"; then
- 					AC_MSG_RESULT(no)
- 				])
- 		])
--	AM_CONDITIONAL([FRIBIDI], [test "x$fribidifound" = xyes])
--	AM_CONDITIONAL([OLD_FRIBIDI], [test "x$oldfribidi" = xyes])
- fi
-+AM_CONDITIONAL([FRIBIDI], [test "x$fribidifound" = xyes])
-+AM_CONDITIONAL([OLD_FRIBIDI], [test "x$oldfribidi" = xyes])
- 
- # python
- AC_PATH_PROG(PYTHON, python, none)
Index: games/wesnoth/files/patch-src-gettext.cpp
===================================================================
RCS file: games/wesnoth/files/patch-src-gettext.cpp
diff -N games/wesnoth/files/patch-src-gettext.cpp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ games/wesnoth/files/patch-src-gettext.cpp	23 Jul 2010 12:44:38 -0000
@@ -0,0 +1,15 @@
+--- src/gettext.cpp~
++++ src/gettext.cpp
+@@ -18,6 +18,12 @@
+ 
+ #include <cstring>
+ 
++#ifndef ENABLE_NLS
++char *textdomain (const char *domainname) {
++  return "dummy";
++}
++#endif
++
+ char const *egettext(char const *msgid)
+ {
+ 	return msgid[0] == '\0' ? msgid : gettext(msgid);
Index: games/wesnoth/files/patch-src-gettext.hpp
===================================================================
RCS file: games/wesnoth/files/patch-src-gettext.hpp
diff -N games/wesnoth/files/patch-src-gettext.hpp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ games/wesnoth/files/patch-src-gettext.hpp	10 Aug 2010 01:34:17 -0000
@@ -0,0 +1,25 @@
+--- src/gettext.hpp~
++++ src/gettext.hpp
+@@ -35,7 +35,21 @@
+ 
+ // gettext-related declarations
+ 
+-#include <libintl.h>
++#include "wesconfig.h"
++
++#ifdef ENABLE_NLS
++# include <libintl.h>
++#else
++# define bind_textdomain_codeset(Domain, Codeset) "C"
++# define bindtextdomain(Domain, Directory) "/nonexistent"
++# define gettext(String) gettext_noop(String)
++# define ngettext(Singular, Plural, Number) gettext_noop(Number == 1 ? Singular : Plural)
++# define dgettext(Domain, String) gettext_noop(String)
++# define dngettext(Domain, Singular, Plural, Number) gettext_noop(Number == 1 ? Singular : Plural)
++# define dcgettext(Domain, String, Category) gettext_noop(String)
++# define dcngettext(Domain, Singular, Plural, Number, Category) gettext_noop(Number == 1 ? Singular : Plural)
++char *textdomain (const char *domainname);
++#endif
+ 
+ const char* egettext(const char*);
+ const char* sgettext(const char*);
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->philip 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Aug 10 02:30:45 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149485 

From: Paul Shepel <tacid@tacid.kiev.ua>
To: bug-followup@FreeBSD.org, swell.k@gmail.com
Cc:  
Subject: Re: ports/149485: [patch] games/wesnoth: update to 1.8.4
Date: Tue, 10 Aug 2010 20:04:56 +0300

 I approve. New version compiles and works for me with this update patch

From: Anonymous <swell.k@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/149485: [patch] games/wesnoth: update to 1.8.4
Date: Wed, 25 Aug 2010 10:31:27 +0400

 Reduce diff[1] with ports/149899.
 
 [1] this is how it looks - http://pastebin.com/HZgUJHDQ
 
 --- b.diff begins here ---
 Index: games/wesnoth/files/patch-m4-boost.m4
 ===================================================================
 RCS file: games/wesnoth/files/patch-m4-boost.m4
 diff -N games/wesnoth/files/patch-m4-boost.m4
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ games/wesnoth/files/patch-m4-boost.m4	23 Aug 2010 03:12:39 -0000
 @@ -0,0 +1,11 @@
 +--- m4/boost.m4~	2010-05-27 11:37:13.000000000 +0400
 ++++ m4/boost.m4	2010-08-23 07:12:17.014432212 +0400
 +@@ -729,7 +729,7 @@ AC_CACHE_CHECK([for the flags needed to 
 +   esac
 +   # Generate the test file.
 +   AC_LANG_CONFTEST([AC_LANG_PROGRAM([#include <pthread.h>],
 +-    [pthread_t th; pthread_join(th, 0);
 ++    [pthread_t th=NULL; pthread_join(th, 0);
 +     pthread_attr_init(0); pthread_cleanup_push(0, 0);
 +     pthread_create(0,0,0,0); pthread_cleanup_pop(0);])])
 +   for boost_pthread_flag in '' $boost_pthread_flags; do
 Index: games/wesnoth/files/patch-src-tests-main.cpp
 ===================================================================
 RCS file: games/wesnoth/files/patch-src-tests-main.cpp
 diff -N games/wesnoth/files/patch-src-tests-main.cpp
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ games/wesnoth/files/patch-src-tests-main.cpp	25 Aug 2010 05:48:44 -0000
 @@ -0,0 +1,10 @@
 +--- src/tests/main.cpp~
 ++++ src/tests/main.cpp
 +@@ -15,6 +15,7 @@
 + #define GETTEXT_DOMAIN "wesnoth-test"
 + 
 + 
 ++#define BOOST_TEST_DYN_LINK
 + #define BOOST_TEST_MODULE wesnoth unit tests master suite
 + #include <boost/test/unit_test.hpp>
 + #include <boost/test/unit_test_monitor.hpp>
 --- b.diff ends here ---
State-Changed-From-To: open->closed 
State-Changed-By: philip 
State-Changed-When: Thu Aug 26 11:28:19 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149485 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/149485: commit references a PR
Date: Thu, 26 Aug 2010 11:25:43 +0000 (UTC)

 philip      2010-08-26 11:25:34 UTC
 
   FreeBSD ports repository
 
   Modified files:
     games/wesnoth        Makefile distinfo pkg-plist 
     games/wesnoth/files  patch-configure.ac patch-src-gettext.cpp 
                          patch-src-gettext.hpp 
   Log:
   Update to 1.8.4
   
   - drop desktopfileutils dependency[1] but update database when it's installed
   - specific directory for desktopfileutils
   - allow overriding PKG_CONFIG from environ or make.conf
   - sort pixmaps in plist (cosmetic)
   
   [1] it's not mandatory
   
   PR:             ports/149485
   Submitted by:   Anonymous <swell.k@gmail.com>
   
   Revision  Changes    Path
   1.84      +6 -6      ports/games/wesnoth/Makefile
   1.52      +3 -3      ports/games/wesnoth/distinfo
   1.3       +0 -12     ports/games/wesnoth/files/patch-configure.ac
   1.2       +15 -0     ports/games/wesnoth/files/patch-src-gettext.cpp
   1.2       +25 -0     ports/games/wesnoth/files/patch-src-gettext.hpp
   1.58      +4 -4      ports/games/wesnoth/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/149485: commit references a PR
Date: Thu, 26 Aug 2010 11:28:13 +0000 (UTC)

 philip      2010-08-26 11:28:04 UTC
 
   FreeBSD ports repository
 
   Added files:
     games/wesnoth/files  patch-m4-boost.m4 
                          patch-src-tests-main.cpp 
   Log:
   Reduce diff with ports/149899.
   
   PR:             ports/149485
   Submitted by:   Anonymous <swell.k@gmail.com>
   
   Revision  Changes    Path
   1.1       +11 -0     ports/games/wesnoth/files/patch-m4-boost.m4 (new)
   1.1       +10 -0     ports/games/wesnoth/files/patch-src-tests-main.cpp (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
