From nobody@FreeBSD.org  Sun Aug  1 12:51:35 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4DC761065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  1 Aug 2010 12:51:35 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C3638FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  1 Aug 2010 12:51:35 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o71CpZt4071215
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 1 Aug 2010 12:51:35 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o71CpZYL071214;
	Sun, 1 Aug 2010 12:51:35 GMT
	(envelope-from nobody)
Message-Id: <201008011251.o71CpZYL071214@www.freebsd.org>
Date: Sun, 1 Aug 2010 12:51:35 GMT
From: Anselm Strauss <amsibamsi@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Samba rc script gives wrong output format for rcvar command
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         149177
>Category:       ports
>Synopsis:       net/samba34: rc script gives wrong output format for rcvar command
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    timur
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 01 13:00:10 UTC 2010
>Closed-Date:    Wed Apr 13 00:22:10 UTC 2011
>Last-Modified:  Wed Apr 13 00:22:10 UTC 2011
>Originator:     Anselm Strauss
>Release:        8.1-RELEASE
>Organization:
-
>Environment:
FreeBSD hulk.l.ttyv0.net 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010     root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Port: net/samba34

/usr/loca/etc/rc.d/samba rcvar gives:

# samba
$samba_enable=YES
# nmbd
#
nmbd_enable="YES"
#   (default: "")

# smbd
#
nmbd_enable="YES"
#   (default: "")
smbd_enable="YES"
#   (default: "")

Compared to /etc/rc.d/sshd rcvar:

# sshd
#
sshd_enable="YES"
#   (default: "")

The output from samba uses an initial dollar sign and no double quotes in the variable name. This is different from all other rc scripts I've seen and is annoying when automatically parsing output from the command.
>How-To-Repeat:
Execute "/usr/local/etc/rc.d/samba rcvar" in a shell.
>Fix:
Patch /usr/local/etc/rc.d/samba.

Patch attached with submission follows:

*** /usr/local/etc/rc.d/samba	Sun Aug  1 14:27:05 2010
--- /usr/local/etc/rc.d/samba.new	Sun Aug  1 14:25:24 2010
***************
*** 102,113 ****
      unset "${rc_arg}_cmd" "${rc_arg}_precmd" "${rc_arg}_postcmd"
      # Check master variable
      echo "# ${name}"
      if [ -n "${rcvar}" ]; then
  	# Use original configured value
  	if checkyesno "real_${rcvar}"; then
! 	    echo "\$${rcvar}=YES"
  	else
! 	    echo "\$${rcvar}=NO"
  	fi
      fi
      # Check dependent variables
--- 102,114 ----
      unset "${rc_arg}_cmd" "${rc_arg}_precmd" "${rc_arg}_postcmd"
      # Check master variable
      echo "# ${name}"
+     echo "#"
      if [ -n "${rcvar}" ]; then
  	# Use original configured value
  	if checkyesno "real_${rcvar}"; then
! 	    echo "${rcvar}=\"YES\""
  	else
! 	    echo "${rcvar}=\"NO\""
  	fi
      fi
      # Check dependent variables


>Release-Note:
>Audit-Trail:

From: Anselm Strauss <amsibamsi@gmail.com>
To: bug-followup@FreeBSD.org, amsibamsi@gmail.com
Cc:  
Subject: Re: ports/149177: Samba rc script gives wrong output format for rcvar
 command
Date: Sun, 01 Aug 2010 15:11:39 +0200

 Also, I'm not sure if the multi rcvar output is a good idea. Shouldn't
 this be split up into separate rc scripts with dependencies and/or virtuals?
Responsible-Changed-From-To: freebsd-ports-bugs->timur 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Aug 2 02:26:21 UTC 2010 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149177 
State-Changed-From-To: open->closed 
State-Changed-By: timur 
State-Changed-When: Wed Apr 13 00:22:09 UTC 2011 
State-Changed-Why:  
Current RC-script gives output compatiable with current rc.subr. 
Unfortunatelly, it's a subject to changes, as it already happened once. 
Hope we'll stay in sync. Regards, timur. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149177 
>Unformatted:
