From swell.k@gmail.com  Sat Jul 31 05:38:48 2010
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 55D09106567A
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 31 Jul 2010 05:38:48 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id E0E958FC19
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 31 Jul 2010 05:38:47 +0000 (UTC)
Received: by wyj26 with SMTP id 26so2196188wyj.13
        for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Jul 2010 22:38:46 -0700 (PDT)
Received: by 10.227.154.196 with SMTP id p4mr2515181wbw.195.1280554726063;
        Fri, 30 Jul 2010 22:38:46 -0700 (PDT)
Received: from localhost ([109.169.29.56])
        by mx.google.com with ESMTPS id a1sm2659391wbb.8.2010.07.30.22.38.41
        (version=SSLv3 cipher=RC4-MD5);
        Fri, 30 Jul 2010 22:38:45 -0700 (PDT)
Message-Id: <86ocdodxd0.fsf@gmail.com>
Date: Sat, 31 Jul 2010 09:38:35 +0400
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] security/sudo: obey STRIP, makes WITH_DEBUG useful

>Number:         149135
>Category:       ports
>Synopsis:       [patch] security/sudo: obey STRIP, makes WITH_DEBUG useful
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 31 05:40:03 UTC 2010
>Closed-Date:    Sun Aug 22 12:32:38 UTC 2010
>Last-Modified:  Sun Aug 22 12:40:01 UTC 2010
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: security/sudo/Makefile
===================================================================
RCS file: /a/.cvsup/ports/security/sudo/Makefile,v
retrieving revision 1.110
diff -u -p -r1.110 Makefile
--- security/sudo/Makefile	5 Jul 2010 16:34:01 -0000	1.110
+++ security/sudo/Makefile	31 Jul 2010 05:28:43 -0000
@@ -84,6 +84,9 @@ MAN5+=		sudoers.5
 MAN8=		sudo.8 visudo.8 sudoreplay.8
 MLINKS=		sudo.8 sudoedit.8
 
+post-patch:	.SILENT
+	${REINPLACE_CMD} '/$$(INSTALL)/s/-s[[:space:]]/${STRIP} /' ${WRKSRC}/Makefile.in
+
 post-install:
 	${INSTALL_DATA} ${WRKSRC}/sudoers ${PREFIX}/etc/sudoers.default
 	${INSTALL_DATA} ${FILESDIR}/pam.conf ${PREFIX}/etc/pam.d/sudo.default
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jul 31 05:40:53 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149135 

From: Wesley Shields <wxs@FreeBSD.org>
To: Anonymous <swell.k@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/149135: [patch] security/sudo: obey STRIP, makes
 WITH_DEBUG useful
Date: Sat, 21 Aug 2010 22:01:56 -0400

 This patch has no effect on the latest port.
 
 -- WXS

From: Anonymous <swell.k@gmail.com>
To: Wesley Shields <wxs@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/149135: [patch] security/sudo: obey STRIP, makes WITH_DEBUG useful
Date: Sun, 22 Aug 2010 08:00:38 +0400

 Now it's the other way around - not stripped by default.
 
 --- a.diff begins here ---
 Index: security/sudo/Makefile
 ===================================================================
 RCS file: /a/.cvsup/ports/security/sudo/Makefile,v
 retrieving revision 1.113
 diff -u -p -r1.113 Makefile
 --- security/sudo/Makefile	22 Aug 2010 01:58:33 -0000	1.113
 +++ security/sudo/Makefile	22 Aug 2010 03:55:08 -0000
 @@ -85,6 +85,8 @@ MAN8=		sudo.8 visudo.8 sudoreplay.8
  MLINKS=		sudo.8 sudoedit.8
  
  post-patch:
 +	@${REINPLACE_CMD} '/install-binaries:/,/^$$/s/$$(INSTALL)/& ${STRIP}/' \
 +		${WRKSRC}/Makefile.in
  .if defined(NOPORTDOCS)
  	@${REINPLACE_CMD} -e 's/$$(DESTDIR)$$(sudoersdir) $$(DESTDIR)$$(docdir)/$$(DESTDIR)$$(sudoersdir)/' \
  		${WRKSRC}/Makefile.in
 --- a.diff ends here ---
State-Changed-From-To: open->closed 
State-Changed-By: wxs 
State-Changed-When: Sun Aug 22 12:32:37 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149135 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/149135: commit references a PR
Date: Sun, 22 Aug 2010 12:32:36 +0000 (UTC)

 wxs         2010-08-22 12:32:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/sudo        Makefile 
   Log:
   Strip the binaries by default. No need to bump PORTREVISION for such a
   minor change.
   
   PR:             ports/149135
   Submitted by:   Anonymous <swell.k@gmail.com>
   
   Revision  Changes    Path
   1.114     +2 -0      ports/security/sudo/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
