From glarkin@sourcehosting.net  Fri Jul 30 18:17:56 2010
Return-Path: <glarkin@sourcehosting.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 56ECE106567E
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Jul 2010 18:17:56 +0000 (UTC)
	(envelope-from glarkin@sourcehosting.net)
Received: from mail1.sourcehosting.net (113901-app1.sourcehosting.net [72.32.213.11])
	by mx1.freebsd.org (Postfix) with ESMTP id 322D58FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Jul 2010 18:17:56 +0000 (UTC)
Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=cube.entropy.prv)
	by mail1.sourcehosting.net with esmtp (Exim 4.69 (FreeBSD))
	(envelope-from <glarkin@sourcehosting.net>)
	id 1Oeu9Y-0002Ru-02; Fri, 30 Jul 2010 14:17:54 -0400
Received: from fbsd70.entropy.prv (fbsd70.entropy.prv [192.168.1.14])
	by cube.entropy.prv (Postfix) with ESMTP
	id 53B3D431A2A8; Fri, 30 Jul 2010 14:17:52 -0400 (EDT)
Received: from fbsd70.entropy.prv (localhost [127.0.0.1])
	by fbsd70.entropy.prv (8.14.2/8.14.2) with ESMTP id o6UIHqfZ067189;
	Fri, 30 Jul 2010 14:17:52 -0400 (EDT)
	(envelope-from glarkin@fbsd70.entropy.prv)
Received: (from glarkin@localhost)
	by fbsd70.entropy.prv (8.14.2/8.14.2/Submit) id o6UIHqrJ067188;
	Fri, 30 Jul 2010 14:17:52 -0400 (EDT)
	(envelope-from glarkin)
Message-Id: <201007301817.o6UIHqrJ067188@fbsd70.entropy.prv>
Date: Fri, 30 Jul 2010 14:17:52 -0400 (EDT)
From: Greg Larkin <glarkin@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: duchateau.olivier@gmail.com
Subject: [PATCH] audio/py-shout: restrict Python dependency to 2.5+
X-Send-Pr-Version: 3.113
X-GNATS-Notify: duchateau.olivier@gmail.com

>Number:         149122
>Category:       ports
>Synopsis:       [PATCH] audio/py-shout: restrict Python dependency to 2.5+
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-python
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 30 18:20:05 UTC 2010
>Closed-Date:    Wed Aug 18 10:06:56 EDT 2010
>Last-Modified:  Wed Aug 18 14:10:01 UTC 2010
>Originator:     Greg Larkin
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD fbsd70.entropy.prv 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:52 UTC 2008
>Description:
The audio/py-shout build fails with the following compiler error when
Python 2.4 is forced as the default Python version:

# make PYTHON_VERSION=python2.4 PYTHON_DEFAULT_VERSION=python2.4
===>  WARNING: Vulnerability database out of date, checking anyway
===>  License check disabled, port has not defined LICENSE
===>  Extracting for py24-shout-0.2.1
=> MD5 Checksum OK for shout-python-0.2.1.tar.gz.
=> SHA256 Checksum OK for shout-python-0.2.1.tar.gz.
===>  Patching for py24-shout-0.2.1
===>   py24-shout-0.2.1 depends on file: /usr/local/bin/python2.4 - found
===>   py24-shout-0.2.1 depends on shared library: shout.5 - found
===>  Configuring for py24-shout-0.2.1
running config
===>  Building for py24-shout-0.2.1
running build
running build_ext
building 'shout' extension
creating build
creating build/temp.freebsd-7.0-RELEASE-i386-2.4
cc -fno-strict-aliasing -DNDEBUG -O2 -fno-strict-aliasing -pipe -D__wchar_t=wchar_t -DTHREAD_STACK_SIZE=0x20000 -O2 -fno-strict-aliasing -pipe -fPIC -I/usr/local/include -I/usr/local/include/speex -I/usr/local/include/python2.4 -c shout.c -o build/temp.freebsd-7.0-RELEASE-i386-2.4/shout.o -D_THREAD_SAFE
shout.c: In function 'pshoutobj_set_metadata':
shout.c:442: error: 'Py_ssize_t' undeclared (first use in this function)
shout.c:442: error: (Each undeclared identifier is reported only once
shout.c:442: error: for each function it appears in.)
shout.c:442: error: expected ';' before 'i'
shout.c:453: error: 'i' undeclared (first use in this function)
shout.c: In function 'pshoutobj_set_audio_info':
shout.c:580: error: 'Py_ssize_t' undeclared (first use in this function)
shout.c:580: error: expected ';' before 'i'
shout.c:588: error: 'i' undeclared (first use in this function)
error: command 'cc' failed with exit status 1
*** Error code 1

Stop in /usr/home/glarkin/FreeBSD/ports/audio/py-shout.

The Py_ssize_t type is not supported in Python 2.4, so change the
USE_PYTHON line in the port Makefile to only allow 2.5+.

Port maintainer (duchateau.olivier@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- py-shout-0.2.1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/py-shout/Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- Makefile	17 Oct 2009 07:10:22 -0000	1.1
+++ Makefile	30 Jul 2010 18:14:45 -0000
@@ -19,7 +19,7 @@
 
 EXAMPLESDIR=	${PREFIX}/share/examples/py-${PORTNAME}
 
-USE_PYTHON=		yes
+USE_PYTHON=		2.5+
 USE_PYDISTUTILS=	yes
 PYDISTUTILS_PKGNAME=	${PORTNAME}-python
 
--- py-shout-0.2.1.patch ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-python 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 30 18:20:15 UTC 2010 
Responsible-Changed-Why:  
freebsd-python@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149122 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jul 30 18:20:22 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149122 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: duchateau.olivier@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/149122: [PATCH] audio/py-shout: restrict Python dependency to 2.5+
Date: Fri, 30 Jul 2010 18:20:19 UT

 Maintainer of audio/py-shout,
 
 Please note that PR ports/149122 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/149122
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: glarkin 
State-Changed-When: Wed Aug 18 10:06:42 EDT 2010 
State-Changed-Why:  
Committed after maintainer timeout. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=149122 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/149122: commit references a PR
Date: Wed, 18 Aug 2010 14:06:43 +0000 (UTC)

 glarkin     2010-08-18 14:06:34 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/py-shout       Makefile 
   Log:
   - Restrict Python version to 2.5+ to avoid compilation errors
   
   PR:             ports/149122
   Submitted by:   glarkin
   Approved by:    duchateau.olivier@gmail.com (maintainer; timeout - 20 days)
   
   Revision  Changes    Path
   1.2       +1 -1      ports/audio/py-shout/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
