From danger@alice.syscare.sk  Fri Jul 23 14:31:25 2010
Return-Path: <danger@alice.syscare.sk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B43E9106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 23 Jul 2010 14:31:20 +0000 (UTC)
	(envelope-from danger@alice.syscare.sk)
Received: from services.syscare.sk (services.syscare.sk [188.40.39.36])
	by mx1.freebsd.org (Postfix) with ESMTP id 6E4418FC30
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 23 Jul 2010 14:31:19 +0000 (UTC)
Received: from services.syscare.sk (services [188.40.39.36])
	by services.syscare.sk (Postfix) with ESMTP id 2CEC7369B1
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 23 Jul 2010 16:31:19 +0200 (CEST)
Received: from services.syscare.sk ([188.40.39.36])
	by services.syscare.sk (services.rulez.sk [188.40.39.36]) (amavisd-new, port 10024)
	with ESMTP id mkZKE-KCXgRE for <FreeBSD-gnats-submit@freebsd.org>;
	Fri, 23 Jul 2010 16:31:17 +0200 (CEST)
Received: from alice.syscare.sk (services [188.40.39.36])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by services.syscare.sk (Postfix) with ESMTPS id 11A85369A6
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 23 Jul 2010 16:31:17 +0200 (CEST)
Received: (from root@localhost)
	by alice.syscare.sk (8.14.4/8.14.4/Submit) id o6NEVFq0094292;
	Fri, 23 Jul 2010 16:31:15 +0200 (CEST)
	(envelope-from danger)
Message-Id: <201007231431.o6NEVFq0094292@alice.syscare.sk>
Date: Fri, 23 Jul 2010 16:31:15 +0200 (CEST)
From: Daniel Gerzo <danger@freebsd.org>
Reply-To: Daniel Gerzo <danger@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] net-p2p/dcd - set the correct signal for sig_stop
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         148867
>Category:       ports
>Synopsis:       [patch] net-p2p/dcd - set the correct signal for sig_stop
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    az
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 23 14:40:03 UTC 2010
>Closed-Date:    Tue Jul 27 19:35:03 UTC 2010
>Last-Modified:  Tue Jul 27 19:40:01 UTC 2010
>Originator:     Daniel Gerzo
>Release:        FreeBSD 8.0-STABLE amd64
>Organization:
SysCare s. r. o.
>Environment:
>Description:
in /etc/rc.subr, we have _run_rc_killcmd() function, which does this:
_cmd="kill -$1 $rc_pid".

When we set sig_stop to -KILL, the kill command receives wrong signal
(i.e. "--KILL") so it silently sends a wrong signal.
>How-To-Repeat:
>Fix:

--- dcd.sh.in.diff begins here ---
--- dcd.sh.in.orig	2010-07-23 16:26:44.089552994 +0200
+++ dcd.sh.in	2010-07-23 16:26:58.105356378 +0200
@@ -16,7 +16,7 @@
 rcvar=${name}_enable
 
 command=%%PREFIX%%/sbin/dcd
-sig_stop=-KILL 
+sig_stop=KILL 
 stop_cmd=stop_cmd
 
 load_rc_config $name
--- dcd.sh.in.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->az 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 23 14:41:39 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148867 
State-Changed-From-To: open->closed 
State-Changed-By: danger 
State-Changed-When: Tue Jul 27 19:34:42 UTC 2010 
State-Changed-Why:  
- commited upon az's request 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148867 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/148867: commit references a PR
Date: Tue, 27 Jul 2010 19:34:43 +0000 (UTC)

 danger      2010-07-27 19:34:34 UTC
 
   FreeBSD ports repository (doc committer)
 
   Modified files:
     net-p2p/dcd          Makefile 
     net-p2p/dcd/files    dcd.sh.in 
   Log:
   - fix the handling of sig_stop signal in the rc.d script
   
   PR:             148867
   Submitted by:   danger
   Approved by:    az (maintainer) via private email
   
   Revision  Changes    Path
   1.13      +1 -0      ports/net-p2p/dcd/Makefile
   1.5       +1 -1      ports/net-p2p/dcd/files/dcd.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
