From nobody@FreeBSD.org  Tue Jul 13 18:35:43 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 22C2F106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jul 2010 18:35:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id ECCBB8FC22
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jul 2010 18:35:42 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6DIZg4u039596
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jul 2010 18:35:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o6DIZgp9039595;
	Tue, 13 Jul 2010 18:35:42 GMT
	(envelope-from nobody)
Message-Id: <201007131835.o6DIZgp9039595@www.freebsd.org>
Date: Tue, 13 Jul 2010 18:35:42 GMT
From: David DEMELIER <demelier.david@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: x11-wm/fluxbox with options
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         148578
>Category:       ports
>Synopsis:       x11-wm/fluxbox with options
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    beat
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 13 18:40:02 UTC 2010
>Closed-Date:    Sun Jul 25 08:14:09 UTC 2010
>Last-Modified:  Sun Jul 25 08:20:02 UTC 2010
>Originator:     David DEMELIER
>Release:        8.1-RC2
>Organization:
>Environment:
FreeBSD Melon.malikania.fr 8.1-RC2 FreeBSD 8.1-RC2 #3: Mon Jul  5 13:55:31 CEST 2010     root@Melon.malikania.fr:/usr/obj/usr/src/sys/Melon  amd64
>Description:
Hi, 

Just because the options infrastructure is better, I would like to switch old ports that use KNOBS to options framework.
>How-To-Repeat:

>Fix:
--- /home/markand/fluxbox/Makefile.orig	2010-07-13 20:15:59.000000000 +0200
+++ /home/markand/fluxbox/Makefile	2010-07-13 20:24:39.000000000 +0200
@@ -30,6 +30,17 @@
 MAN5=		fluxbox-keys.5
 DOCSVERSION=	20060629
 
+OPTIONS+=	DOCHTML	"Enables HTML documentation" off \
+		DOCPDF	"Enables PDF documentation" off \
+		DEBUG	"Enables debugging support" off \
+		NLS	"Native Language Support via gettext utilities" on \
+		REMEMBER	"Enables fluxbox remember attributes" on \
+		SLIT	"Enables fluxbox slit" on \
+		TOOLBAR	"Enables fluxbox toolbar" on \
+		XRENDER	"Xrender (transparent) support" on \
+		XINERAMA "Enable Xinerama support" on
+
+
 .if defined(WITH_DEBUG)
 CONFIGURE_ARGS+=	--enable-debug
 .endif
@@ -113,44 +124,6 @@
 CONFIGURE_ARGS+=	--disable-gnome
 .endif
 
-pre-everything::
-	@${ECHO_CMD} ""
-	@${ECHO_CMD} "Definable build options"
-	@${ECHO_CMD} "-----------------------"
-.if !defined(WITH_DEBUG)
-	@${ECHO_CMD} "WITH_DEBUG=yes		Build with debugging symbols"
-.endif
-.if !defined(WITH_DOCHTML)
-	@${ECHO_CMD} "WITH_DOCHTML=yes	Install the HTML documentation"
-.endif
-.if !defined(WITH_DOCPDF)
-	@${ECHO_CMD} "WITH_DOCPDF=yes		Install the PDF documentation"
-.endif
-.if !defined(WITH_GNOME)
-	@${ECHO_CMD} "WITH_GNOME=yes		Enable GNOME support"
-.endif
-.if !defined(WITH_IMLIB2)
-	@${ECHO_CMD} "WITH_IMLIB2=yes		Enable Imlib2 (pixmap themes) support"
-.endif
-.if !defined(WITH_XINERAMA)
-	@${ECHO_CMD} "WITH_XINERAMA=yes	Enable Xinerama support"
-.endif
-.if !defined(WITHOUT_NLS)
-	@${ECHO_CMD} "WITHOUT_NLS=yes		Disable NLS support"
-.endif
-.if !defined(WITHOUT_REMEMBER)
-	@${ECHO_CMD} "WITHOUT_REMEMBER=yes	Disable remembering attributes support"
-.endif
-.if !defined(WITHOUT_SLIT)
-	@${ECHO_CMD} "WITHOUT_SLIT=yes	Disable slit"
-.endif
-.if !defined(WITHOUT_TOOLBAR)
-	@${ECHO_CMD} "WITHOUT_TOOLBAR=yes	Disable toolbar"
-.endif
-.if !defined(WITHOUT_XRENDER)
-	@${ECHO_CMD} "WITHOUT_XRENDER=yes	Disable Xrender (transparent) support"
-.endif
-
 post-patch:
 	@${REINPLACE_CMD} -e 's|%%LOCALBASE%%|${LOCALBASE}|g' \
 		${WRKSRC}/util/fluxbox-generate_menu.in


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->beat 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jul 13 18:40:12 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148578 
State-Changed-From-To: open->closed 
State-Changed-By: beat 
State-Changed-When: Sun Jul 25 08:14:08 UTC 2010 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148578 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/148578: commit references a PR
Date: Sun, 25 Jul 2010 08:12:54 +0000 (UTC)

 beat        2010-07-25 08:12:41 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-wm/fluxbox       Makefile 
   Log:
   - Add OPTIONS
   
   PR:             ports/148578
   Submitted by:   David DEMELIER <demelier.david AT gmail.com>
   
   Revision  Changes    Path
   1.59      +14 -38    ports/x11-wm/fluxbox/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
