From tkato432@yahoo.com  Tue Jul 13 18:04:01 2010
Return-Path: <tkato432@yahoo.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 17DC6106566C
	for <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 13 Jul 2010 18:04:00 +0000 (UTC)
	(envelope-from tkato432@yahoo.com)
Received: from msa105lp.auone-net.jp (msa105lp.auone-net.jp [222.3.140.168])
	by mx1.freebsd.org (Postfix) with ESMTP id DF3948FC18
	for <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 13 Jul 2010 18:03:59 +0000 (UTC)
Received: from localhost.localdomain (ZT037007.ppp.dion.ne.jp [59.128.37.7])
	by msa105lp.auone-net.jp (au one net msa) with ESMTP id 054DE50036
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed, 14 Jul 2010 03:03:57 +0900 (JST)
Message-Id: <20100714030101.986a1969.tkato432@yahoo.com>
Date: Wed, 14 Jul 2010 03:01:01 +0900
From: KATO Tsuguru <tkato432@yahoo.com>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: Update port: graphics/swftools

>Number:         148559
>Category:       ports
>Synopsis:       Update port: graphics/swftools
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 13 18:10:10 UTC 2010
>Closed-Date:    Sat Sep 11 11:18:46 UTC 2010
>Last-Modified:  Sat Sep 11 11:20:03 UTC 2010
>Originator:     KATO Tsuguru
>Release:        FreeBSD 7.3-RELEASE i386
>Organization:
>Environment:
>Description:
- Add missing math/fftw3 to LIB_DEPENDS
- Add OPTION for print/pdflib support
- Fix disabling WITH_LAME to effect properly

>How-To-Repeat:
>Fix:

diff -urN /usr/ports/graphics/swftools/Makefile graphics/swftools/Makefile
--- /usr/ports/graphics/swftools/Makefile	2010-07-07 15:33:19.000000000 +0900
+++ graphics/swftools/Makefile	2010-07-07 15:42:47.000000000 +0900
@@ -8,6 +8,7 @@
 
 PORTNAME=	swftools
 PORTVERSION=	0.9.1
+PORTREVISION=	1
 CATEGORIES=	graphics
 MASTER_SITES=	http://www.swftools.org/ \
 		http://www.c-s.li/ports/
@@ -18,18 +19,21 @@
 LIB_DEPENDS=	t1.5:${PORTSDIR}/devel/t1lib \
 		jpeg.11:${PORTSDIR}/graphics/jpeg \
 		ungif.5:${PORTSDIR}/graphics/libungif \
+		fftw3.5:${PORTSDIR}/math/fftw3 \
 		freetype.9:${PORTSDIR}/print/freetype2 \
 		fontconfig.1:${PORTSDIR}/x11-fonts/fontconfig
 
 LICENSE=	GPLv2
 
-OPTIONS=	LAME "LAME MP3 audio encoder support" off
+OPTIONS=	LAME "LAME MP3 audio encoder support" off \
+		PDF "PDFlib support" off
 
 USE_GNOME=	pkgconfig
 USE_GL=		glut
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" \
+		ac_cv_lib_zzip_zzip_file_open=no
 
 MAKE_JOBS_SAFE=	yes
 
@@ -45,7 +49,17 @@
 .if defined(WITH_LAME)
 LIB_DEPENDS+=	mp3lame.0:${PORTSDIR}/audio/lame
 .else
-CONFIGURE_ARGS+=	--disable-lame
+#CONFIGURE_ARGS+=	--disable-lame
+CONFIGURE_ENV+=	ac_cv_lib_mp3lame_lame_init=no
+.endif
+
+.if defined(WITH_PDF)
+LIB_DEPENDS+=	pdf.8:${PORTSDIR}/print/pdflib
+PLIST_SUB+=	PDF=""
+MAN1+=		pdf2pdf.1
+.else
+CONFIGURE_ENV+=	ac_cv_header_pdflib_h=no
+PLIST_SUB+=	PDF="@comment "
 .endif
 
 post-patch:
diff -urN /usr/ports/graphics/swftools/pkg-plist graphics/swftools/pkg-plist
--- /usr/ports/graphics/swftools/pkg-plist	2009-05-09 22:07:32.000000000 +0900
+++ graphics/swftools/pkg-plist	2010-06-06 20:16:30.000000000 +0900
@@ -2,6 +2,7 @@
 bin/font2swf
 bin/gif2swf
 bin/jpeg2swf
+%%PDF%%bin/pdf2pdf
 bin/pdf2swf
 bin/png2swf
 bin/swfbbox
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jul 13 18:11:36 UTC 2010 
Responsible-Changed-Why:  
miwi@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148559 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jul 13 18:11:39 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148559 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: c-s@c-s.li
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/148559: Update port: graphics/swftools
Date: Tue, 13 Jul 2010 18:11:37 UT

 Maintainer of graphics/swftools,
 
 Please note that PR ports/148559 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148559
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: <c-s@c-s.li>
To: <bug-followup@FreeBSD.org>, <tkato432@yahoo.com>
Cc:  
Subject: Re: ports/148559: Update port: graphics/swftools
Date: Sat, 24 Jul 2010 14:19:50 +0200

 Thanks a lot for this patch. The pkg-plist diff should not include
 %%PDF%%, do you agree? Please send a fixed patch.
 
 Cheers,
 Carlo

From: KATO Tsuguru <tkato432@yahoo.com>
To: bug-followup@FreeBSD.org, c-s@c-s.li
Cc:  
Subject: Re: ports/148559: Update port: graphics/swftools
Date: Sun, 25 Jul 2010 21:00:06 +0900

 "c-s@c-s.li" <c-s@c-s.li> wrote:
 
 > Thanks a lot for this patch. The pkg-plist diff should not include
 > %%PDF%%, do you agree? Please send a fixed patch.
 
 I suppose it's necessary to modify pkg-plist if pdflib support is
 acceptable. Do I need to remove the section about pdflib?

From: <c-s@c-s.li>
To: KATO Tsuguru <tkato432@yahoo.com>, <bug-followup@FreeBSD.org>
Cc:  
Subject: Re: ports/148559: Update port: graphics/swftools
Date: Mon, 26 Jul 2010 00:04:19 +0200

 Sorry, I think you misunderstood me. I am completely happy with your
 changes. The only thing that bothers me is the %%PDF%% part in front of
 /bin/pdf2pdf. Using ports-mgmt/genplist creates only /bin/pdf2pdf as an
 entry without the %%PDF%% part. Moreover, I don't see which path this would
 typically represent. In short, I suggest removing "%%PDF%%" from pkg-plist.
 What do you think?

From: KATO Tsuguru <tkato432@yahoo.com>
To: bug-followup@FreeBSD.org, c-s@c-s.li
Cc:  
Subject: Re: ports/148559: Update port: graphics/swftools
Date: Tue, 27 Jul 2010 02:30:06 +0900

 "c-s@c-s.li" <c-s@c-s.li> wrote:
 
 > Sorry, I think you misunderstood me. I am completely happy with your
 > changes. The only thing that bothers me is the %%PDF%% part in front of
 > /bin/pdf2pdf. Using ports-mgmt/genplist creates only /bin/pdf2pdf as an
 > entry without the %%PDF%% part. Moreover, I don't see which path this would
 > typically represent. In short, I suggest removing "%%PDF%%" from pkg-plist.
 > What do you think?
 
 Oh, I finally realized what was actually wrong. How to tell
 configure script to avoid detecting pdflib didn't work as
 expected.
 
 Here is a fixed patch.
 
 
 diff -urN /usr/ports/graphics/swftools/Makefile graphics/swftools/Makefile
 --- /usr/ports/graphics/swftools/Makefile	2010-07-07 15:33:19.000000000 +0900
 +++ graphics/swftools/Makefile	2010-07-26 16:30:54.000000000 +0900
 @@ -8,6 +8,7 @@
  
  PORTNAME=	swftools
  PORTVERSION=	0.9.1
 +PORTREVISION=	1
  CATEGORIES=	graphics
  MASTER_SITES=	http://www.swftools.org/ \
  		http://www.c-s.li/ports/
 @@ -18,18 +19,21 @@
  LIB_DEPENDS=	t1.5:${PORTSDIR}/devel/t1lib \
  		jpeg.11:${PORTSDIR}/graphics/jpeg \
  		ungif.5:${PORTSDIR}/graphics/libungif \
 +		fftw3.5:${PORTSDIR}/math/fftw3 \
  		freetype.9:${PORTSDIR}/print/freetype2 \
  		fontconfig.1:${PORTSDIR}/x11-fonts/fontconfig
  
  LICENSE=	GPLv2
  
 -OPTIONS=	LAME "LAME MP3 audio encoder support" off
 +OPTIONS=	LAME "LAME MP3 audio encoder support" off \
 +		PDF "PDFlib support" off
  
  USE_GNOME=	pkgconfig
  USE_GL=		glut
  USE_GMAKE=	yes
  GNU_CONFIGURE=	yes
 -CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 +CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" \
 +		ac_cv_lib_zzip_zzip_file_open=no
  
  MAKE_JOBS_SAFE=	yes
  
 @@ -45,7 +49,17 @@
  .if defined(WITH_LAME)
  LIB_DEPENDS+=	mp3lame.0:${PORTSDIR}/audio/lame
  .else
 -CONFIGURE_ARGS+=	--disable-lame
 +#CONFIGURE_ARGS+=	--disable-lame
 +CONFIGURE_ENV+=	ac_cv_lib_mp3lame_lame_init=no
 +.endif
 +
 +.if defined(WITH_PDF)
 +LIB_DEPENDS+=	pdf.8:${PORTSDIR}/print/pdflib
 +PLIST_SUB+=	PDF=""
 +MAN1+=		pdf2pdf.1
 +.else
 +CONFIGURE_ENV+=	ac_cv_lib_pdf_PDF_open_file=no
 +PLIST_SUB+=	PDF="@comment "
  .endif
  
  post-patch:
 diff -urN /usr/ports/graphics/swftools/pkg-plist graphics/swftools/pkg-plist
 --- /usr/ports/graphics/swftools/pkg-plist	2009-05-09 22:07:32.000000000 +0900
 +++ graphics/swftools/pkg-plist	2010-06-06 20:16:30.000000000 +0900
 @@ -2,6 +2,7 @@
  bin/font2swf
  bin/gif2swf
  bin/jpeg2swf
 +%%PDF%%bin/pdf2pdf
  bin/pdf2swf
  bin/png2swf
  bin/swfbbox

From: C-S <c-s@c-s.li>
To: bug-followup@FreeBSD.org, tkato432@yahoo.com, miwi@freebsd.org
Cc:  
Subject: Re: ports/148559: Update port: graphics/swftools
Date: Mon, 02 Aug 2010 21:17:20 +0200

 I approve this last patch. Many thanks for submitting it.
 
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Sep 11 11:18:45 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148559 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/148559: commit references a PR
Date: Sat, 11 Sep 2010 11:18:39 +0000 (UTC)

 miwi        2010-09-11 11:18:35 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/swftools    Makefile pkg-plist 
   Log:
   - Add missing math/fftw3 to LIB_DEPENDS
   - Add OPTION for print/pdflib support
   - Fix disabling WITH_LAME to effect properly
   
   PR:             148559
   Submitted by:   Ports Fury
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.36      +17 -3     ports/graphics/swftools/Makefile
   1.10      +1 -0      ports/graphics/swftools/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
