From nobody@FreeBSD.org  Mon Jul 12 19:46:12 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 15AC01065674
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Jul 2010 19:46:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 055FB8FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Jul 2010 19:46:12 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6CJkBtP004155
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 12 Jul 2010 19:46:11 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o6CJkB9u004154;
	Mon, 12 Jul 2010 19:46:11 GMT
	(envelope-from nobody)
Message-Id: <201007121946.o6CJkB9u004154@www.freebsd.org>
Date: Mon, 12 Jul 2010 19:46:11 GMT
From: Andrew Fernandes <andrew@fernandes.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] update miniupnpd 1.4 -> 1.4.20100511 to fix NAT-PMP bug
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         148529
>Category:       ports
>Synopsis:       [patch] update net/miniupnpd 1.4 -> 1.4.20100511 to fix NAT-PMP bug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    araujo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 12 19:50:04 UTC 2010
>Closed-Date:    Sun Jul 18 15:50:35 UTC 2010
>Last-Modified:  Sun Jul 18 16:00:19 UTC 2010
>Originator:     Andrew Fernandes
>Release:        FreeBSD 8.1-RC2 i386
>Organization:
The University of Western Ontario
>Environment:
FreeBSD FreeBSDvm.localdomain 8.1-RC2 FreeBSD 8.1-RC2 #0: Tue Jun 29 20:42:40 UTC 2010 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
There have been a few updates to miniupnpd since the version 1.4 (2009/10/30) that is currently in ports.
(See http://miniupnp.free.fr/files/changelog.php?file=miniupnpd-1.4.20100511.tar.gz).

None of the updates should affect FreeBSD except for two bug-fixes to the NAT-PMP code. Since our lab uses Apple computers exclusively, working NAT-PMP is very important.

According to my testing, the update to the current stable version (1.4.20100511) is a trivial version bump (attached).

>How-To-Repeat:
Run miniupnpd using many NAT-PMP sessions.
>Fix:
Update from version 1.4 to 1.4.20100511

Patch attached with submission follows:

--- Makefile.orig	2010-07-10 21:26:37.000000000 -0400
+++ Makefile	2010-07-10 21:27:02.000000000 -0400
@@ -6,8 +6,7 @@
 #
 
 PORTNAME=	miniupnpd
-PORTVERSION=	1.4
-PORTREVISION=	2
+PORTVERSION=	1.4.20100511
 CATEGORIES=	net
 MASTER_SITES=	http://miniupnp.tuxfamily.org/files/ \
 		http://miniupnp.free.fr/files/
--- distinfo.orig	2010-07-10 20:32:41.000000000 -0400
+++ distinfo	2010-07-10 21:23:24.000000000 -0400
@@ -1,3 +1,3 @@
-MD5 (miniupnpd-1.4.tar.gz) = ffa33d4ed8732c662bdb7d511e86db76
-SHA256 (miniupnpd-1.4.tar.gz) = 85ba7cd28cb9f5ac2c96484325a30c64e385e011f57ead5997568bfde753051b
-SIZE (miniupnpd-1.4.tar.gz) = 90071
+MD5 (miniupnpd-1.4.20100511.tar.gz) = fa3491d4de8dbfdee55dc7ff7f0b2b3c
+SHA256 (miniupnpd-1.4.20100511.tar.gz) = 1fce907ecaeb49d8a58524c000536a6b6e79789a952e137c9141d50936ea4f0a
+SIZE (miniupnpd-1.4.20100511.tar.gz) = 93281


>Release-Note:
>Audit-Trail:
Date: Tue, 13 Jul 2010 01:40:55 +0200
From: Tor Halvard Furulund <squat@squat.no>
To: FreeBSD-gnats-submit@freebsd.org, Andrew Fernandes <andrew@fernandes.org>
Subject: Re: [patch] update miniupnpd 1.4 -> 1.4.20100511 to fix NAT-PMP bug

 The patch submitted by Andrew Fernandes looks good to me.
 
 (Maintainer approval)
 
 --
 Tor Halvard Furulund
Responsible-Changed-From-To: freebsd-ports-bugs->araujo 
Responsible-Changed-By: araujo 
Responsible-Changed-When: Wed Jul 14 02:10:05 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148529 
State-Changed-From-To: open->closed 
State-Changed-By: araujo 
State-Changed-When: Sun Jul 18 15:50:33 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148529 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/148529: commit references a PR
Date: Sun, 18 Jul 2010 15:50:18 +0000 (UTC)

 araujo      2010-07-18 15:50:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/miniupnpd        Makefile distinfo 
   Log:
   - Update to 1.4.20100511.
   
   PR:             ports/148529
   Submitted by:   Andrew Fernandes <andrew@fernandes.org>
   Approved by:    Tor Halvard Furulund <squat@squat.no> (maintainer)
   
   Revision  Changes    Path
   1.14      +1 -2      ports/net/miniupnpd/Makefile
   1.12      +3 -3      ports/net/miniupnpd/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
