From ohauer@gmx.de  Wed Jun 30 19:53:09 2010
Return-Path: <ohauer@gmx.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92C2D106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 Jun 2010 19:53:09 +0000 (UTC)
	(envelope-from ohauer@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id AD1428FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 Jun 2010 19:53:08 +0000 (UTC)
Received: (qmail invoked by alias); 30 Jun 2010 19:53:07 -0000
Received: from u18-124.dsl.vianetworks.de (EHLO u18-124.dsl.vianetworks.de) [194.231.39.124]
  by mail.gmx.net (mp032) with SMTP; 30 Jun 2010 21:53:07 +0200
Received: by u18-124.dsl.vianetworks.de (Postfix, from userid 1100)
	id 875A62021D; Wed, 30 Jun 2010 21:53:02 +0200 (CEST)
Message-Id: <20100630195302.875A62021D@u18-124.dsl.vianetworks.de>
Date: Wed, 30 Jun 2010 21:53:02 +0200 (CEST)
From: olli hauer <ohauer@gmx.de>
Reply-To: olli hauer <ohauer@gmx.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: <ohauer@gmx.de>
Subject: port install problem if license framework is enabled
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         148267
>Category:       ports
>Synopsis:       port install problem if license framework is enabled
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ohauer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 30 20:00:17 UTC 2010
>Closed-Date:    Tue Aug 03 19:22:19 UTC 2010
>Last-Modified:  Tue Aug 03 19:22:19 UTC 2010
>Originator:     olli hauer <ohauer@gmx.de>
>Release:        FreeBSD 7.3-RELEASE-p1 i386
>Organization:
>Environment:

>Description:
If I enable the following line in port security/pulledpork
LICENSE= GPLv2

Install fails with the following error message
 sed: 1: "s!%%share/licenses/pull ...": unescaped newline inside substitute pattern

see the last lines from the build log (make -d A)

Please enlighten me what goes wrong here.

>How-To-Repeat:
Apply patch from PR 148247 to the port
remove the comment before LICENSE= GPLv2
make install

>Fix:

--- build_failure_with_license.txt begins here ---
Result is "0.4.2"
Applying :S to "CONFIGDIR=/usr/local/etc/pulledpork share/licenses/pulledpork-0.4.2 PREFIX=/usr/local LOCALBASE=/usr/local X11BASE=/usr/local  DATADIR=/usr/local/share/pulledpork DOCSDIR=/usr/local/share/doc/pulledpork EXAMPLESDIR=/usr/local/share/examples/pulledpork  WWWDIR=/usr/local/www/pulledpork ETCDIR=/usr/local/etc/pulledpork"
Result is "CONFIGDIR=/usr/local/etc/pulledpork!g share/licenses/pulledpork-0.4.2!g PREFIX=/usr/local!g LOCALBASE=/usr/local!g X11BASE=/usr/local!g DATADIR=/usr/local/share/pulledpork!g DOCSDIR=/usr/local/share/doc/pulledpork!g EXAMPLESDIR=/usr/local/share/examples/pulledpork!g WWWDIR=/usr/local/www/pulledpork!g ETCDIR=/usr/local/etc/pulledpork!g"
Applying :S to "CONFIGDIR=/usr/local/etc/pulledpork!g share/licenses/pulledpork-0.4.2!g PREFIX=/usr/local!g LOCALBASE=/usr/local!g X11BASE=/usr/local!g DATADIR=/usr/local/share/pulledpork!g DOCSDIR=/usr/local/share/doc/pulledpork!g EXAMPLESDIR=/usr/local/share/examples/pulledpork!g WWWDIR=/usr/local/www/pulledpork!g ETCDIR=/usr/local/etc/pulledpork!g"
Result is " -e s!%%CONFIGDIR=/usr/local/etc/pulledpork!g  -e s!%%share/licenses/pulledpork-0.4.2!g  -e s!%%PREFIX=/usr/local!g  -e s!%%LOCALBASE=/usr/local!g  -e s!%%X11BASE=/usr/local!g  -e s!%%DATADIR=/usr/local/share/pulledpork!g  -e s!%%DOCSDIR=/usr/local/share/doc/pulledpork!g  -e s!%%EXAMPLESDIR=/usr/local/share/examples/pulledpork!g  -e s!%%WWWDIR=/usr/local/www/pulledpork!g  -e s!%%ETCDIR=/usr/local/etc/pulledpork!g"
Applying :S to " -e s!%%CONFIGDIR=/usr/local/etc/pulledpork!g  -e s!%%share/licenses/pulledpork-0.4.2!g  -e s!%%PREFIX=/usr/local!g  -e s!%%LOCALBASE=/usr/local!g  -e s!%%X11BASE=/usr/local!g  -e s!%%DATADIR=/usr/local/share/pulledpork!g  -e s!%%DOCSDIR=/usr/local/share/doc/pulledpork!g  -e s!%%EXAMPLESDIR=/usr/local/share/examples/pulledpork!g  -e s!%%WWWDIR=/usr/local/www/pulledpork!g  -e s!%%ETCDIR=/usr/local/etc/pulledpork!g"
Result is "-e s!%%CONFIGDIR%%!/usr/local/etc/pulledpork!g -e s!%%share/licenses/pulledpork-0.4.2!g -e s!%%PREFIX%%!/usr/local!g -e s!%%LOCALBASE%%!/usr/local!g -e s!%%X11BASE%%!/usr/local!g -e s!%%DATADIR%%!/usr/local/share/pulledpork!g -e s!%%DOCSDIR%%!/usr/local/share/doc/pulledpork!g -e s!%%EXAMPLESDIR%%!/usr/local/share/examples/pulledpork!g -e s!%%WWWDIR%%!/usr/local/www/pulledpork!g -e s!%%ETCDIR%%!/usr/local/etc/pulledpork!g"
/usr/bin/sed -e s!%%CONFIGDIR%%!/usr/local/etc/pulledpork!g -e s!%%share/licenses/pulledpork-0.4.2!g -e s!%%PREFIX%%!/usr/local!g -e s!%%LOCALBASE%%!/usr/local!g -e s!%%X11BASE%%!/usr/local!g -e s!%%DATADIR%%!/usr/local/share/pulledpork!g -e s!%%DOCSDIR%%!/usr/local/share/doc/pulledpork!g -e s!%%EXAMPLESDIR%%!/usr/local/share/examples/pulledpork!g -e s!%%WWWDIR%%!/usr/local/www/pulledpork!g -e s!%%ETCDIR%%!/usr/local/etc/pulledpork!g -e '/^@comment /d' /usr/ports/security/pulledpork/files/pkg-message.in > /data/work/usr/ports/security/pulledpork/work/pkg-message
sed: 1: "s!%%share/licenses/pull ...": unescaped newline inside substitute pattern
*** Error code 1

Stop in /usr/ports/security/pulledpork.
--- build_failure_with_license.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->glarkin 
Responsible-Changed-By: glarkin 
Responsible-Changed-When: Fri Jul 23 14:34:51 EDT 2010 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148267 

From: Anonymous <swell.k@gmail.com>
To: olli hauer <ohauer@gmx.de>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/148267: port install problem if license framework is enabled
Date: Sat, 24 Jul 2010 03:34:07 +0400

 I think it may be due to using PLIST_DIR inside SUB_LIST.
 
 --- a.diff begins here ---
 Index: security/pulledpork/Makefile
 ===================================================================
 RCS file: /a/.cvsup/ports/security/pulledpork/Makefile,v
 retrieving revision 1.3
 diff -u -p -r1.3 Makefile
 --- security/pulledpork/Makefile	2 Jul 2010 19:49:44 -0000	1.3
 +++ security/pulledpork/Makefile	23 Jul 2010 23:24:34 -0000
 @@ -17,21 +17,21 @@ COMMENT=	Script to update snort-2.8+ rul
  RUN_DEPENDS=	${SITE_PERL}/LWP/Simple.pm:${PORTSDIR}/www/p5-libwww \
  		p5-Crypt-SSLeay>=0.57:${PORTSDIR}/security/p5-Crypt-SSLeay
  
 -#LICENSE=	GPLv2
 +LICENSE=	GPLv2
 +# collides with _LICENSE_REPORT, cf. ports/148808
 +#LICENSE_FILE=	${WRKSRC}/LICENSE
  
  NO_BUILD=	yes
  USE_PERL5_RUN=	yes
  
 -PLIST_DIRS=	etc/pulledpork
 +PLIST_DIRS=	%%ETCDIR%%
  PLIST_FILES=	bin/pulledpork.pl \
 -		${PLIST_DIRS}/disablesid.conf.sample \
 -		${PLIST_DIRS}/dropsid.conf.sample \
 -		${PLIST_DIRS}/enablesid.conf.sample \
 -		${PLIST_DIRS}/pulledpork.conf.sample
 +		%%ETCDIR%%/disablesid.conf.sample \
 +		%%ETCDIR%%/dropsid.conf.sample \
 +		%%ETCDIR%%/enablesid.conf.sample \
 +		%%ETCDIR%%/pulledpork.conf.sample
  
 -CONFIG_DIR=	${PREFIX}/${PLIST_DIRS}
  SUB_FILES=	pkg-message
 -SUB_LIST=	CONFIGDIR=${CONFIG_DIR}
  
  .include <bsd.port.pre.mk>
  
 @@ -53,12 +53,12 @@ post-patch:
  
  do-install:
  	${INSTALL_SCRIPT} ${WRKSRC}/pulledpork.pl ${PREFIX}/bin
 -	@${MKDIR} -m 750 ${CONFIG_DIR}
 +	@${MKDIR} -m 750 ${ETCDIR}
  	# pulledpork.conf contains the snort user registration key, do not install world readable
 -	${INSTALL_DATA} -m 440 ${WRKSRC}/etc/pulledpork.conf ${CONFIG_DIR}/pulledpork.conf.sample
 -	${INSTALL_DATA} ${WRKSRC}/etc/disablesid.conf ${CONFIG_DIR}/disablesid.conf.sample
 -	${INSTALL_DATA} ${WRKSRC}/etc/dropsid.conf    ${CONFIG_DIR}/dropsid.conf.sample
 -	${INSTALL_DATA} ${WRKSRC}/etc/enablesid.conf  ${CONFIG_DIR}/enablesid.conf.sample
 +	${INSTALL_DATA} -m 440 ${WRKSRC}/etc/pulledpork.conf ${ETCDIR}/pulledpork.conf.sample
 +	${INSTALL_DATA} ${WRKSRC}/etc/disablesid.conf ${ETCDIR}/disablesid.conf.sample
 +	${INSTALL_DATA} ${WRKSRC}/etc/dropsid.conf    ${ETCDIR}/dropsid.conf.sample
 +	${INSTALL_DATA} ${WRKSRC}/etc/enablesid.conf  ${ETCDIR}/enablesid.conf.sample
  
  .if !defined(NOPORTDOCS)
  	@${MKDIR} ${DOCSDIR}
 Index: security/pulledpork/files/pkg-message.in
 ===================================================================
 RCS file: /a/.cvsup/ports/security/pulledpork/files/pkg-message.in,v
 retrieving revision 1.1
 diff -u -p -r1.1 pkg-message.in
 --- security/pulledpork/files/pkg-message.in	10 May 2010 02:53:35 -0000	1.1
 +++ security/pulledpork/files/pkg-message.in	23 Jul 2010 23:17:22 -0000
 @@ -1,7 +1,7 @@
  =====================================================================
  
  In order to use pulled pork, adjust the config files located in
 -%%CONFIGDIR%%/
 +%%ETCDIR%%/
  
  
  Important Note:
 --- a.diff ends here ---

From: olli hauer <ohauer@gmx.de>
To: Anonymous <swell.k@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/148267: port install problem if license framework is enabled
Date: Sun, 25 Jul 2010 22:11:50 +0200

 > I think it may be due to using PLIST_DIR inside SUB_LIST.
 
 Thanks, your patch fix the issue if the license framework is enabled.
 I guess there are many other ports which have the same problem.
 
 Please close the PR.
 
 --
 olli
Responsible-Changed-From-To: glarkin->ohauer 
Responsible-Changed-By: glarkin 
Responsible-Changed-When: Sun Aug 1 21:08:30 EDT 2010 
Responsible-Changed-Why:  
Reassigned to Olli, since he has commit privs now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148267 
State-Changed-From-To: open->analyzed 
State-Changed-By: ohauer 
State-Changed-When: Tue Aug 3 18:31:25 UTC 2010 
State-Changed-Why:  
changed to ->  analyzed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148267 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/148267: commit references a PR
Date: Tue,  3 Aug 2010 19:16:47 +0000 (UTC)

 ohauer      2010-08-03 19:16:35 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/pulledpork  Makefile 
   Log:
   - force commit PR ports/148267
   
   PR:             ports/148267
   Approved by:    glarkin (mentor)
   
   Revision  Changes    Path
   1.5       +0 -0      ports/security/pulledpork/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: ohauer 
State-Changed-When: Tue Aug 3 19:21:31 UTC 2010 
State-Changed-Why:  
Committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148267 
>Unformatted:
