From nwhitehorn@anacreon.physics.wisc.edu  Mon Jun 28 02:02:24 2010
Return-Path: <nwhitehorn@anacreon.physics.wisc.edu>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C41CE106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jun 2010 02:02:24 +0000 (UTC)
	(envelope-from nwhitehorn@anacreon.physics.wisc.edu)
Received: from anacreon.physics.wisc.edu (anacreon.physics.wisc.edu [128.104.160.176])
	by mx1.freebsd.org (Postfix) with ESMTP id 8FD1A8FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jun 2010 02:02:24 +0000 (UTC)
Received: from anacreon.physics.wisc.edu (localhost [127.0.0.1])
	by anacreon.physics.wisc.edu (8.14.4/8.14.4) with ESMTP id o5S22NGH027706
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Jun 2010 21:02:23 -0500 (CDT)
	(envelope-from nwhitehorn@anacreon.physics.wisc.edu)
Received: (from nwhitehorn@localhost)
	by anacreon.physics.wisc.edu (8.14.4/8.14.4/Submit) id o5S22N1K027705;
	Sun, 27 Jun 2010 21:02:23 -0500 (CDT)
	(envelope-from nwhitehorn)
Message-Id: <201006280202.o5S22N1K027705@anacreon.physics.wisc.edu>
Date: Sun, 27 Jun 2010 21:02:23 -0500 (CDT)
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
Reply-To: Nathan Whitehorn <nwhitehorn@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] fix build for x11-toolkits/qt4-gui on powerpc64
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         148199
>Category:       ports
>Synopsis:       [patch] fix build for x11-toolkits/qt4-gui on powerpc64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 28 02:10:04 UTC 2010
>Closed-Date:    Fri Jul 09 16:27:36 UTC 2010
>Last-Modified:  Fri Jul  9 16:30:06 UTC 2010
>Originator:     Nathan Whitehorn
>Release:        FreeBSD 9.0-CURRENT powerpc64
>Organization:
University of Wisconsin
>Environment:
System: FreeBSD anacreon.physics.wisc.edu 9.0-CURRENT FreeBSD 9.0-CURRENT #6 r209477:209507: Thu Jun 24 09:30:48 CDT 2010 root@anacreon.physics.wisc.edu:/usr/obj/scratch/src/sys/ANACREON powerpc64


	
>Description:
	Due to a binutils deficiency on 64-bit powerpc systems, the qt4-gui
library will not link due to a TOC overflow.
-mminimal-toc to the compiler flags.
>How-To-Repeat:
	
>Fix:
	The attached patch adds -mminimal-toc to LDFLAGS on this platform,
which works around this issue and produces a functioning build of QT.

--- qt4-gui-Makefile.diff begins here ---
--- Makefile.bak	2010-06-26 15:34:37.000000000 -0500
+++ Makefile	2010-06-26 14:42:22.000000000 -0500
@@ -58,6 +58,12 @@
 FONTSCALE=	${LOCALBASE}/lib/X11/fonts/TTF/luximb.ttf
 FONTENCOD=	${LOCALBASE}/lib/X11/fonts/encodings/encodings.dir
 
+.include <bsd.port.pre.mk>
+
+.if ${ARCH} == powerpc64
+CFLAGS+= -mminimal-toc
+.endif
+
 .include "${.CURDIR}/../../devel/qt4/files/Makefile.options"
 
 .if ${QT4_OPTIONS:MCUPS}
@@ -99,4 +105,4 @@
 			-E -e 's|(.*location=).*uic|\1${PREFIX}/bin/uic-qt4|g' \
 		${WRKSRC}/lib/pkgconfig/QtGui.pc
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- qt4-gui-Makefile.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 28 02:10:14 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148199 
State-Changed-From-To: open->closed 
State-Changed-By: makc 
State-Changed-When: Fri Jul 9 16:27:35 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148199 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/148199: commit references a PR
Date: Fri,  9 Jul 2010 16:25:10 +0000 (UTC)

 makc        2010-07-09 16:24:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-toolkits/qt4-gui Makefile 
   Log:
   Fix build for on powerpc64
   
   PR:             ports/148199
   Submitted by:   nwhitehorn@
   
   Revision  Changes    Path
   1.32      +7 -1      ports/x11-toolkits/qt4-gui/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
