From nobody@FreeBSD.org  Fri Jun 25 16:33:42 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 181121065676
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Jun 2010 16:33:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 071468FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Jun 2010 16:33:42 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o5PGXfhu010356
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Jun 2010 16:33:41 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o5PGXfsI010355;
	Fri, 25 Jun 2010 16:33:41 GMT
	(envelope-from nobody)
Message-Id: <201006251633.o5PGXfsI010355@www.freebsd.org>
Date: Fri, 25 Jun 2010 16:33:41 GMT
From: David Naylor <naylor.b.david@gmail.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: print/cups-samba: Add ability to use difference samba port
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: mwisnicki+freebsd@gmail.com

>Number:         148145
>Category:       ports
>Synopsis:       print/cups-samba: Add ability to use difference samba port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 25 16:40:04 UTC 2010
>Closed-Date:    Tue Sep 14 20:32:49 UTC 2010
>Last-Modified:  Tue Sep 14 20:32:49 UTC 2010
>Originator:     David Naylor
>Release:        FreeBSD-9
>Organization:
Private
>Environment:
FreeBSD dragon.dg 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Sat Jun 19 19:08:38 SAST 2010     root@dragon.dg:/tmp/home/freebsd9/src/sys/DRAGON  amd64

>Description:
This port defaults to net/samba3 but does not allow one to take advantage of newer samba ports (samba32 and samba33).

This patch allows the samba port to be set via SAMBA_PORT (default is no functional change).

This is related to ports/139435.  
>How-To-Repeat:
n/a
>Fix:
n/a

Patch attached with submission follows:

diff -u /usr/ports/print/cups-samba/Makefile cups-samba/Makefile
--- /usr/ports/print/cups-samba/Makefile	2010-03-29 03:12:33.000000000 +0200
+++ cups-samba/Makefile	2010-06-25 18:22:46.000000000 +0200
@@ -18,11 +18,12 @@
 MAINTAINER=	tomasv@megalogika.lt
 COMMENT=	The Common UNIX Printing System:  MS Windows client drivers
 
-RUN_DEPENDS=	smbspool:${PORTSDIR}/net/samba3 \
+RUN_DEPENDS=	smbspool:${PORTSDIR}/net/${SAMBA_PORT} \
 		${LOCALBASE}/sbin/cupsd:${PORTSDIR}/print/cups-base
 
 NO_BUILD=	yes
 NO_WRKSUBDIR=	yes
+SAMBA_PORT?=	samba3
 
 DATADIR=	${PREFIX}/share/cups
 DRIVER_FILES=	cups6.inf cups6.ini cupsps6.dll cupsui6.dll
Common subdirectories: /usr/ports/print/cups-samba/files and cups-samba/files


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jun 25 16:40:14 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148145 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: tomasv@megalogika.lt
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/148145: print/cups-samba: Add ability to use difference samba port
Date: Fri, 25 Jun 2010 16:40:11 UT

 Maintainer of print/cups-samba,
 
 Please note that PR ports/148145 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148145
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Thu Jul 29 02:01:07 UTC 2010 
State-Changed-Why:  
Maintainer was reset. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148145 
State-Changed-From-To: open->feedback 
State-Changed-By: linimon 
State-Changed-When: Thu Jul 29 02:48:50 UTC 2010 
State-Changed-Why:  
Over to new maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148145 

From: Alson van der Meulen <bugs@alm.flutnet.org>
To: bug-followup@FreeBSD.org, naylor.b.david@gmail.org
Cc:  
Subject: Re: ports/148145: print/cups-samba: Add ability to use difference
 samba port
Date: Fri, 13 Aug 2010 19:04:23 +0200

 net/samba3 is currently deprecated, and will expire soon, so it's
 currently impossible to install print/cups-samba without changing
 makefiles. This patch, plus changing the default to a supported Samba
 version, would be a way to fix that.
 
 Alson

From: David Naylor <naylor.b.david@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/148145: print/cups-samba: Add ability to use difference samba port
Date: Sun, 29 Aug 2010 14:40:43 +0200

 --Boundary-00=_NVleMZu8bMDE9n/
 Content-Type: Text/Plain;
   charset="us-ascii"
 Content-Transfer-Encoding: 7bit
 
 See attached patch that makes the default samba port to samba34.  I have used 
 this patch with success and `port test` is happy.  
 
 --Boundary-00=_NVleMZu8bMDE9n/
 Content-Type: text/x-patch;
   charset="ISO-8859-1";
   name="cups-samba.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="cups-samba.diff"
 
 diff -u /usr/ports/print/cups-samba/Makefile cups-samba/Makefile
 --- /usr/ports/print/cups-samba/Makefile	2010-03-29 03:12:33.000000000 +0200
 +++ cups-samba/Makefile	2010-06-25 18:22:46.000000000 +0200
 @@ -18,11 +18,12 @@
  MAINTAINER=	tomasv@megalogika.lt
  COMMENT=	The Common UNIX Printing System:  MS Windows client drivers
  
 -RUN_DEPENDS=	smbspool:${PORTSDIR}/net/samba3 \
 +RUN_DEPENDS=	smbspool:${PORTSDIR}/net/${SAMBA_PORT} \
  		${LOCALBASE}/sbin/cupsd:${PORTSDIR}/print/cups-base
  
  NO_BUILD=	yes
  NO_WRKSUBDIR=	yes
 +SAMBA_PORT?=	samba34
  
  DATADIR=	${PREFIX}/share/cups
  DRIVER_FILES=	cups6.inf cups6.ini cupsps6.dll cupsui6.dll
 Common subdirectories: /usr/ports/print/cups-samba/files and cups-samba/files
 
 --Boundary-00=_NVleMZu8bMDE9n/--
State-Changed-From-To: feedback->closed 
State-Changed-By: garga 
State-Changed-When: Tue Sep 14 20:32:47 UTC 2010 
State-Changed-Why:  
Added. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148145 
>Unformatted:
