From glewis@misty.eyesbeyond.com  Sat Jun 19 03:38:43 2010
Return-Path: <glewis@misty.eyesbeyond.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DE63E106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Jun 2010 03:38:43 +0000 (UTC)
	(envelope-from glewis@misty.eyesbeyond.com)
Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16])
	by mx1.freebsd.org (Postfix) with ESMTP id A6B4C8FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Jun 2010 03:38:42 +0000 (UTC)
Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1])
	by misty.eyesbeyond.com (8.14.4/8.14.4) with ESMTP id o5J3cENe000410;
	Fri, 18 Jun 2010 20:38:20 -0700 (PDT)
	(envelope-from glewis@misty.eyesbeyond.com)
Received: (from glewis@localhost)
	by misty.eyesbeyond.com (8.14.4/8.14.4/Submit) id o5J3c9TH000409;
	Fri, 18 Jun 2010 20:38:09 -0700 (PDT)
	(envelope-from glewis)
Message-Id: <201006190338.o5J3c9TH000409@misty.eyesbeyond.com>
Date: Fri, 18 Jun 2010 20:38:09 -0700 (PDT)
From: Greg Lewis <glewis@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: yds@CoolRat.org
Subject: [PATCH] mail/dovecot: pre-install -> pre-su-install
X-Send-Pr-Version: 3.113
X-GNATS-Notify: yds@CoolRat.org

>Number:         147988
>Category:       ports
>Synopsis:       [PATCH] mail/dovecot: pre-install -> pre-su-install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glewis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 19 03:40:01 UTC 2010
>Closed-Date:    Mon Jul 05 05:47:33 UTC 2010
>Last-Modified:  Mon Jul  5 05:50:01 UTC 2010
>Originator:     Greg Lewis
>Release:        FreeBSD 7.3-RELEASE i386
>Organization:
>Environment:
System: FreeBSD misty.eyesbeyond.com 7.3-RELEASE FreeBSD 7.3-RELEASE #0: Sat Apr 10 10:48:33 PDT 2010
>Description:
The pkg-install script run during pre-install will potentially create a user
and a group, so it needs to be run as root.  Achieve this by switching to
the pre-su-install target.

Port maintainer (yds@CoolRat.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- dovecot-1.2.11.patch begins here ---
Index: Makefile
===================================================================
RCS file: /var/fcvs/ports/mail/dovecot/Makefile,v
retrieving revision 1.113
diff -u -r1.113 Makefile
--- Makefile	24 Apr 2010 21:20:34 -0000	1.113
+++ Makefile	25 May 2010 05:52:38 -0000
@@ -201,7 +201,7 @@
 	@${LN} -f ${WRKSRC}/doc/dovecot-ldap-example.conf	${WRKSRC}/doc/dovecot-ldap.conf
 	@${LN} -f ${WRKSRC}/doc/dovecot-sql-example.conf	${WRKSRC}/doc/dovecot-sql.conf
 
-pre-install:
+pre-su-install:
 	@${SETENV} ${SCRIPTS_ENV} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
 
 post-install:
--- dovecot-1.2.11.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->glewis 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jun 19 03:40:40 UTC 2010 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147988 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Jun 19 03:40:45 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147988 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: yds@CoolRat.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/147988: [PATCH] mail/dovecot: pre-install -> pre-su-install
Date: Sat, 19 Jun 2010 03:40:43 UT

 Maintainer of mail/dovecot,
 
 Please note that PR ports/147988 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147988
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Yarema <yds@CoolRat.org>
To: bug-followup@FreeBSD.org
Cc: Denny Lin <dennylin93@hs.ntnu.edu.tw>, 
 Greg Lewis <glewis@freebsd.org>
Subject: Re: ports/147988: [PATCH] mail/dovecot: pre-install -> pre-su-install
Date: Sun, 04 Jul 2010 15:01:00 -0400

 Approved.  Please commit together with PR ports/147996.  No PORTREVISION 
 bump necessary for the base mail/dovecot port if these PRs are applied 
 together.  Thanks for the fix, Greg.
 
 -- 
 Yarema
State-Changed-From-To: feedback->closed 
State-Changed-By: sahil 
State-Changed-When: Mon Jul 5 05:47:32 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147988 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/147988: commit references a PR
Date: Mon,  5 Jul 2010 05:40:21 +0000 (UTC)

 sahil       2010-07-05 05:39:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/dovecot         Makefile distinfo 
   Log:
   - Use pre-su-install instead of pre-install target [1]
   - Update to 1.2.12 [2]
   
   PR:             ports/147988 [1], ports/147996 [2]
   Submitted by:   glewis@ [1], Denny Lin <dennylin93@hs.ntnu.edu.tw> [2]
   Approved by:    Yarema <yds@CoolRat.org> (maintainer)
                   wxs@/itetcu@ (mentors, implicit)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.114     +5 -4      ports/mail/dovecot/Makefile
   1.76      +6 -6      ports/mail/dovecot/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
