From nobody@FreeBSD.org  Sat Jun 12 00:13:03 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B484C1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jun 2010 00:13:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 54C8E8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jun 2010 00:13:03 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o5C0D2rL064036
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 12 Jun 2010 00:13:02 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o5C0D2TO064035;
	Sat, 12 Jun 2010 00:13:02 GMT
	(envelope-from nobody)
Message-Id: <201006120013.o5C0D2TO064035@www.freebsd.org>
Date: Sat, 12 Jun 2010 00:13:02 GMT
From: Chris Hilton <chris@vindaloo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: port: net-im/mu-conference fails to compile.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         147802
>Category:       ports
>Synopsis:       net-im/mu-conference fails to compile.
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    mm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 12 00:20:02 UTC 2010
>Closed-Date:    Mon Nov 22 15:50:44 UTC 2010
>Last-Modified:  Mon Nov 22 15:50:44 UTC 2010
>Originator:     Chris Hilton
>Release:        7.3-STABLE
>Organization:
Self
>Environment:
FreeBSD corellia.vindaloo.com 7.3-STABLE FreeBSD 7.3-STABLE #1: Fri May 14 21:33:57 EDT 2010     root@kamino:/usr/obj/usr/src/sys/CORELLIA  i386
>Description:
The port fails to compile because CFLAGS doesn't include "/usr/local/include" in the list of standard places to look for header files. Thus, the port can't find the expat.h header. 

I'll submit this PR then send the patch for the Makefiles that fixes it to the port maintainer.

-- Chris <chris@vindaloo.com>

>How-To-Repeat:
Try to compile the port
>Fix:
Fix the makefiles to use "-I/usr/local/include"

Patch attached with submission follows:

--- src/Makefile.orig	2007-07-16 18:05:44.000000000 -0400
+++ src/Makefile	2010-06-11 19:53:51.000000000 -0400
@@ -1,12 +1,12 @@
-CC:=gcc
-CFLAGS:=$(CFLAGS) -O2 -Wall -I../../lib -I../include `pkg-config --cflags glib-2.0` -D_JCOMP -D_REENTRANT -DLIBIDN
-#CFLAGS:=$(CFLAGS) -O2 -Wall -I../../lib -I../include `pkg-config --cflags glib-2.0` -D_JCOMP -D_REENTRANT -DLIBIDN -DHAVE_MYSQL
-LIBS:=$(LIBS) -ljcomp -lm `pkg-config --libs glib-2.0` `pkg-config --libs gthread-2.0` -lexpat -lidn
-#LIBS:=$(LIBS) -ljcomp -lm `pkg-config --libs glib-2.0` `pkg-config --libs gthread-2.0` -lexpat -lidn `mysql_config --libs`
+CC?=gcc
+CFLAGS+=  -Wall -I../../lib -I../include -I/usr/local/include `/usr/local/bin/pkg-config --cflags glib-2.0` -D_JCOMP -D_REENTRANT -DLIBIDN
+#CFLAGS:=  -Wall -I../../lib -I../include `/usr/local/bin/pkg-config --cflags glib-2.0` -D_JCOMP -D_REENTRANT -DLIBIDN -DHAVE_MYSQL
+LIBS:=$(LIBS) -ljcomp -lm `/usr/local/bin/pkg-config --libs glib-2.0` `/usr/local/bin/pkg-config --libs gthread-2.0` -lexpat -lidn
+#LIBS:=$(LIBS) -ljcomp -lm `/usr/local/bin/pkg-config --libs glib-2.0` `/usr/local/bin/pkg-config --libs gthread-2.0` -lexpat -lidn `mysql_config --libs`
 LDFLAGS:=-L.
 
 # Debug/Experimental
-#CFLAGS:=$(CFLAGS) -pipe -Os -I../../jabberd -I../include 
+#CFLAGS:= -pipe -Os -I../../jabberd -I../include 
 #LIBS:=$(LIBS) /usr/local/lib/ccmalloc-gcc.o -lccmalloc 
 #LIBS:=$(LIBS) -lmemusage
 #LIBS:=$(LIBS) -lmcheck
--- src/jabberd/Makefile.orig	2008-03-25 12:50:13.000000000 -0400
+++ src/jabberd/Makefile	2010-06-11 19:54:04.000000000 -0400
@@ -1,6 +1,6 @@
 
-CC=gcc
-CFLAGS:=$(CFLAGS) -O2 -Wall -I. -I../../include `pkg-config --cflags glib-2.0` -D_REENTRANT -DLIBIDN
+CC?=gcc
+CFLAGS+=  -Wall -I. -I../../include -I/usr/local/include `/usr/local/bin/pkg-config --cflags glib-2.0` -D_REENTRANT -DLIBIDN
 LIBS=
 
 JCOMP_LIB_OBJECTS=expat.o \
--- src/jcomp/Makefile.orig	2008-03-25 12:50:13.000000000 -0400
+++ src/jcomp/Makefile	2010-06-11 19:54:14.000000000 -0400
@@ -1,7 +1,7 @@
 
 #  $Id: Makefile,v 1.1 2005/12/06 14:48:49 peregrine Exp $
-CC=gcc
-CFLAGS:=$(CFLAGS) -O2 -Wall -I../../include -I. `pkg-config --cflags glib-2.0` -D_REENTRANT
+CC?=gcc
+CFLAGS+=  -Wall -I../../include -I. -I/usr/local/include `/usr/local/bin/pkg-config --cflags glib-2.0` -D_REENTRANT
 LIBS=
 
 JCOMP_OBJECTS=jcr_xdb.o \
@@ -15,7 +15,7 @@
 
 
 all: $(JCOMP_OBJECTS) main.o
-	gcc -g $(JCOMP_OBJECTS) main.o ../libjcomp.a `pkg-config --libs gthread-2.0` `pkg-config --libs glib-2.0` -o main
+	$(CC) -g $(JCOMP_OBJECTS) main.o ../libjcomp.a `/usr/local/bin/pkg-config --libs gthread-2.0` `/usr/local/bin/pkg-config --libs glib-2.0` -o main
 
 lib: $(JCOMP_OBJECTS)
 	@ar rv ../libjcomp.a $(JCOMP_OBJECTS)


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mm 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Jun 12 00:21:55 UTC 2010 
Responsible-Changed-Why:  
ports PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147802 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/147802: commit references a PR
Date: Thu,  9 Sep 2010 22:27:28 +0000 (UTC)

 mm          2010-09-09 22:27:23 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-im/mu-conference Makefile 
   Log:
   - Move -I${LOCALBASE}/include from main CFLAGS inside port's Makefiles
   - This is a cosmetic change only
   
   PR:             ports/147802
   Submitted by:   Chris Hilton <chris@vindaloo.com>
   
   Revision  Changes    Path
   1.14      +1 -3      ports/net-im/mu-conference/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: mm 
State-Changed-When: Mon Nov 22 15:50:43 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147802 
>Unformatted:
