From cjk32@cam.ac.uk  Mon Jun  7 09:44:15 2010
Return-Path: <cjk32@cam.ac.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 473041065678
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Jun 2010 09:44:15 +0000 (UTC)
	(envelope-from cjk32@cam.ac.uk)
Received: from chacal.cjkey.org.uk (chacal.cjkey.org.uk [88.97.163.217])
	by mx1.freebsd.org (Postfix) with ESMTP id C636C8FC24
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Jun 2010 09:44:14 +0000 (UTC)
Received: from chacal.wzl33 (localhost [127.0.0.1])
	by chacal.cjkey.org.uk (8.14.3/8.14.3) with ESMTP id o579iCWK020182
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 7 Jun 2010 10:44:12 +0100 (BST)
	(envelope-from chris@chacal.wzl33)
Received: (from chris@localhost)
	by chacal.wzl33 (8.14.3/8.14.3/Submit) id o579iC56020181;
	Mon, 7 Jun 2010 10:44:12 +0100 (BST)
	(envelope-from chris)
Message-Id: <201006070944.o579iC56020181@chacal.wzl33>
Date: Mon, 7 Jun 2010 10:44:12 +0100 (BST)
From: Christopher Key <cjk32@cam.ac.uk>
Reply-To: Christopher Key <cjk32@cam.ac.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: audio/squeezeboxserver should reopen logs on SIGHUP 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         147645
>Category:       ports
>Synopsis:       audio/squeezeboxserver should reopen logs on SIGHUP
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    scheidell
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 07 09:50:02 UTC 2010
>Closed-Date:    Sun Jan 08 01:26:51 UTC 2012
>Last-Modified:  Sun Jan  8 01:30:16 UTC 2012
>Originator:     Christopher Key
>Release:        FreeBSD 8.0-RELEASE-p2 amd64
>Organization:
>Environment:
System: FreeBSD chacal.wzl33 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #1: Thu Apr 1 21:31:00 BST 2010 root@chacal.wzl33:/usr/obj/usr/src/sys/CHACAL-DEBUG amd64


	
>Description:
Currently Squeezebox Server reopens its log files upon receiving SIGUSR1, whereas the newsyslog.conf entry causes SIGHUP to be sent.  As Squeezebox Server can be verbose in its logging, the lack of log rotation can lead to /var becoming full quickly.  Changing Squeezebox Server to respond to SIGHUP (rather than changing the signal sent by newsyslog) seems the most appropriate solution, maintaining compatibilty with FreeBSD standards.  It also avoids the need for the install script to correct an existing entry in newsyslog.conf.

>How-To-Repeat:
	
>Fix:
The attached patch implements the above changes.
	

--- patch-Slim-Utils-Log.pm begins here ---
--- Slim/Utils/Log.pm	2010-04-01 13:21:54.000000000 +0100
+++ Slim/Utils/Log.pm	2010-06-07 09:08:34.000000000 +0100
@@ -134,7 +134,7 @@
 	# Make sure recreate option is set if user has an existing log.conf
 	if ( !main::ISWINDOWS && !$ENV{NYTPROF} ) {
 		$config{'log4perl.appender.server.recreate'}              = 1;
-		$config{'log4perl.appender.server.recreate_check_signal'} = 'USR1';
+		$config{'log4perl.appender.server.recreate_check_signal'} = 'HUP';
 	}
 	
 	# Change to syslog if requested
@@ -985,7 +985,7 @@
 
 	if ( !main::ISWINDOWS && !$ENV{NYTPROF} ) {
 		$defaultAppenders{server}->{recreate}              = 1;
-		$defaultAppenders{server}->{recreate_check_signal} = 'USR1';
+		$defaultAppenders{server}->{recreate_check_signal} = 'HUP';
 	}
 
 	return $class->_fixupAppenders(\%defaultAppenders);
--- patch-Slim-Utils-Log.pm ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->brooks 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 7 09:50:12 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147645 
State-Changed-From-To: open->feedback 
State-Changed-By: miwi 
State-Changed-When: Sun Nov 6 16:04:40 UTC 2011 
State-Changed-Why:  
any news here 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147645 
Responsible-Changed-From-To: brooks->freebsd-ports-bugs 
Responsible-Changed-By: brooks 
Responsible-Changed-When: Mon Dec 5 18:42:15 UTC 2011 
Responsible-Changed-Why:  
Looks like a simple enough fix but I don't have the energy to deal with 
getting it fixed upstream and I've dropped maintainership. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147645 
State-Changed-From-To: feedback->open 
State-Changed-By: eadler 
State-Changed-When: Sun Dec 25 17:27:55 UTC 2011 
State-Changed-Why:  
Maintainer has approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147645 
Responsible-Changed-From-To: freebsd-ports-bugs->scheidell 
Responsible-Changed-By: scheidell 
Responsible-Changed-When: Fri Jan 6 22:10:36 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147645 
State-Changed-From-To: open->closed 
State-Changed-By: scheidell 
State-Changed-When: Sun Jan 8 01:26:32 UTC 2012 
State-Changed-Why:  
Committed with changes, Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147645 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/147645: commit references a PR
Date: Sun,  8 Jan 2012 01:26:21 +0000 (UTC)

 scheidell    2012-01-08 01:26:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/squeezeboxserver Makefile pkg-plist 
   Added files:
     audio/squeezeboxserver/files patch-Slim-Utils-Log.pm 
   Log:
   - reopen logs on SIGHUP
   
   PR:             ports/147645
   Submitted by:   Christopher Key <cjk32@cam.ac.uk>
   Approved by:    maintainer (timeout, 3 years) gabor (mentor)
   
   Revision  Changes    Path
   1.86      +3 -2      ports/audio/squeezeboxserver/Makefile
   1.1       +20 -0     ports/audio/squeezeboxserver/files/patch-Slim-Utils-Log.pm (new)
   1.26      +4 -4      ports/audio/squeezeboxserver/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
