From nobody@FreeBSD.org  Sat Jun  5 01:21:25 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2F4A01065678
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  5 Jun 2010 01:21:25 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 202C98FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  5 Jun 2010 01:21:25 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o551LO84032630
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 5 Jun 2010 01:21:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o551LOv0032629;
	Sat, 5 Jun 2010 01:21:24 GMT
	(envelope-from nobody)
Message-Id: <201006050121.o551LOv0032629@www.freebsd.org>
Date: Sat, 5 Jun 2010 01:21:24 GMT
From: Sunjae Park <darehanl@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Incorrect use of EXTRACT_BEFORE_ARGS in textproc/iso8879
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         147484
>Category:       ports
>Synopsis:       Incorrect use of EXTRACT_BEFORE_ARGS in textproc/iso8879
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kuriyama
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 05 01:30:01 UTC 2010
>Closed-Date:    Sun Jun 06 16:58:57 UTC 2010
>Last-Modified:  Sun Jun 06 16:58:57 UTC 2010
>Originator:     Sunjae Park
>Release:        8.0-RELEASE
>Organization:
>Environment:
FreeBSD bohanjae 8.0-RELEASE-p3 FreeBSD 8.0-RELEASE-p3 #0: Tue May 25 20:54:11 UTC 2010     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
When installing iso8897, 
# make install
===>  Installing for iso8879-1986_2
===>   iso8879-1986_2 depends on file: /usr/local/bin/xmlcatmgr - found
===>   Generating temporary packing list
===>  Checking if textproc/iso8879 already installed
 /usr/local/share/sgml/iso8879
Archive:  /usr/ports/distfiles/isoENTS.zip
caution: filename not matched:  -d
caution: filename not matched:  /usr/local/share/sgml/iso8879
*** Error code 11

EXTRACT_BEFORE_ARGS is defined "-dc" by default, so the unzip command line becomes:
/usr/local/bin/unzip -dc /usr/ports/distfiles/isoENTS.zip -d /usr/local/share/sgml/iso8879
>How-To-Repeat:
# make clean; make install
>Fix:
In the Makefile

@${UNZIP_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DISTFILES} -d ${INSTDIR}

to

@${UNZIP_CMD} -qo ${DISTDIR}/${DISTFILES} -d ${INSTDIR}

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kuriyama 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jun 5 01:30:14 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147484 

From: Eijiro Shibusawa <ej-sib@ice.uec.ac.jp>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/147484: Incorrect use of EXTRACT_BEFORE_ARGS in
 textproc/iso8879
Date: Sun, 6 Jun 2010 15:22:03 +0900

 This is a multi-part message in MIME format.
 
 --Multipart=_Sun__6_Jun_2010_15_22_03_+0900_PbcdwfBThLoZbFoZ
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 According to the portlint, using USE_ZIP macro may be preferable to fix the problem.
 If we set USE_ZIP macro, then an extract dependency on Unzip is added automatically, and the values of following macros are set appropriately.
  EXTRACT_SUFX
  EXTRACT_CMD
  EXTRACT_BEFORE_ARGS
 
 Regards
 
 --Multipart=_Sun__6_Jun_2010_15_22_03_+0900_PbcdwfBThLoZbFoZ
 Content-Type: text/plain;
  name="patch.txt"
 Content-Disposition: attachment;
  filename="patch.txt"
 Content-Transfer-Encoding: 7bit
 
 diff -ur /usr/ports/textproc/iso8879/Makefile ./Makefile
 --- /usr/ports/textproc/iso8879/Makefile	2010-06-04 06:18:10.000000000 +0900
 +++ ./Makefile	2010-06-06 14:50:35.000000000 +0900
 @@ -12,14 +12,13 @@
  MASTER_SITES=	${MASTER_SITE_LOCAL}
  MASTER_SITE_SUBDIR=	kuriyama
  DISTNAME=	isoENTS
 -EXTRACT_SUFX=	.zip
  
  MAINTAINER=	kuriyama@FreeBSD.org
  COMMENT=	Character entity sets from ISO 8879:1986 (SGML)
  
 -BUILD_DEPENDS=	unzip:${PORTSDIR}/archivers/unzip
  RUN_DEPENDS=	${XMLCATMGR}:${PORTSDIR}/textproc/xmlcatmgr
  
 +USE_ZIP=	yes
  EXTRACT_ONLY=	# empty
  NO_BUILD=	yes
  NO_WRKSUBDIR=	yes
 @@ -34,7 +33,7 @@
  	@[ -d ${INSTDIR} ] || ${MKDIR} ${INSTDIR}
  
  do-install:
 -	@${UNZIP_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DISTFILES} -d ${INSTDIR}
 +	@${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${DISTDIR}/${DISTFILES} -d ${INSTDIR}
  	@${INSTALL_DATA} ${FILESDIR}/catalog ${INSTDIR}/catalog
  	@${CHMOD} ${SHAREMODE} ${INSTDIR}/*
  	@${CHOWN} -R ${SHAREOWN}:${SHAREGRP} ${INSTDIR}
 
 --Multipart=_Sun__6_Jun_2010_15_22_03_+0900_PbcdwfBThLoZbFoZ--
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sun Jun 6 16:58:40 UTC 2010 
State-Changed-Why:  
I have fixed it the other way - replaced EXTRACT_BEFORE_ARGS with their literal value 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147484 
>Unformatted:
