From nobody@FreeBSD.org  Wed Jun  2 08:09:04 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5EB53106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Jun 2010 08:09:04 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 43E708FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Jun 2010 08:09:04 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o52893j6010477
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Jun 2010 08:09:04 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o5289359010470;
	Wed, 2 Jun 2010 08:09:03 GMT
	(envelope-from nobody)
Message-Id: <201006020809.o5289359010470@www.freebsd.org>
Date: Wed, 2 Jun 2010 08:09:03 GMT
From: Demelier David <demelier.david@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: emulators/snes9x-gtk does not recognize --with(out)-screenshot
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: root@cooltrainer.org

>Number:         147311
>Category:       ports
>Synopsis:       emulators/snes9x-gtk does not recognize --with(out)-screenshot
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 02 08:10:01 UTC 2010
>Closed-Date:    Tue Jun 29 07:49:32 UTC 2010
>Last-Modified:  Tue Jun 29 07:50:01 UTC 2010
>Originator:     Demelier David
>Release:        8.1-PRERELEASE
>Organization:
>Environment:
FreeBSD Melon.malikania.fr 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #1: Mon May 31 23:06:01 CEST 2010     root@Melon.malikania.fr:/usr/obj/usr/src/sys/Melon  amd64

>Description:
The emulators/snes9x-gtk configure script does not recognize --with(out)-screenshot option. Maybe the snes9x-gtk developers didn't remove this option and it's enabled by default (if libpng is found)

Because snes9x-gtk need libpng, screenshot feature will be enabled in any case. I propose the complete removal of the SCREENSHOT option.
>How-To-Repeat:
cd /usr/ports/emulators/snes9x-gtk
make config
# uncheck screenshot

make configure

make config
# check screenshot

make configure 

see : configure: WARNING: unrecognized options: --with-screenshot
see : configure: WARNING: unrecognized options: --without-screenshot

>Fix:
--- Makefile.orig	2010-06-02 09:40:26.000000000 +0200
+++ Makefile	2010-06-02 09:57:11.000000000 +0200
@@ -33,7 +33,6 @@
 
 OPTIONS=	DEBUG	"Enable debug information"	off \
 		OPENGL	"Enable OpenGL support"	off \
-		SCREENSHOT	"Enable screenshot support"	on \
 		X86_ASM	"Use i386 optimization (only for i386)"	on \
 		MMX	"Enable MMX (only for i386)"	off \
 		JMA	"Enable JMA archive decompression support"	on \
@@ -71,13 +70,6 @@
 CONFIGURE_ARGS+=	--without-opengl
 .endif
 
-.if !defined(WITHOUT_SCREENSHOT)
-LIB_DEPENDS+=	png.6:${PORTSDIR}/graphics/png
-CONFIGURE_ARGS+=	--with-screenshot
-.else
-CONFIGURE_ARGS+=	--without-screenshot
-.endif
-
 .if !defined(WITHOUT_JMA)
 CONFIGURE_ARGS+=	--with-jma-decomp
 .else


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Jun 2 08:10:11 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147311 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: root@cooltrainer.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/147311: emulators/snes9x-gtk does not recognize --with(out)-screenshot
Date: Wed, 2 Jun 2010 08:10:09 UT

 Maintainer of emulators/snes9x-gtk,
 
 Please note that PR ports/147311 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147311
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: stefan 
State-Changed-When: Tue Jun 29 07:49:18 UTC 2010 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147311 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/147311: commit references a PR
Date: Tue, 29 Jun 2010 07:49:08 +0000 (UTC)

 stefan      2010-06-29 07:48:59 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/snes9x-gtk Makefile 
   Log:
   Remove screenshot option, which is unconditionally enabled, anyway.
   
   PR:             147311
   Submitted by:   Demelier David <demelier.david@gmail.com>
   Approved by:    maintainer timeout (>3 weeks)
   Feature safe:   yes
   
   Revision  Changes    Path
   1.6       +0 -8      ports/emulators/snes9x-gtk/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
