From amdmi3@amdmi3.ru  Wed Jun  2 03:29:59 2010
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D57D1065672
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  2 Jun 2010 03:29:59 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15])
	by mx1.freebsd.org (Postfix) with ESMTP id BC72E8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  2 Jun 2010 03:29:58 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.71)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1OJeeS-0004J4-GA
	for FreeBSD-gnats-submit@freebsd.org; Wed, 02 Jun 2010 07:29:56 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 04170B84D
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  2 Jun 2010 07:29:56 +0400 (MSD)
Received: by hades.panopticon (Postfix, from userid 1000)
	id DF6B1B84B; Wed,  2 Jun 2010 07:29:55 +0400 (MSD)
Message-Id: <20100602032955.DF6B1B84B@hades.panopticon>
Date: Wed,  2 Jun 2010 07:29:55 +0400 (MSD)
From: Dmitry Marakasov <amdmi3@FreeBSD.org>
Reply-To: Dmitry Marakasov <amdmi3@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: audio/sdl_sound: hidden dependency on libmodplug
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         147305
>Category:       ports
>Synopsis:       audio/sdl_sound: hidden dependency on libmodplug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mva
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 02 03:40:03 UTC 2010
>Closed-Date:    Wed Jun 02 19:04:52 UTC 2010
>Last-Modified:  Wed Jun  2 19:10:02 UTC 2010
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 8.0-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #2: Wed Jun 2 02:28:21 MSD 2010 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386


>Description:
sdl_sound lacks a dependency on libmodplug, and a corresponding option.

% cd /usr/ports/audio/sdl_sound
% grep -R modplug . |wc -l
	0
% make extract
% grep -R modplug . |wc -l
     153
% work/SDL_sound-1.0.3/configure --help | gerp modplug
  --enable-modplug           enable MOD decoding via modplug default=yes
% ldd /usr/local/lib/libSDL_sound.so | grep modplug
	libmodplug.so.0 => /usr/local/lib/compat/pkg/libmodplug.so.0 (0x28662000)

>How-To-Repeat:
>Fix:

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mva 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Jun 2 03:40:14 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147305 
State-Changed-From-To: open->closed 
State-Changed-By: mva 
State-Changed-When: Wed Jun 2 19:04:51 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147305 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/147305: commit references a PR
Date: Wed,  2 Jun 2010 19:03:12 +0000 (UTC)

 mva         2010-06-02 19:03:02 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/sdl_sound      Makefile 
   Log:
   Fix missing libmodplug dependency and add an OPTIONS knob for it.
   
   PR:             ports/147305
   Submitted by:   amdmi3
   
   Revision  Changes    Path
   1.39      +15 -8     ports/audio/sdl_sound/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
