From nobody@FreeBSD.org  Tue Jun  1 15:32:31 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A0897106567B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  1 Jun 2010 15:32:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8FFDB8FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  1 Jun 2010 15:32:31 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o51FWVsK091393
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 1 Jun 2010 15:32:31 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o51FWVEn091391;
	Tue, 1 Jun 2010 15:32:31 GMT
	(envelope-from nobody)
Message-Id: <201006011532.o51FWVEn091391@www.freebsd.org>
Date: Tue, 1 Jun 2010 15:32:31 GMT
From: Anatoly Borodin <anatoly.borodin@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: comms/gnokii does not build
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: mad@madpilot.net

>Number:         147288
>Category:       ports
>Synopsis:       comms/gnokii does not build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 01 15:40:01 UTC 2010
>Closed-Date:    Sat Jun 05 11:26:49 UTC 2010
>Last-Modified:  Sat Jun  5 11:30:07 UTC 2010
>Originator:     Anatoly Borodin
>Release:        
>Organization:
>Environment:
>Description:
comms/gnokii does not build.
>How-To-Repeat:
# cd /usr/ports/comms/gnokii && make showconfig && make

===> The following configuration options are available for gnokii-0.6.29_1,1:
     ICAL=on "Build with IETF iCal support"
     USB=on "Build with libusb support"
     PCSC=on "Build with PC/SC-Lite support"
     SMSD=on "Enable smsd daemon"
     MYSQL=on "Enable MySQL support for smsd"
     PGSQL=on "Enable PostgreSQL support for smsd"
     X11=on "Build graphical version (xgnokii)"
===> Use 'make config' to modify these settings
===>  License check disabled, port has not defined LICENSE
===>  Found saved configuration for gnokii-0.6.29_1,1
===>  Extracting for gnokii-0.6.29_1,1
=> MD5 Checksum OK for gnokii-0.6.29.tar.bz2.
=> SHA256 Checksum OK for gnokii-0.6.29.tar.bz2.
===>  Patching for gnokii-0.6.29_1,1
===>  Applying FreeBSD patches for gnokii-0.6.29_1,1
===>   gnokii-0.6.29_1,1 depends on file: /usr/local/lib/perl5/site_perl/5.10.1/mach/XML/Parser.pm - found
===>   gnokii-0.6.29_1,1 depends on executable: gmake - found
===>   gnokii-0.6.29_1,1 depends on file: /usr/local/libdata/pkgconfig/xpm.pc - found
===>   gnokii-0.6.29_1,1 depends on file: /usr/local/bin/intltool-extract - found
===>   gnokii-0.6.29_1,1 depends on executable: pkg-config - found
===>   gnokii-0.6.29_1,1 depends on shared library: ical.44 - found
===>   gnokii-0.6.29_1,1 depends on shared library: pcsclite.1 - found
===>   gnokii-0.6.29_1,1 depends on shared library: intl - found
===>   gnokii-0.6.29_1,1 depends on shared library: mysqlclient.16 - found
===>   gnokii-0.6.29_1,1 depends on shared library: pq.5 - found
===>   gnokii-0.6.29_1,1 depends on shared library: atk-1.0.0 - found
===>   gnokii-0.6.29_1,1 depends on shared library: glib-2.0.0 - found
===>   gnokii-0.6.29_1,1 depends on shared library: gtk-x11-2.0.0 - found
===>   gnokii-0.6.29_1,1 depends on shared library: pango-1.0.0 - found
===>  Configuring for gnokii-0.6.29_1,1
..
/bin/sh ../../libtool   --tag=CC   --mode=compile cc -DCOMPILING_LIBGNOKII -I. -I../../include   -I/usr/local/include -I/usr/local/include -I../../include -D_THREAD_SAFE -I/usr/local/include/PCSC   -O2 -pipe -march=native -fno-strict-aliasing -Wall -Wno-pointer-sign -fvisibility=hidden -fno-strict-aliasing   -MT libPHONES_la-pcsc.lo -MD -MP -MF .deps/libPHONES_la-pcsc.Tpo -c -o libPHONES_la-pcsc.lo `test -f 'pcsc.c' || echo './'`pcsc.c
libtool: compile:  cc -DCOMPILING_LIBGNOKII -I. -I../../include -I/usr/local/include -I/usr/local/include -I../../include -D_THREAD_SAFE -I/usr/local/include/PCSC -O2 -pipe -march=native -fno-strict-aliasing -Wall -Wno-pointer-sign -fvisibility=hidden -fno-strict-aliasing -MT libPHONES_la-pcsc.lo -MD -MP -MF .deps/libPHONES_la-pcsc.Tpo -c pcsc.c  -fPIC -DPIC -o .libs/libPHONES_la-pcsc.o
pcsc.c: In function 'get_gn_error':
pcsc.c:202: error: 'SCARD_W_INSERTED_CARD' undeclared (first use in this function)
pcsc.c:202: error: (Each undeclared identifier is reported only once
pcsc.c:202: error: for each function it appears in.)
gmake[2]: *** [libPHONES_la-pcsc.lo] Error 1
gmake[2]: *** Waiting for unfinished jobs....
mv -f .deps/libPHONES_la-gnapplet.Tpo .deps/libPHONES_la-gnapplet.Plo
gmake[2]: Leaving directory `/usr/obj/usr/ports/comms/gnokii/work/gnokii-0.6.29/common/phones'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/obj/usr/ports/comms/gnokii/work/gnokii-0.6.29/common'
gmake: *** [all-recursive] Error 1
*** Error code 1

Stop in /usr/ports/comms/gnokii.
*** Error code 1

Stop in /usr/ports/comms/gnokii.

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jun 1 15:40:10 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147288 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: mad@madpilot.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/147288: comms/gnokii does not build
Date: Tue, 1 Jun 2010 15:40:08 UT

 Maintainer of comms/gnokii,
 
 Please note that PR ports/147288 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/147288
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Guido Falsi <mad@madpilot.net>
To: bug-followup@FreeBSD.org, anatoly.borodin@gmail.com
Cc:  
Subject: Re: ports/147288: comms/gnokii does not build
Date: Fri, 04 Jun 2010 15:33:01 +0200

 This is a multi-part message in MIME format.
 --------------070108050704010509070609
 Content-Type: text/plain; charset=ISO-8859-15; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Hi!
 
 The SCARD_W_INSERTED_CARD define was simply removed with no substitute 
 from the pcsc-lite defines with the update to 1.6.0. [1] [2]
 
 I'm attaching a patch which fixes build by not checking for such a 
 return code from pcsc(which reasonably should not return it back anymore 
 not having defined it).
 
 This quick fix should be tested by someone using the pcsc gnokii 
 functionality which I'm not able to test.
 
 Also already sent information and simple patch upstream.
 
 Added file:
 
 gnokii/files/patch-common-phones-pcsc.c
 
 
 
 [1] 
 http://svn.debian.org/viewsvn/pcsclite/trunk/PCSC/src/PCSC/pcsclite.h.in?view=log
 
 [2] 
 http://svn.debian.org/viewsvn/pcsclite/trunk/PCSC/src/PCSC/pcsclite.h.in?r1=4544&r2=4574 
 
 
 -- 
 Guido Falsi <mad@madpilot.net>
 
 --------------070108050704010509070609
 Content-Type: text/plain;
  name="gnokii.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="gnokii.diff"
 
 diff -ruN gnokii.old/files/patch-common-phones-pcsc.c gnokii/files/patch-common-phones-pcsc.c
 --- gnokii.old/files/patch-common-phones-pcsc.c	1970-01-01 01:00:00.000000000 +0100
 +++ gnokii/files/patch-common-phones-pcsc.c	2010-06-04 15:16:29.846724231 +0200
 @@ -0,0 +1,10 @@
 +--- common/phones/pcsc.c.orig	2010-06-04 15:08:13.000466080 +0200
 ++++ common/phones/pcsc.c	2010-06-04 15:15:44.926057193 +0200
 +@@ -199,7 +199,6 @@
 + 	case SCARD_W_UNPOWERED_CARD:
 + 	case SCARD_W_RESET_CARD:
 + 	case SCARD_W_REMOVED_CARD:
 +-	case SCARD_W_INSERTED_CARD:
 + 	 	return GN_ERR_SIMPROBLEM;
 + 	case SCARD_E_NO_MEMORY:
 + 		return GN_ERR_MEMORYFULL;
 
 --------------070108050704010509070609--

From: Anatoly Borodin <anatoly.borodin@gmail.com>
To: Guido Falsi <mad@madpilot.net>
Cc: bug-followup@freebsd.org
Subject: Re: ports/147288: comms/gnokii does not build
Date: Sat, 5 Jun 2010 02:20:51 +0200

 --000325553f06b2a6bd04883d6a73
 Content-Type: text/plain; charset=UTF-8
 
 Hi!
 
 > Also already sent information and simple patch upstream.
 
 Ok, I agree. But I would prefer the other patch attached.
 
 --000325553f06b2a6bd04883d6a73
 Content-Type: text/plain; charset=US-ASCII; name="0001-comms-gnokii-build-fixed.txt"
 Content-Disposition: attachment; 
 	filename="0001-comms-gnokii-build-fixed.txt"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_ga1p5vwn1
 
 RnJvbSAwM2QyNjhiODhmNTJhMWJjMGM3OWM2N2QxMTIwNWI0MTdlZDA2YjQ3IE1vbiBTZXAgMTcg
 MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmF0b2x5IEJvcm9kaW4gPGFuYXRvbHkuYm9yb2RpbkBnbWFp
 bC5jb20+CkRhdGU6IEZyaSwgNCBKdW4gMjAxMCAyMTowNToxNyArMDIwMApTdWJqZWN0OiBbUEFU
 Q0hdIGNvbW1zL2dub2tpaTogYnVpbGQgZml4ZWQuCgotLS0KIGNvbW1zL2dub2tpaS9maWxlcy9w
 YXRjaC1jb21tb24tcGhvbmVzLXBjc2MuYyB8ICAgMTIgKysrKysrKysrKysrCiAxIGZpbGVzIGNo
 YW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2
 NDQgY29tbXMvZ25va2lpL2ZpbGVzL3BhdGNoLWNvbW1vbi1waG9uZXMtcGNzYy5jCgpkaWZmIC0t
 Z2l0IGNvbW1zL2dub2tpaS9maWxlcy9wYXRjaC1jb21tb24tcGhvbmVzLXBjc2MuYyBjb21tcy9n
 bm9raWkvZmlsZXMvcGF0Y2gtY29tbW9uLXBob25lcy1wY3NjLmMKbmV3IGZpbGUgbW9kZSAxMDA2
 NDQKaW5kZXggMDAwMDAwMC4uOGRhMzQ4NwotLS0gL2Rldi9udWxsCisrKyBjb21tcy9nbm9raWkv
 ZmlsZXMvcGF0Y2gtY29tbW9uLXBob25lcy1wY3NjLmMKQEAgLTAsMCArMSwxMiBAQAorLS0tIGNv
 bW1vbi9waG9uZXMvcGNzYy5jLm9yaWcJMjAxMC0wNi0wNCAxNTowODoxMy4wMDA0NjYwODAgKzAy
 MDAKKysrKyBjb21tb24vcGhvbmVzL3Bjc2MuYwkyMDEwLTA2LTA0IDE1OjE1OjQ0LjkyNjA1NzE5
 MyArMDIwMAorQEAgLTE5OSw3ICsxOTksOSBAQAorIAljYXNlIFNDQVJEX1dfVU5QT1dFUkVEX0NB
 UkQ6CisgCWNhc2UgU0NBUkRfV19SRVNFVF9DQVJEOgorIAljYXNlIFNDQVJEX1dfUkVNT1ZFRF9D
 QVJEOgorKy8qIHJlbW92ZWQgZnJvbSBwY3NjLWxpdGUKKyAJY2FzZSBTQ0FSRF9XX0lOU0VSVEVE
 X0NBUkQ6CisrKi8KKyAJIAlyZXR1cm4gR05fRVJSX1NJTVBST0JMRU07CisgCWNhc2UgU0NBUkRf
 RV9OT19NRU1PUlk6CisgCQlyZXR1cm4gR05fRVJSX01FTU9SWUZVTEw7Ci0tIAoxLjcuMQoK
 --000325553f06b2a6bd04883d6a73--

From: Guido Falsi <mad@madpilot.net>
To: Anatoly Borodin <anatoly.borodin@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/147288: comms/gnokii does not build
Date: Sat, 05 Jun 2010 11:40:22 +0200

 On 06/05/10 02:20, Anatoly Borodin wrote:
 > Hi!
 >
 >> Also already sent information and simple patch upstream.
 >
 > Ok, I agree. But I would prefer the other patch attached.
 
 Yes, this one is cleaner. I did not think about it.
 
 I approve the patch.
 
 -- 
 Guido Falsi <mad@madpilot.net>
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Sat Jun 5 10:13:26 UTC 2010 
State-Changed-Why:  
Newer patch approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147288 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Jun 5 11:26:48 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147288 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/147288: commit references a PR
Date: Sat,  5 Jun 2010 11:26:45 +0000 (UTC)

 miwi        2010-06-05 11:26:36 UTC
 
   FreeBSD ports repository
 
   Added files:
     comms/gnokii/files   patch-common-phones-pcsc.c 
   Log:
   - Fix build
   
   PR:             147288
   Submitted by:   Anatoly Borodin <anatoly.borodin@gmail.com>
   Approved by:    maintianer
   
   Revision  Changes    Path
   1.1       +12 -0     ports/comms/gnokii/files/patch-common-phones-pcsc.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
