From nobody@FreeBSD.org  Tue May 25 19:17:38 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A29D8106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 May 2010 19:17:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 78CDE8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 May 2010 19:17:38 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o4PJHcN8008082
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 May 2010 19:17:38 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o4PJHbtB008081;
	Tue, 25 May 2010 19:17:38 GMT
	(envelope-from nobody)
Message-Id: <201005251917.o4PJHbtB008081@www.freebsd.org>
Date: Tue, 25 May 2010 19:17:38 GMT
From: Henrik Hudson <rhavenn@rhavenn.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: lxpanel Makefile forces include of ALSA
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         146975
>Category:       ports
>Synopsis:       x11/lxpanel Makefile forces include of ALSA
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 25 19:20:01 UTC 2010
>Closed-Date:    Sat Jun 05 20:03:21 UTC 2010
>Last-Modified:  Thu Jul  8 23:00:12 UTC 2010
>Originator:     Henrik Hudson
>Release:        8.1-PRE amd64
>Organization:
>Environment:
>Description:
The lxpanel port Makefile contains:
WITH_ALSA=yes

This over-rides any options toggled in the "options" section and forces the install of ALSA no matter what the options have been set to.


>How-To-Repeat:
try to install lxpanel from ports
>Fix:
remove WITH_ALSA from the Makefile and let it rely on the "options"

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Jun 5 20:03:20 UTC 2010 
State-Changed-Why:  
we have now alsa in ports. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146975 

From: Henrik Hudson <rhavenn@rhavenn.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/146975: x11/lxpanel Makefile forces include of ALSA
Date: Thu, 8 Jul 2010 14:37:48 -0800

 I realize that ALSA is available.
 
 However, I don't want ALSA. The Makefile has the following:
 OPTIONS=        ALSA "enable ALSA audio architecture support" Off \
                 NLS "NLS support" On
 
 USE_XORG=       x11 xmu
 USE_GNOME=      gtk20 gnomedesktop gnomeprefix libgnome
 GNU_CONFIGURE=  yes
 USE_AUTOTOOLS=  automake:110:env
 CONFIGURE_ARGS= --prefix=${PREFIX} \
                 CPPFLAGS="-I${LOCALBASE}/include" \
                 LDFLAGS="-L${LOCALBASE}/lib"
 CFLAGS+=        -I${WRKSRC}
 USE_GMAKE=      yes
 
 MAN1=           lxpanel.1 lxpanelctl.1
 WITH_ALSA=      yes
 
 So, you're allowing the user to toggle the ALSA option with "make
 config", yet you still hard-code WITH_ALSA=yes which rather defeats
 the purpose of having the OPTIONS= for ALSA.
 
 I don't want to pull in the linux dependencies for ALSA.
 
 Make sense?
 
 henrik
 -- 
 Henrik Hudson
 rhavenn@rhavenn.net
 -------------------------------------------------
 "There are 10 kinds of people in the world: Those
 who understand binary and those who don't..."
>Unformatted:
