From swell.k@gmail.com  Tue May 25 09:59:54 2010
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 69CEE106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 May 2010 09:59:54 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-ew0-f209.google.com (mail-ew0-f209.google.com [209.85.219.209])
	by mx1.freebsd.org (Postfix) with ESMTP id EDFAC8FC1D
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 May 2010 09:59:53 +0000 (UTC)
Received: by ewy1 with SMTP id 1so404503ewy.13
        for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 May 2010 02:59:52 -0700 (PDT)
Received: by 10.213.32.197 with SMTP id e5mr383384ebd.92.1274781592766;
        Tue, 25 May 2010 02:59:52 -0700 (PDT)
Received: from localhost ([89.248.169.109])
        by mx.google.com with ESMTPS id 13sm2330664ewy.13.2010.05.25.02.59.49
        (version=SSLv3 cipher=RC4-MD5);
        Tue, 25 May 2010 02:59:52 -0700 (PDT)
Message-Id: <86632cpaiv.fsf@gmail.com>
Date: Tue, 25 May 2010 13:59:20 +0400
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] devel/git: strip(1) binaries by default for non-debug builds

>Number:         146961
>Category:       ports
>Synopsis:       [patch] devel/git: strip(1) binaries by default for non-debug builds
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 25 10:00:05 UTC 2010
>Closed-Date:    Sun Jul 04 18:51:26 UTC 2010
>Last-Modified:  Fri Nov 19 07:10:10 UTC 2010
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
Mimic bsd.port.mk behavior. This should depend on whether ${STRIP} has
`-s', though. Even better would be to strip binaries by install(1),
e.g. by using BSD_INSTALL_PROGRAM.
--- a.diff begins here ---
Index: devel/git/Makefile
===================================================================
RCS file: /a/.cvsup/ports/devel/git/Makefile,v
retrieving revision 1.86
diff -u -p -r1.86 Makefile
--- devel/git/Makefile	7 May 2010 02:43:37 -0000	1.86
+++ devel/git/Makefile	25 May 2010 09:48:49 -0000
@@ -198,6 +198,10 @@ OPTIONS=	GUI "Enable building of GUI too
 
 .include <bsd.port.options.mk>
 
+.if !defined(WITH_DEBUG)
+ALL_TARGET=	all strip
+.endif
+
 .ifdef (WITH_PERL)
 USE_PERL5=	yes
 MAKE_ENV+=	PERL_PATH=${PERL}
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue May 25 10:00:28 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146961 
State-Changed-From-To: open->closed 
State-Changed-By: wxs 
State-Changed-When: Sun Jul 4 18:51:25 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146961 

From: Anonymous <swell.k@gmail.com>
To: bug-followup@freebsd.org
Cc: freebsd-ports-bugs@freebsd.org
Subject: Re: ports/146961: [patch] devel/git: strip(1) binaries by default for non-debug builds
Date: Fri, 19 Nov 2010 10:02:48 +0300

 Hmm, it's better to use same check as in ports/150689.
 
 WITH_DEBUG is for things like -DDEBUG, i.e. compile-time optimization
 that hurts performance while debug symbols usually do not.
 
 --- a.diff begins here ---
 Index: devel/git/Makefile
 ===================================================================
 RCS file: /a/.cvsup/ports/devel/git/Makefile,v
 retrieving revision 1.94
 diff -u -p -r1.94 Makefile
 --- devel/git/Makefile	23 Oct 2010 15:07:55 -0000	1.94
 +++ devel/git/Makefile	26 Oct 2010 19:32:27 -0000
 @@ -195,7 +195,7 @@ OPTIONS=	GUI "Enable building of GUI too
  
  .include <bsd.port.options.mk>
  
 -.ifndef (WITH_DEBUG)
 +.ifdef (STRIP) && ${STRIP} != ""
  ALL_TARGET=	all strip
  .endif
  
 --- a.diff ends here ---
>Unformatted:
