From nobody@FreeBSD.org  Thu May 20 17:47:26 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2A49B1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 May 2010 17:47:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 194BA8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 May 2010 17:47:26 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o4KHlPnQ047339
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 May 2010 17:47:25 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o4KHlPox047338;
	Thu, 20 May 2010 17:47:25 GMT
	(envelope-from nobody)
Message-Id: <201005201747.o4KHlPox047338@www.freebsd.org>
Date: Thu, 20 May 2010 17:47:25 GMT
From: Ricky Morse <remorse@partners.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] misc/amanda-server requires net/samba3 with no way to use other samba ports
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         146769
>Category:       ports
>Synopsis:       [patch] misc/amanda-server requires net/samba3 with no way to use other samba ports
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kuriyama
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 20 17:50:02 UTC 2010
>Closed-Date:    Sat May 22 11:41:33 UTC 2010
>Last-Modified:  Sat May 22 11:50:03 UTC 2010
>Originator:     Ricky Morse
>Release:        8.0-RELEASE-p2/amd64
>Organization:
MGH Biostatistics Center
>Environment:
FreeBSD hedwig.mgh.harvard.edu 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Tue Jan  5 21:11:58 UTC 2010     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
If the "SAMBA" option is provided to the misc/amanda-server port, it requires the installation of net/samba3. There are several newer ports available (net/samba32, net/samba33, net/samba34). The port's makefile should allow this to be overruled.
>How-To-Repeat:
Install net/samba34, then misc/amanda-server with the SAMBA option. This will then start installing net/samba3.
>Fix:
I"ve attached a patch that allows the samba port used to be overridden (e.g. in /usr/local/etc/ports.conf).

Patch attached with submission follows:

--- Makefile.orig	2010-05-20 12:08:57.000000000 -0400
+++ Makefile	2010-05-20 12:09:02.000000000 -0400
@@ -125,8 +125,9 @@
 .endif
 
 .if defined (WITH_SAMBA)
-BUILD_DEPENDS+=	smbclient:${PORTSDIR}/net/samba34
-RUN_DEPENDS+=	smbclient:${PORTSDIR}/net/samba34
+SAMBA_PORT?=samba3
+BUILD_DEPENDS+=	smbclient:${PORTSDIR}/net/${SAMBA_PORT}
+RUN_DEPENDS+=	smbclient:${PORTSDIR}/net/s${SAMBA_PORT}
 CONFIGURE_ARGS+=	--with-smbclient=${PREFIX}/bin/smbclient
 .endif
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kuriyama 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 20 17:50:17 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146769 
State-Changed-From-To: open->closed 
State-Changed-By: kuriyama 
State-Changed-When: Sat May 22 11:41:21 UTC 2010 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146769 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/146769: commit references a PR
Date: Sat, 22 May 2010 11:41:05 +0000 (UTC)

 kuriyama    2010-05-22 11:40:51 UTC
 
   FreeBSD ports repository
 
   Modified files:
     misc/amanda-server   Makefile 
   Added files:
     misc/amanda-server/files patch-common-src::glib-util.c 
   Log:
   - Add workaround for glib-2.24 [1].
   - Allow to choose samba port [2].
   
   PR:             ports/146768 [1], ports/146769 [2]
   Submitted by:   Ricky Morse <remorse@partners.org> [1,2]
   
   Revision  Changes    Path
   1.118     +4 -3      ports/misc/amanda-server/Makefile
   1.1       +51 -0     ports/misc/amanda-server/files/patch-common-src::glib-util.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
