From nobody@FreeBSD.org  Thu May 20 10:48:56 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E372106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 May 2010 10:48:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1D9A98FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 May 2010 10:48:56 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o4KAmtAf027697
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 20 May 2010 10:48:55 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o4KAmtkT027696;
	Thu, 20 May 2010 10:48:55 GMT
	(envelope-from nobody)
Message-Id: <201005201048.o4KAmtkT027696@www.freebsd.org>
Date: Thu, 20 May 2010 10:48:55 GMT
From: Mike Makonnen <mtm@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: VirtualBox assertion: Lock/Unlock is not implemented
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         146752
>Category:       ports
>Synopsis:       [patch] emulators/virtualbox-ose: VirtualBox assertion: Lock/Unlock is not implemented
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    vbox
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 20 10:50:00 UTC 2010
>Closed-Date:    Mon Jun 07 16:34:37 UTC 2010
>Last-Modified:  Mon Jun  7 16:40:03 UTC 2010
>Originator:     Mike Makonnen
>Release:        FreeBSD 9-CURRENT
>Organization:
>Environment:
FreeBSD rogue.mike.lan 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r208116: Sat May 15 23:38:15 EAT 2010     mtm@rogue.mike.lan:/data/build/obj/data/build/src/sys/ROGUE  amd64
>Description:
When trying to install Windows XP SP2 as a guest OS from the hosts DVD drive the following assertion is triggered right after the setup program finishes loading drivers: Lock/Unlock is not implemented.  I noticed this after the recent upgrade to VirtualBox 3.1.8.  I also did a world and kernel upgrade in the mean time so I'm not sure if that may have had something to do with it. The Host is a 9-Current amd64 box.
>How-To-Repeat:
Try to install Windows XP as a guest OS from a DVD Drive.
>Fix:
The problem is a missing compile time #define that makes it think FreeBSD doesn't support locking of the DVD drive door. The attached patch fixes the problem for me.

Patch attached with submission follows:

--- src/VBox/Devices/Storage/DrvHostDVD.cpp.orig	2010-05-20 10:28:06.000000000 +0300
+++ src/VBox/Devices/Storage/DrvHostDVD.cpp	2010-05-20 10:37:47.000000000 +0300
@@ -224,7 +224,7 @@
  */
 static DECLCALLBACK(int) drvHostDvdDoLock(PDRVHOSTBASE pThis, bool fLock)
 {
-#ifdef RT_OS_DARWIN
+#if defined(RT_OS_FREEBSD) || defined(RT_OS_DARWIN)
     uint8_t abCmd[16] =
     {
         SCSI_PREVENT_ALLOW_MEDIUM_REMOVAL, 0, 0, 0, fLock, 0,


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->vbox 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu May 20 15:42:14 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146752 

From: Beat Gaetzi <beat@FreeBSD.org>
To: bug-followup@FreeBSD.org, mtm@FreeBSD.org
Cc:  
Subject: Re: ports/146752: [patch] emulators/virtualbox-ose: VirtualBox assertion:
 Lock/Unlock is not implemented
Date: Tue, 25 May 2010 13:50:18 +0200

 Hi,
 
 Thanks for this patch. I've added the patch to our development repository:
 http://svn.bluelife.at/index.cgi/blueports/revision/?rev=842
 
 The patch will be included in the upcoming 3.2.0 update.
 
 Regards,
 Beat
State-Changed-From-To: open->closed 
State-Changed-By: beat 
State-Changed-When: Mon Jun 7 16:34:36 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146752 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/146752: commit references a PR
Date: Mon,  7 Jun 2010 16:32:14 +0000 (UTC)

 beat        2010-06-07 16:31:58 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/virtualbox-ose Makefile distinfo pkg-plist 
     emulators/virtualbox-ose/files patch-configure 
                                    patch-src-VBox-Devices-Makefile.kmk 
                                    patch-src-VBox-HostDrivers-Makefile.kmk 
   Added files:
     emulators/virtualbox-ose/files 
                                    patch-src-VBox-Devices-Storage-DrvHostDVD.cpp 
                                    patch-src-VBox-Frontends-Makefile.kmk 
                                    patch-src-VBox-Frontends-VirtualBox-src-settings-vm-VBoxVMSettingsHD.h 
   Removed files:
     emulators/virtualbox-ose/files patch-include-iprt-file.h 
                                    patch-src-VBox-Additions-common-VBoxService-VBoxService.cpp 
                                    patch-src-VBox-Devices-Audio-audio.c 
                                    patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp 
                                    patch-src-VBox-Frontends-VBoxManage-VBoxManageHelp.cpp 
                                    patch-src-VBox-Frontends-VBoxManage-VBoxManageModifyVM.cpp 
                                    patch-src-VBox-Main-AudioAdapterImpl.cpp 
                                    patch-src-VBox-Main-ConsoleImpl.cpp 
                                    patch-src-VBox-Main-ConsoleImpl2.cpp 
                                    patch-src-VBox-Main-include-ConsoleImpl.h 
                                    patch-src-VBox-Runtime-r3-posix-fileio-posix.cpp 
                                    patch-src-settings-vm-VBoxVMSettingsAudio.cpp 
                                    pkg-install.in 
   Log:
   - Update to 3.2.2
   - Update guest additions to 3.2.2.
   - Add option to build with VNC support (Disabled by default)
   - Add option to build with VDE support (Disabled by default) [1]
   - Add option to build webservice (Disabled by default) [2]
   - Fix build with QT4 support disabled and X11 support enabled. [3]
   - Fix build with X11 support disabled. [4]
   - Replace custom pkg-install.in script with GROUPS framework.
   - Do not build Guest Additions in virtualbox-ose port.
   - Implement locking/unlocking of host DVD drive. [5]
   - Add LICENSE and LICENSE_FILE.
   
   PR:             ports/146752 [5]
   Submitted by:   mtm@ [5]
   Requested by:   Mario Lobo <lobo AT bsd.com.br> [1],
                   Hubert Tournier <hubert AT frbsd.org> [2]
   Reported by:    Emil Mikulic <emil AT dmr.ath.cx> [3], mm@ [4]
   
   Many thanks to the VirtualBox developers (especially Alexander Eichner
   for all his work and help), all tester and patch submitter and the whole
   vbox@ team especially decke@.
   
   Revision  Changes    Path
   1.23      +45 -13    ports/emulators/virtualbox-ose/Makefile
   1.11      +6 -6      ports/emulators/virtualbox-ose/distinfo
   1.6       +2 -48     ports/emulators/virtualbox-ose/files/patch-configure
   1.2       +0 -13     ports/emulators/virtualbox-ose/files/patch-include-iprt-file.h (dead)
   1.2       +0 -12     ports/emulators/virtualbox-ose/files/patch-src-VBox-Additions-common-VBoxService-VBoxService.cpp (dead)
   1.2       +0 -14     ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Audio-audio.c (dead)
   1.5       +0 -11     ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Makefile.kmk
   1.1       +14 -0     ports/emulators/virtualbox-ose/files/patch-src-VBox-Devices-Storage-DrvHostDVD.cpp (new)
   1.1       +18 -0     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-Makefile.kmk (new)
   1.3       +0 -50     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxInternalManage.cpp (dead)
   1.2       +0 -37     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxManageHelp.cpp (dead)
   1.2       +0 -23     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VBoxManage-VBoxManageModifyVM.cpp (dead)
   1.1       +11 -0     ports/emulators/virtualbox-ose/files/patch-src-VBox-Frontends-VirtualBox-src-settings-vm-VBoxVMSettingsHD.h (new)
   1.2       +3 -3      ports/emulators/virtualbox-ose/files/patch-src-VBox-HostDrivers-Makefile.kmk
   1.2       +0 -14     ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-AudioAdapterImpl.cpp (dead)
   1.2       +0 -11     ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-ConsoleImpl.cpp (dead)
   1.2       +0 -103    ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-ConsoleImpl2.cpp (dead)
   1.3       +0 -20     ports/emulators/virtualbox-ose/files/patch-src-VBox-Main-include-ConsoleImpl.h (dead)
   1.2       +0 -16     ports/emulators/virtualbox-ose/files/patch-src-VBox-Runtime-r3-posix-fileio-posix.cpp (dead)
   1.2       +0 -12     ports/emulators/virtualbox-ose/files/patch-src-settings-vm-VBoxVMSettingsAudio.cpp (dead)
   1.3       +0 -22     ports/emulators/virtualbox-ose/files/pkg-install.in (dead)
   1.14      +12 -1     ports/emulators/virtualbox-ose/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
