From nobody@FreeBSD.org  Sun May 16 03:04:30 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3AA27106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 16 May 2010 03:04:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 2A9CE8FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 16 May 2010 03:04:30 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o4G34TsD007298
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 16 May 2010 03:04:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o4G34TL7007297;
	Sun, 16 May 2010 03:04:29 GMT
	(envelope-from nobody)
Message-Id: <201005160304.o4G34TL7007297@www.freebsd.org>
Date: Sun, 16 May 2010 03:04:29 GMT
From: Emil Smolenski <ambsd@raisa.eu.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: chris@officialunix.com

>Number:         146626
>Category:       ports
>Synopsis:       [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 16 03:10:02 UTC 2010
>Closed-Date:    Mon May 17 13:17:10 UTC 2010
>Last-Modified:  Fri May 21 08:50:18 UTC 2010
>Originator:     Emil Smolenski
>Release:        FreeBSD 8.0-STABLE
>Organization:
>Environment:
FreeBSD bolt 8.0-STABLE FreeBSD 8.0-STABLE #10: Thu May 13 17:29:11 CEST 2010     root@bolt:/usr/obj/usr/src/sys/BOLT  i386
>Description:
The print/hplip3 port installs corrupted gzip files. It makes this software almost unusable:
- many PPD files are corrupted,
- it is impossible to print test page.
>How-To-Repeat:
1. Install print/hplip3.
2. Try to print test page with hp-testpage. It fails.

$ cd /usr/local/share/hplip/data/ps/
$ gzip -t testpage.ps.gz
gzip: invalid compressed data--crc error
gzip: testpage.ps.gz: uncompress failed
>Fix:
Define proper DOS2UNIX_REGEX in Makefile (patch is attached). I think PORTREVISION should be bumped.

Patch attached with submission follows:

diff -ruN /usr/ports/print/hplip3.orig/Makefile /usr/ports/print/hplip3/Makefile
--- /usr/ports/print/hplip3.orig/Makefile	2010-05-14 13:43:23.000000000 +0200
+++ /usr/ports/print/hplip3/Makefile	2010-05-16 03:53:37.126496801 +0200
@@ -48,6 +48,7 @@
 MAKE_JOBS_SAFE=	yes
 SUB_FILES=	pkg-message
 USE_DOS2UNIX=	yes
+DOS2UNIX_REGEX=.+\.(c|cpp|h|py)$
 DOCSDIR=	${PREFIX}/share/doc/${PORTNAME}-${PORTVERSION}
 
 CPPFLAGS+=	-I${LOCALBASE}/include


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->delphij 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun May 16 03:10:13 UTC 2010 
Responsible-Changed-Why:  
delphij@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146626 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun May 16 03:10:17 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146626 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: chris@officialunix.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/146626: [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes
Date: Sun, 16 May 2010 03:10:15 UT

 Maintainer of print/hplip3,
 
 Please note that PR ports/146626 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146626
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Chris Petrik <c.petrik.sosa@gmail.com>
To: bug-followup@FreeBSD.org, ambsd@raisa.eu.org
Cc:  
Subject: Re: ports/146626: [PATCH] print/hplip3 gzip files curruption with 
	USE_DOS2UNIX=yes
Date: Sun, 16 May 2010 10:06:12 -0500

 This patch can be commited.

From: Chris Petrik <c.petrik.sosa@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/146626: [PATCH] print/hplip3 gzip files curruption with 
	USE_DOS2UNIX=yes
Date: Mon, 17 May 2010 01:19:44 -0500

 Please hold off this PR until print/hplip is updated and print/hplip3
 is removed.
State-Changed-From-To: feedback->suspended 
State-Changed-By: delphij 
State-Changed-When: Mon May 17 06:59:21 UTC 2010 
State-Changed-Why:  
Maintainer approved the change but requests hold off until 
print/hplip update. 


Responsible-Changed-From-To: delphij->freebsd-ports 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Mon May 17 06:59:21 UTC 2010 
Responsible-Changed-Why:  
Return to pool. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146626 
State-Changed-From-To: suspended->closed 
State-Changed-By: pav 
State-Changed-When: Mon May 17 13:17:02 UTC 2010 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146626 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/146626: commit references a PR
Date: Mon, 17 May 2010 13:17:12 +0000 (UTC)

 pav         2010-05-17 13:16:57 UTC
 
   FreeBSD ports repository
 
   Modified files:
     print/hplip          Makefile 
   Log:
   - Fix dos2unix corruption of gz files
   
   PR:             ports/146626
   Submitted by:   Emil Smolenski <ambsd@raisa.eu.org>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.32      +1 -0      ports/print/hplip/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: chris@officialunix.com
To: bug-followup@FreeBSD.org,
 ambsd@raisa.eu.org
Cc:  
Subject: Re: ports/146626: [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes
Date: Sun, 16 May 2010 08:03:14 -0500

 This patch can be approved/commited
 
 

From: chris@officialunix.com
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/146626: [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes
Date: Sun, 16 May 2010 08:57:24 -0500

 This patch can be approved/commited
 
 
 

From: chris@officialunix.com
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/146626: [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes
Date: Sun, 16 May 2010 08:59:02 -0500

  Yeap, the patch is fine
 
 
 
>Unformatted:
