From nobody@FreeBSD.org  Thu May  6 05:59:20 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9E0B4106567A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 May 2010 05:59:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 8E1AA8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 May 2010 05:59:20 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o465xKBj021041
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 May 2010 05:59:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o465xK6D021040;
	Thu, 6 May 2010 05:59:20 GMT
	(envelope-from nobody)
Message-Id: <201005060559.o465xK6D021040@www.freebsd.org>
Date: Thu, 6 May 2010 05:59:20 GMT
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] [bsd.port.mk] fix USE_DOS2UNIX info output
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         146347
>Category:       ports
>Synopsis:       [patch] [bsd.port.mk] fix USE_DOS2UNIX info output
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 06 06:00:12 UTC 2010
>Closed-Date:    Sat May 12 01:54:30 UTC 2012
>Last-Modified:  Sat May 12 01:54:30 UTC 2012
>Originator:     Alex Kozlov
>Release:        RELENG_8
>Organization:
private
>Environment:
>Description:
"Converting DOS text file to UNIX text file: ${f}" don't show file name because ${f} is undefined at this moment.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Mk/bsd.port.mk
@@ -3659,17 +3659,15 @@
 	@${FIND} -E ${WRKSRC} -type f -iregex '${DOS2UNIX_REGEX}' -print0 | \
 			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/$$//'
 .else
+.for f in ${USE_DOS2UNIX}
 	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 .if ${USE_DOS2UNIX:M*/*}
-.for f in ${USE_DOS2UNIX}
 	@${REINPLACE_CMD} -i '' -e 's/$$//' ${WRKSRC}/${f}
-.endfor
 .else
-.for f in ${USE_DOS2UNIX}
 	@${FIND} ${WRKSRC} -type f -name '${f}' -print0 | \
 			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/$$//'
-.endfor
 .endif
+.endfor
 .endif
 .else
 	@${DO_NADA}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu May 6 06:00:51 UTC 2010 
Responsible-Changed-Why:  
bsd.port.mk is portmgr territory (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 

From: Florent Thoumie <flz@xbsd.org>
To: bug-followup@freebsd.org, spam@rm-rf.kiev.ua
Cc:  
Subject: Re: ports/146347: [patch] [bsd.port.mk] fix USE_DOS2UNIX info output
Date: Tue, 11 May 2010 20:28:09 +0100

 I think another line has to be changed:
 
 .if ${USE_DOS2UNIX:M*/*}
 
 should probably be:
 
 .if ${f:M*/*}!=""
 
 Patch looks good otherwise.
 
 -- 
 Florent Thoumie
 flz@FreeBSD.org
 FreeBSD Committer

From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Florent Thoumie <flz@xbsd.org>, bug-followup@freebsd.org,
	spam@rm-rf.kiev.ua
Cc:  
Subject: Re: ports/146347: [patch] [bsd.port.mk] fix USE_DOS2UNIX info
 output
Date: Tue, 11 May 2010 22:57:15 +0300

 --azLHFNyN32YCQGCU
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Tue, May 11, 2010 at 08:28:09PM +0100, Florent Thoumie wrote:
 > I think another line has to be changed:
 > 
 > .if ${USE_DOS2UNIX:M*/*}
 > 
 > should probably be:
 > 
 > .if ${f:M*/*}!=""
 > 
 > Patch looks good otherwise.
 You're right. Regenerated patch.
 
 --azLHFNyN32YCQGCU
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch.txt"
 
 Index: Mk/bsd.port.mk
 @@ -3659,17 +3659,15 @@
  	@${FIND} -E ${WRKSRC} -type f -iregex '${DOS2UNIX_REGEX}' -print0 | \
  			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/
 $$//'
  .else
 -	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 -.if ${USE_DOS2UNIX:M*/*}
  .for f in ${USE_DOS2UNIX}
 +	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 +.if ${f:M*/*}!=""
  	@${REINPLACE_CMD} -i '' -e 's/
 $$//' ${WRKSRC}/${f}
 -.endfor
  .else
 -.for f in ${USE_DOS2UNIX}
  	@${FIND} ${WRKSRC} -type f -name '${f}' -print0 | \
  			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/
 $$//'
 -.endfor
  .endif
 +.endfor
  .endif
  .else
  	@${DO_NADA}
 
 --azLHFNyN32YCQGCU--
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Mon Aug 16 13:04:13 UTC 2010 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 
State-Changed-From-To: feedback->open 
State-Changed-By: pav 
State-Changed-When: Mon Aug 16 13:14:31 UTC 2010 
State-Changed-Why:  
Uh 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Mon Aug 16 13:14:47 UTC 2010 
State-Changed-Why:  
The last patch reverses the logic, the strings matching */* are applied as find 
patterns and vice versa. You need to fix that. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 

From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: bug-followup@freebsd.org, pav@FreeBSD.org, portmgr@FreeBSD.org,
	spam@rm-rf.kiev.ua
Cc:  
Subject: Re: ports/146347: [patch] [bsd.port.mk] fix USE_DOS2UNIX info
 output
Date: Sat, 21 Aug 2010 19:53:44 +0300

 --d6Gm4EdcadzBjdND
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Mon, Aug 16, 2010 at 01:15:48PM +0000, pav@FreeBSD.org wrote:
 > Synopsis: [patch] [bsd.port.mk] fix USE_DOS2UNIX info output
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: pav
 > State-Changed-When: Mon Aug 16 13:14:47 UTC 2010
 > State-Changed-Why: 
 > The last patch reverses the logic, the strings matching */* are applied as find
 > patterns and vice versa. You need to fix that.
 Sorry for delay, I was offline for a whole week.
 Please check this patch.
 
 
 --
 Adios
 
 --d6Gm4EdcadzBjdND
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch.txt"
 
 Index: Mk/bsd.port.mk
 @@ -3653,17 +3653,15 @@
  	@${FIND} -E ${WRKSRC} -type f -iregex '${DOS2UNIX_REGEX}' -print0 | \
  			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/
 $$//'
  .else
 -	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 -.if ${USE_DOS2UNIX:M*/*}
  .for f in ${USE_DOS2UNIX}
 +	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 +.if ${f:N*/*}!=""
  	@${REINPLACE_CMD} -i '' -e 's/
 $$//' ${WRKSRC}/${f}
 -.endfor
  .else
 -.for f in ${USE_DOS2UNIX}
  	@${FIND} ${WRKSRC} -type f -name '${f}' -print0 | \
  			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/
 $$//'
 -.endfor
  .endif
 +.endfor
  .endif
  .else
  	@${DO_NADA}
 
 --d6Gm4EdcadzBjdND--
State-Changed-From-To: feedback->open 
State-Changed-By: pav 
State-Changed-When: Sat Aug 21 17:59:13 UTC 2010 
State-Changed-Why:  
Feedback received 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 
State-Changed-From-To: open->analyzed 
State-Changed-By: erwin 
State-Changed-When: Wed Oct 13 11:06:15 UTC 2010 
State-Changed-Why:  
Take for -exp run 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 
State-Changed-From-To: analyzed->feedback 
State-Changed-By: erwin 
State-Changed-When: Wed Oct 13 12:10:39 UTC 2010 
State-Changed-Why:  
Generating INDEX-8 - please wait.. 
"/a/portbuild/i386/8-exp/builds/20101013112105/ports/Mk/bsd.port.mk", line 3687: Malformed conditional (Release History.txt!="") 

Line 3687 reads: 
.if ${f:N*/*}!="" 


http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 
State-Changed-From-To: feedback->closed 
State-Changed-By: erwin 
State-Changed-When: Sat May 12 01:54:22 UTC 2012 
State-Changed-Why:  
No feedback received. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146347 
>Unformatted:
