From jr@opal.com  Fri Apr 30 18:17:38 2010
Return-Path: <jr@opal.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6E263106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Apr 2010 18:17:38 +0000 (UTC)
	(envelope-from jr@opal.com)
Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 291398FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Apr 2010 18:17:37 +0000 (UTC)
Received: from 135.78.171.66.subscriber.vzavenue.net (HELO homobox.opal.com) ([66.171.78.135])
  by smtp.vzavenue.net with ESMTP; 30 Apr 2010 14:17:31 -0400
Received: from opal.com (localhost [IPv6:::1])
	(authenticated bits=0)
	by homobox.opal.com (8.14.3/8.14.3) with ESMTP id o3UIHTX6005330
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Apr 2010 14:17:29 -0400 (EDT)
	(envelope-from jr@opal.com)
Received: from shibato.opal.com ([2001:5c0:1100:f103:221:63ff:fe5a:c9a7]
	helo=shibato.opal.com) with IPv6:587 by opal.com; 30 Apr 2010
	14:17:29 -0400
Received: from shibato.opal.com (localhost [127.0.0.1])
	by shibato.opal.com (8.14.3/8.14.3) with ESMTP id o3UIHT0E019680
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 30 Apr 2010 14:17:29 -0400 (EDT)
	(envelope-from jr@opal.com)
Received: (from jr@localhost)
	by shibato.opal.com (8.14.3/8.14.3/Submit) id o3UIHTuK019679;
	Fri, 30 Apr 2010 14:17:29 -0400 (EDT)
	(envelope-from jr)
Message-Id: <201004301817.o3UIHTuK019679@shibato.opal.com>
Date: Fri, 30 Apr 2010 14:17:29 -0400 (EDT)
From: "J.R. Oldroyd" <fbsd@opal.com>
Reply-To: "J.R. Oldroyd" <fbsd@opal.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: port devel/gobject-introspection variable expansion error
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         146192
>Category:       ports
>Synopsis:       port devel/gobject-introspection variable expansion error
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 30 18:20:07 UTC 2010
>Closed-Date:    Thu Jun 24 17:06:29 UTC 2010
>Last-Modified:  Thu Jun 24 17:06:29 UTC 2010
>Originator:     J.R. Oldroyd
>Release:        FreeBSD 8.0-RELEASE-p2 amd64
>Organization:
>Environment:
System: FreeBSD xx.opal.com 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #5: Fri Apr 16 09:02:36 EDT 2010 xx@xx.opal.com:/usr/src/sys/amd64/compile/XX amd64
>Description:
This port has Makefiles that use the varaible "$$PYTHONPATH".  This is not a valid
expansion in this context - it picks up the value of a variable "$P" should it exist
rather than "$PYTHONPATH" as intended.

The proper syntax is "$$(PYTHONPATH)".
>How-To-Repeat:
export P="foobar"
make
watch it fail
>Fix:
--- common.mk.orig	2009-12-14 18:00:16.000000000 -0500
+++ common.mk	2010-04-26 12:12:34.000000000 -0400
@@ -1,5 +1,5 @@
 SCANNER_BIN = $(top_builddir)/tools/g-ir-scanner
-SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$PYTHONPATH
+SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$(PYTHONPATH)
 SCANNER_ENV = env PYTHONPATH=$(SCANNER_PYTHONPATH) \
 	UNINSTALLED_INTROSPECTION_SRCDIR=$(top_srcdir) \
 	UNINSTALLED_INTROSPECTION_BUILDDIR=$(top_builddir)
--- gir/Makefile.in.orig	2010-04-26 12:06:28.000000000 -0400
+++ gir/Makefile.in	2010-04-26 12:07:20.000000000 -0400
@@ -292,7 +292,7 @@
 top_builddir = @top_builddir@
 top_srcdir = @top_srcdir@
 SCANNER_BIN = $(top_builddir)/tools/g-ir-scanner
-SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$PYTHONPATH
+SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$(PYTHONPATH)
 SCANNER_ENV = env PYTHONPATH=$(SCANNER_PYTHONPATH) \
 	UNINSTALLED_INTROSPECTION_SRCDIR=$(top_srcdir) \
 	UNINSTALLED_INTROSPECTION_BUILDDIR=$(top_builddir)
@@ -359,13 +359,12 @@
 GLib_2_0_gir_PACKAGES = glib-2.0
 GLib_2_0_gir_CFLAGS = $(CPPFLAGS) \
             -I$(GLIB_INCLUDEDIR) \
-            -I$(GLIB_LIBDIR)/glib-2.0/include \
             -DGETTEXT_PACKAGE=Dummy \
             -D__G_I18N_LIB_H__
 
 GLib_2_0_gir_ASSERTIONS = $(srcdir)/GLib-2.0.xpath
 GLib_2_0_gir_FILES = \
-                $(GLIB_LIBDIR)/glib-2.0/include/glibconfig.h \
+                $(GLIB_INCLUDEDIR)/glibconfig.h \
             $(GLIB_INCLUDEDIR)/glib/*.h \
                 $(srcdir)/glib-2.0.c
 
--- tests/offsets/Makefile.in.orig	2010-04-26 12:13:13.000000000 -0400
+++ tests/offsets/Makefile.in	2010-04-26 12:16:34.000000000 -0400
@@ -277,7 +277,7 @@
 top_builddir = @top_builddir@
 top_srcdir = @top_srcdir@
 SCANNER_BIN = $(top_builddir)/tools/g-ir-scanner
-SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$PYTHONPATH
+SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$(PYTHONPATH)
 SCANNER_ENV = env PYTHONPATH=$(SCANNER_PYTHONPATH) \
 	UNINSTALLED_INTROSPECTION_SRCDIR=$(top_srcdir) \
 	UNINSTALLED_INTROSPECTION_BUILDDIR=$(top_builddir)
--- tests/scanner/Makefile.in.orig	2010-04-26 12:13:13.000000000 -0400
+++ tests/scanner/Makefile.in	2010-04-26 12:15:31.000000000 -0400
@@ -304,7 +304,7 @@
 top_builddir = @top_builddir@
 top_srcdir = @top_srcdir@
 SCANNER_BIN = $(top_builddir)/tools/g-ir-scanner
-SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$PYTHONPATH
+SCANNER_PYTHONPATH = $(top_builddir):$(top_srcdir):$$(PYTHONPATH)
 SCANNER_ENV = env PYTHONPATH=$(SCANNER_PYTHONPATH) \
 	UNINSTALLED_INTROSPECTION_SRCDIR=$(top_srcdir) \
 	UNINSTALLED_INTROSPECTION_BUILDDIR=$(top_builddir)
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Apr 30 18:20:25 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146192 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Thu Jun 24 17:06:03 UTC 2010 
State-Changed-Why:  
Looks like latest version of it has fixed it. Don't see any of $$PYTHONPATH 
in there anymore. Thanks for report/submit! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146192 
>Unformatted:
