From leres@ee.lbl.gov  Sat Apr 24 22:37:09 2010
Return-Path: <leres@ee.lbl.gov>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8EBCD106564A
	for <freebsd-gnats-submit@freebsd.org>; Sat, 24 Apr 2010 22:37:09 +0000 (UTC)
	(envelope-from leres@ee.lbl.gov)
Received: from fun.ee.lbl.gov (fun.ee.lbl.gov [131.243.2.202])
	by mx1.freebsd.org (Postfix) with ESMTP id 776A48FC13
	for <freebsd-gnats-submit@freebsd.org>; Sat, 24 Apr 2010 22:37:09 +0000 (UTC)
Received: from [172.16.1.17] (ice.ee.lbl.gov [131.243.2.213])
	(authenticated bits=0)
	by fun.ee.lbl.gov (8.14.4/8.14.4) with ESMTP id o3OMb8O1069316
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT)
	for <freebsd-gnats-submit@freebsd.org>; Sat, 24 Apr 2010 15:37:09 -0700 (PDT)
Message-Id: <4BD37294.1040508@ee.lbl.gov>
Date: Sat, 24 Apr 2010 15:37:08 -0700
From: Craig Leres <leres@ee.lbl.gov>
To: freebsd-gnats-submit@freebsd.org
Subject: sysutils/coreutils: missing dependency on math/gmp

>Number:         146027
>Category:       ports
>Synopsis:       sysutils/coreutils: missing dependency on math/gmp
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    makc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 24 22:40:06 UTC 2010
>Closed-Date:    Sun Apr 25 15:32:39 UTC 2010
>Last-Modified:  Sun Apr 25 15:40:03 UTC 2010
>Originator:     Craig Leres
>Release:        FreeBSD 7.2-RELEASE amd64
>Organization:
Lawrence Berkeley National Laboratory
>Environment:
	    FreeBSD hot.ee.lbl.gov 7.2-RELEASE FreeBSD 7.2-RELEASE #6: Mon Apr
 5 18:55:55 PDT 2010
leres@hot.ee.lbl.gov:/usr/src/7.2-RELEASE/sys/amd64/compile/LBLSMPIPV6
amd64

>Description:
	If gmp is not installed when coreutils is built, all is
	well. But if gmp is installed, some binaries (e.g. gexpr)
	link against libgmp. If you later remove gmp, these programs
	fail.

>How-To-Repeat:

    % pkg_info | egrep 'coreutil|gmp'
    coreutils-7.5       The Free Software Foundation's core utilities
    gmp-5.0.1           A free library for arbitrary precision arithmetic
    hot 19 % ldd /usr/local/bin/gexpr
    /usr/local/bin/gexpr:
	    libintl.so.8 => /usr/local/lib/libintl.so.8 (0x80064f000)
	    libgmp.so.10 => /usr/local/lib/libgmp.so.10 (0x800758000)
	    libc.so.7 => /lib/libc.so.7 (0x8008c2000)
	    libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x800ae6000)
    % pkg_info -r coreutils-7.5
    Information for coreutils-7.5:

    Depends on:
    Dependency: libiconv-1.13.1_1
    Dependency: gettext-0.17_1

>Fix:
	Add a package dependency on gmp if it was installed when
	coreutils was built (see attached patch).


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvTcpAACgkQWxlAhAje3JvItgCgghkzdfl2SEibiIGLvele1r4s
OcMAmwT28MiyE/wLLsZy5M+4DrDiCWuk
=5bfW
-----END PGP SIGNATURE-----

--------------090905040701020809000609
Content-Type: text/plain;
 name="Makefile.diff.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="Makefile.diff.txt"

--- Makefile-	2009-09-16 04:26:06.000000000 -0700
+++ Makefile	2010-04-24 15:24:47.000000000 -0700
@@ -14,6 +14,13 @@
 MAINTAINER=	jharris@widomaker.com
 COMMENT=	The Free Software Foundation's core utilities
 
+# coreutils links against libgmp when present
+HAVE_LIBGMP!=	pkg_info -E gmp-* || true
+
+.if !empty(HAVE_LIBGMP)
+LIB_DEPENDS+=	libgmp:math/gmp
+.endif
+
 CONFLICTS=	id-utils-[0-9]* linux-gid-[0-9]*
 
 GNU_CONFIGURE=	yes

--------------090905040701020809000609
Content-Type: application/octet-stream;
 name="Makefile.diff.txt.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="Makefile.diff.txt.sig"

iEYEABECAAYFAkvTcpQACgkQWxlAhAje3JtK5ACfSXlSajrh+NrYkG5xkrB3EAR6VFEAn2a0
Rg/umRnE6JYWidf1ZEF8ZDuE
--------------090905040701020809000609--
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Apr 24 22:40:17 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146027 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: jharris@widomaker.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/146027: sysutils/coreutils: missing dependency on math/gmp
Date: Sat, 24 Apr 2010 22:40:15 UT

 Maintainer of sysutils/coreutils,
 
 Please note that PR ports/146027 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/146027
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Jason Harris <jharris@widomaker.com>
To: bug-followup@FreeBSD.org
Cc: Jason Harris <jharris@widomaker.com>
Subject: Re: ports/146027: sysutils/coreutils: missing dependency on
	math/gmp
Date: Sat, 24 Apr 2010 21:59:12 -0400

 --fdj2RfSjLxBAspz7
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sat, Apr 24, 2010 at 10:40:15PM +0000, Edwin Groothuis wrote:
 > Maintainer of sysutils/coreutils,
 >=20
 > Please note that PR ports/146027 has just been submitted.
 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/146027
 
 Approved, thanks!
 
 --=20
 Jason Harris           |  NIC:  JH329, PGP:  This _is_ PGP-signed, isn't it?
 jharris@widomaker.com _|_ web:  http://keyserver.kjsl.com/~jharris/
           Got photons?   (TM), (C) 2004
 
 --fdj2RfSjLxBAspz7
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.9 (FreeBSD)
 
 iJ0EARECAF0FAkvTofBWGGh0dHA6Ly9rZXlzZXJ2ZXIua2pzbC5jb206MTEzNzEv
 cGtzL2xvb2t1cD9vcD1nZXQmc2VhcmNoPTB4RDM5REEwRTMmd2VoYXZleW91bm93
 PXRydWUACgkQSypIl9OdoON9CwCgyvQ1DZ6k2S4e6I/TeyB+NV9Dv6QAniFKUBya
 mTV3eapuAOQ0LH87M/rb
 =EHhz
 -----END PGP SIGNATURE-----
 
 --fdj2RfSjLxBAspz7--
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Sun Apr 25 08:15:41 UTC 2010 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146027 
Responsible-Changed-From-To: freebsd-ports-bugs->makc 
Responsible-Changed-By: makc 
Responsible-Changed-When: Sun Apr 25 12:38:44 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146027 
State-Changed-From-To: open->closed 
State-Changed-By: makc 
State-Changed-When: Sun Apr 25 15:32:38 UTC 2010 
State-Changed-Why:  
A different patch has been committed. Thanks for report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146027 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/146027: commit references a PR
Date: Sun, 25 Apr 2010 15:31:26 +0000 (UTC)

 makc        2010-04-25 15:31:17 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/coreutils   Makefile 
   Log:
   Some utils link with gmp library if exists.
   Add optional dependency on math/gmp and disable gmp support
   properly when it's not needed.
   
   PR:             ports/146027
   Reported by:    Craig Leres <leres at ee.lbl.gov>
   
   Revision  Changes    Path
   1.26      +18 -8     ports/sysutils/coreutils/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
 This is a multi-part message in MIME format.
 --------------090905040701020809000609
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
