From swell.k@gmail.com  Sat Apr 17 17:52:30 2010
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1B67B106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Apr 2010 17:52:30 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-bw0-f214.google.com (mail-bw0-f214.google.com [209.85.218.214])
	by mx1.freebsd.org (Postfix) with ESMTP id 9E50D8FC1F
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Apr 2010 17:52:29 +0000 (UTC)
Received: by bwz6 with SMTP id 6so3102706bwz.13
        for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Apr 2010 10:52:28 -0700 (PDT)
Received: by 10.204.15.5 with SMTP id i5mr2977294bka.182.1271526748048;
        Sat, 17 Apr 2010 10:52:28 -0700 (PDT)
Received: from localhost (89-178-231-147.broadband.corbina.ru [89.178.231.147])
        by mx.google.com with ESMTPS id 16sm2396410bwz.5.2010.04.17.10.52.26
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Sat, 17 Apr 2010 10:52:27 -0700 (PDT)
Message-Id: <86bpdi55ly.fsf@gmail.com>
Date: Sat, 17 Apr 2010 21:52:25 +0400
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] net/wireshark: mask c-ares under CARES knob like curl does

>Number:         145787
>Category:       ports
>Synopsis:       [patch] net/wireshark: mask c-ares under CARES knob like curl does
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 17 18:00:06 UTC 2010
>Closed-Date:    Sat May 22 05:24:10 UTC 2010
>Last-Modified:  Sat May 22 05:30:04 UTC 2010
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Prevent the port from silently picking up c-ares dependency.
>How-To-Repeat:
1. install dns/c-ares
2. install net/wireshark
3. check wireshark binary for dependency on libcares.so.2
4. deinstall dns/c-ares, port system shouldn't warn you
>Fix:
--- wireshark.diff begins here ---
Index: net/wireshark/Makefile
===================================================================
RCS file: /a/.cvsup/ports/net/wireshark/Makefile,v
retrieving revision 1.152
diff -u -p -r1.152 Makefile
--- net/wireshark/Makefile	28 Mar 2010 06:41:30 -0000	1.152
+++ net/wireshark/Makefile	17 Apr 2010 17:31:18 -0000
@@ -68,6 +68,7 @@ USE_XORG=	x11
 OPTIONS=	RTP "Enable support for playing back RTP streams" off \
 		SNMP "Enable SNMP OID translation support" on \
 		ADNS "Enable asynchronous DNS lookup support" on \
+		CARES "Asynchronous DNS resolution via c-ares" off \
 		PCRE "Enable regular expression matching support" on \
 		IPV6 "Enable IPv6 support" on \
 		GEOIP "Enable GeoIP lookups" on \
@@ -141,6 +142,13 @@ CONFIGURE_ARGS+=	--with-adns=${LOCALBASE
 CONFIGURE_ARGS+=	--with-adns=no
 .endif
 
+.if !defined(WITHOUT_CARES) && !defined(LITE)
+LIB_DEPENDS+=	cares.2:${PORTSDIR}/dns/c-ares
+CONFIGURE_ARGS+=	--with-c-ares=${LOCALBASE}/lib
+.else
+CONFIGURE_ARGS+=	--with-c-ares=no
+.endif
+
 .if !defined(WITHOUT_GEOIP) && !defined(LITE)
 LIB_DEPENDS+=	GeoIP.5:${PORTSDIR}/net/GeoIP
 CONFIGURE_ARGS+=	--with-geoip=${LOCALBASE}/lib
--- wireshark.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Apr 17 18:00:18 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145787 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Sat May 22 05:24:00 UTC 2010 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145787 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/145787: commit references a PR
Date: Sat, 22 May 2010 05:24:07 +0000 (UTC)

 marcus      2010-05-22 05:23:54 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/wireshark        Makefile 
   Log:
   Add optional C-ARES async DNS support.
   
   PR:             145787
   Submitted by:   Anonymous <swell.k@gmail.com>
   
   Revision  Changes    Path
   1.154     +9 -1      ports/net/wireshark/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
