From nobody@FreeBSD.org  Tue Apr 13 09:39:24 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4E9F4106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Apr 2010 09:39:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3D6998FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Apr 2010 09:39:24 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o3D9dOiR030311
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Apr 2010 09:39:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o3D9dNfC030303;
	Tue, 13 Apr 2010 09:39:23 GMT
	(envelope-from nobody)
Message-Id: <201004130939.o3D9dNfC030303@www.freebsd.org>
Date: Tue, 13 Apr 2010 09:39:23 GMT
From: Demelier David <demelier.david@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: audio/gnome-media hard dep on pulseaudio
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         145669
>Category:       ports
>Synopsis:       audio/gnome-media hard dep on pulseaudio
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 13 09:40:03 UTC 2010
>Closed-Date:    Sun Jul 25 14:28:39 UTC 2010
>Last-Modified:  Sun Jul 25 14:30:15 UTC 2010
>Originator:     Demelier David
>Release:        8.0-RELEASE
>Organization:
>Environment:
FreeBSD Abricot.malikania.fr 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #1: Mon Apr 12 14:01:27 CEST 2010     root@Abricot.malikania.fr:/usr/obj/usr/src/sys/Abricot  i386

>Description:
gnome-media needs pulseaudio and we can not choose option to remove it. It doesn't need it but we can add it as a optional dependency. 

You can make config-recursive in x11/gnome2-lite to remove pulseaudio on some ports, so if gnome-media needs pulseaudio it's amibugous.
>How-To-Repeat:
cd /usr/ports/x11/gnome2-lite && make config-recursive
#
# remove pulseaudio
#
make missing | grep -i pulse
echo $? # show 0 ;)
>Fix:
apply the patch below which add a pulseaudio option.

Patch attached with submission follows:

--- Makefile.orig	2010-03-28 08:31:01.000000000 +0200
+++ Makefile	2010-04-13 11:37:41.000000000 +0200
@@ -18,9 +18,17 @@
 
 BUILD_DEPENDS=	xml2po:${PORTSDIR}/textproc/gnome-doc-utils
 LIB_DEPENDS=	canberra-gtk.0:${PORTSDIR}/audio/libcanberra \
-    		pulse.0:${PORTSDIR}/audio/pulseaudio \
 		unique-1.0.2:${PORTSDIR}/x11-toolkits/unique
 
+OPTIONS=	PULSE "Enable Pulse Audio support" off
+
+.include <bsd.port.pre.mk>
+
+.if !defined(WITHOUT_PULSE)
+LIB_DEPENDS+=	pulse.0:${PORTSDIR}/audio/pulseaudio
+PLIST_SUB+=	PULSE=""
+.endif
+
 USE_BZIP2=	yes
 USE_GETTEXT=	yes
 INSTALLS_OMF=	yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Apr 13 09:40:12 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145669 

From: David DEMELIER <demelier.david@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
Cc:  
Subject: Re: ports/145669: audio/gnome-media hard dep on pulseaudio
Date: Tue, 13 Apr 2010 12:56:30 +0200

 Please remove the line
 
 +.include <bsd.port.pre.mk>
 
 It won't build if not.
 Sorry for the disturbance.
 
 2010/4/13  <FreeBSD-gnats-submit@freebsd.org>:
 > Thank you very much for your problem report.
 > It has the internal identification `ports/145669'.
 > The individual assigned to look at your
 > report is: freebsd-ports-bugs.
 >
 > You can access the state of your problem report at any time
 > via this link:
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D145669
 >
 >>Category: =A0 =A0 =A0 ports
 >>Responsible: =A0 =A0freebsd-ports-bugs
 >>Synopsis: =A0 =A0 =A0 audio/gnome-media hard dep on pulseaudio
 >>Arrival-Date: =A0 Tue Apr 13 09:40:03 UTC 2010
 >
 
 
 
 --=20
 Demelier David
State-Changed-From-To: open->analyzed 
State-Changed-By: mezz 
State-Changed-When: Wed Apr 28 02:42:49 UTC 2010 
State-Changed-Why:  
The patch doesn't look right. It needs the --disable-pulseaudio (or something) 
like that. I will check more in it this weekend. 

By the way, when you ran config-recursive in the higher level. It does not 
means that it will be complete disable option in all the ports. It's merely 
pick up from one of lower ports' option, not in gnome-lite. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145669 
State-Changed-From-To: analyzed->patched 
State-Changed-By: mezz 
State-Changed-When: Thu Jun 24 17:04:30 UTC 2010 
State-Changed-Why:  
I have committed it into MarcusCom ports-stable and it will be merged into 
FreeBSD ports tree when FreeBSD 8.1 released. Your patch was incompleted as 
it needs the changes in the plist too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145669 
State-Changed-From-To: patched->closed 
State-Changed-By: kwm 
State-Changed-When: Sun Jul 25 14:28:23 UTC 2010 
State-Changed-Why:  
Committed thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145669 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/145669: commit references a PR
Date: Sun, 25 Jul 2010 14:27:47 +0000 (UTC)

 kwm         2010-07-25 14:27:33 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/gnome-media    Makefile pkg-plist 
   Log:
   Make the dependancy on pulseaudio optional.
   
   PR:             ports/145669 (based on)
   Submitted by:   Demelier David <demelier.david@gmail.com>
   
   Revision  Changes    Path
   1.103     +16 -4     ports/audio/gnome-media/Makefile
   1.43      +45 -45    ports/audio/gnome-media/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
